RFA: fix to thinko in make-relative-prefix.c:make_relative_prefix_1

RFA: fix to thinko in make-relative-prefix.c:make_relative_prefix_1

[Douglas Evans]

Simple thinko.  Return of NULL from strdup isn't checked.

Ok to check in?

2007-11-13  Doug Evans  <dje@google.com>

        * make-relative-prefix.c (make_relative_prefix_1): Handle NULL
        return from strdup.

Index: make-relative-prefix.c
===================================================================
*** make-relative-prefix.c      (revision 130159)
--- make-relative-prefix.c      (working copy)
*************** make_relative_prefix_1 (const char *prog
*** 292,305 ****
        }
      }

!   if ( resolve_links )
!     {
!       full_progname = lrealpath (progname);
!       if (full_progname == NULL)
!       return NULL;
!     }
    else
!     full_progname = strdup(progname);

    prog_dirs = split_directories (full_progname, &prog_num);
    free (full_progname);
--- 292,303 ----
        }
      }

!   if (resolve_links)
!     full_progname = lrealpath (progname);
    else
!     full_progname = strdup (progname);
!   if (full_progname == NULL)
!     return NULL;

    prog_dirs = split_directories (full_progname, &prog_num);
    free (full_progname);

Re: RFA: fix to thinko in make-relative-prefix.c:make_relative_prefix_1

[Ian Lance Taylor]

"Douglas Evans" <dje@google.com> writes:

> Simple thinko.  Return of NULL from strdup isn't checked.
> 
> Ok to check in?
> 
> 2007-11-13  Doug Evans  <dje@google.com>
> 
>         * make-relative-prefix.c (make_relative_prefix_1): Handle NULL
>         return from strdup.

This is OK.

However, at this point it should wait until gcc 4.3 has branched.
Sorry for the rather slow review.

Thanks.

Ian