From: Andrew Stubbs <ams@codesourcery.com>
To: Thomas Schwinge <thomas@codesourcery.com>
Cc: <gcc-patches@gcc.gnu.org>, Jakub Jelinek <jakub@redhat.com>
Subject: Re: [PR93488] [OpenACC] ICE in type-cast 'async', 'wait' clauses
Date: Wed, 29 Jan 2020 13:32:00 -0000 [thread overview]
Message-ID: <e3da478f-e33b-404f-9ed6-b7c4ce6e82c8@codesourcery.com> (raw)
In-Reply-To: <87r1zimomb.fsf@euler.schwinge.homeip.net>
On 29/01/2020 12:30, Thomas Schwinge wrote:
> Hi Andrew!
>
> On 2019-11-22T11:06:14+0000, Andrew Stubbs <ams@codesourcery.com> wrote:
>> This test case causes an ICE (reformatted for email):
>>
>> void test(int k)
>> {
>> unsigned int x = 1;
>> #pragma acc parallel loop async(x)
>> for (int i = 0; i < k; i++) { }
>> }
>
> Curious, why didn't you include such a test case in your actual patch?
Because I'm a terrible person.
>> t.c: In function 'test':
>> t.c:4:9: error: invalid argument to gimple call
>> 4 | #pragma acc parallel loop async(x)
>> | ^~~
>> (int) x
>> __builtin_GOACC_parallel_keyed (-1, test._omp_fn.0, 1,
>> &.omp_data_arr.3, &.omp_data_sizes.4,
>> &.omp_data_kinds.5, 536936447,
>> (int) x, 0);
>> during GIMPLE pass: ompexp
>> dump file: t.c.013t.ompexp
>> t.c:4:9: internal compiler error: verify_gimple failed
>>
>> The problem is that "x" needs to be cast to "int" (from "unsigned int")
>> before calling the function, and that's not valid in a gimple call.
>
> ACK, thanks.
>
>> The attached patch assigns the "(int) x" to a temporary and passes that
>> to the function instead.
>>
>> OK to commit?
>
> A little bit more thoroughness, please. :-)
>
> As can be seen in the code a few lines below, the very same problem also
> exists for the 'wait' clause; it seems reasonable to fix both at the same
> time. This is not a recent regression, but a user-visible valid-code ICE
> that has existed "forever"; I filed <https://gcc.gnu.org/PR93488> "ICE in
> type-cast 'async', 'wait' clauses" for tracking. This problem is similar
> to the OpenMP 'device' clause <https://gcc.gnu.org/PR71758> "ICE in
> verify_gimple_in_cfg, at tree-cfg.c:5212"; I suggest we also use
> 'force_gimple_operand_gsi' instead of manually doing your suggested
> 'create_tmp_var', 'gimple_build_assign', 'gsi_insert_before'. Include a
> test case that covers all relevant code paths; I've attached a test case
> to the PR, but I've not verified whether "that covers *all* relevant code
> paths". This should then be backported to all GCC release branches; I
> can easily test the backports for you, if you're not already set up to do
> such testing.
OK, I'll take a look at your testcase and cook up a patch.
Today I learned about force_gimple_operand_gsi. :-)
Andrew
next prev parent reply other threads:[~2020-01-29 12:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 11:18 [patch, openacc] Fix ICE verifying gimple Andrew Stubbs
2020-01-16 14:44 ` Andrew Stubbs
2020-01-29 12:42 ` [PR93488] [OpenACC] ICE in type-cast 'async', 'wait' clauses (was: [patch, openacc] Fix ICE verifying gimple) Thomas Schwinge
2020-01-29 13:32 ` Andrew Stubbs [this message]
2020-01-31 0:05 ` [PR93488] [OpenACC] ICE in type-cast 'async', 'wait' clauses Andrew Stubbs
2020-04-21 9:54 ` Thomas Schwinge
2020-04-23 15:02 ` Andrew Stubbs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3da478f-e33b-404f-9ed6-b7c4ce6e82c8@codesourcery.com \
--to=ams@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).