From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26438 invoked by alias); 27 Apr 2018 01:36:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 26427 invoked by uid 89); 27 Apr 2018 01:36:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=alto, Alto, blvd, eager X-HELO: homiemail-a78.g.dreamhost.com Received: from sub5.mail.dreamhost.com (HELO homiemail-a78.g.dreamhost.com) (208.113.200.129) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 27 Apr 2018 01:36:54 +0000 Received: from homiemail-a78.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a78.g.dreamhost.com (Postfix) with ESMTP id B14E348000138; Thu, 26 Apr 2018 18:36:52 -0700 (PDT) Received: from [192.168.20.41] (c-73-170-242-219.hsd1.ca.comcast.net [73.170.242.219]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by homiemail-a78.g.dreamhost.com (Postfix) with ESMTPSA id A5B4848000A36; Thu, 26 Apr 2018 18:36:49 -0700 (PDT) Subject: Re: [PATCH] [Microblaze]: PIC Data Text Relative To: Andrew Sadek , Michael Eager Cc: gcc-patches@gcc.gnu.org, nmekala@xilinx.com References: <4515bb77-93e3-ead8-ab0b-7d23ca76adc3@eagerm.com> <076c5840-f9e2-320f-6f4c-658c986ef26d@eagerm.com> <5cd4774f-13a2-5310-a27c-8298409be8d4@eagerm.com> <862b41bf-db49-5d8f-aba6-806e155d58e6@eagerm.com> <7376e3b1-c371- ac14-faf8-0f203a3ebc6a@eagercon.com> From: Michael Eager Message-ID: Date: Fri, 27 Apr 2018 01:41:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-04/txt/msg01199.txt.bz2 On 04/19/2018 03:43 AM, Andrew Sadek wrote: > On Wed, Apr 18, 2018 at 6:57 PM, Michael Eager wrote: >> >> Hi Andrew -- >> >> Check indents in the following files: >> (Make sure that your tabs are set at 8 chars.) >> --- gcc/config/microblaze/microblaze.c >> --- gcc/config/microblaze/microblaze.md >> > I have re-run check_GNU_Style.sh and no are issues are found now. I corrected a large number of indent problems in microblaze.c. >> Just a couple coding notes: >> >> microblaze.c: >> >> @@ -858,6 +879,16 @@ microblaze_classify_address (struct microblaze_add >> + && strict == 2) >> >> Include comment in function header describing meaning of strict == 2. > > Done > >> >> @@ -1022,7 +1065,7 @@ microblaze_legitimize_address (rtx x, rtx oldx ATT >> else if (flag_pic == 2 && !TARGET_PIC_DATA_TEXT_REL) >> { >> ... >> } >> else if (flag_pic == 2 && TARGET_PIC_DATA_TEXT_REL) >> { >> ... >> } >> >> It's better to factor this into >> else if (flag_pic == 2) >> { >> if (TARGET_PIC_DATA_TEXT_REL) >> { >> ... >> } >> else >> { >> ... >> } >> } >> > > Done This code pattern appears twice in microblaze_legitimize_address. I corrected the second one. The code in the second occurrence can be refactored to move if (reload_in_progress) df_set_regs_ever_live (PIC_OFFSET_TABLE_REGNUM, true); out of the if(TARGET_PIC_DATA_TEXT_REL) brackets. (Done.) Please send me an updated ChangeLog, including testsuite. -- Michael Eager eager@eagerm.com 1960 Park Blvd., Palo Alto, CA 94306