From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x133.google.com (mail-il1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) by sourceware.org (Postfix) with ESMTPS id CA96C3858D37 for ; Fri, 4 Feb 2022 02:49:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CA96C3858D37 Received: by mail-il1-x133.google.com with SMTP id m17so3722448ilj.12 for ; Thu, 03 Feb 2022 18:49:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=wdeYEsQlV4S+zCcz0/cw72TDjGn9icFyi+Ol43SufzE=; b=hx9r7eXLCM0k0I1l8J64eK6L4nqlnBeW3T6JdNELEAEpIFeX5FrJPrVzaSfdj1t+V1 TJKcPiUSAakpQWVLJxLSDe4P0457/Ymn1RzRUpdVUYIDB0RZplQzLOkYmCpnrvwi2nJ8 VCHjAJq00InAIlvk55blejHDcAoQaVfRvQbtjD6XEbC9aM5G8qKT/phklVVHJr65v202 RsuSPGsZsFucZpslXbsXWviiEDbqSx1k3I0Fi89N64rabrD72yLdqx8MdpXmKos7ysba HpSOypjoQ8r4rc5cZIsyIf+qT4n8NIQPV3ISwtgc23bZ2lNwBIaOcckoaDYW0bOYO43U fTDA== X-Gm-Message-State: AOAM530XurWCCjdZQn08jNrNazYTm+A9IllEb/tHAbKgAo/NXrT6/o13 DwgtOuZrkxtER50O+ig5kgflNXW+BDtTdQ== X-Google-Smtp-Source: ABdhPJwi1FldYdJpwsVvm8Jq+E2SIoiRcXdW0XzIwHoto4w9lELintcWcot5AuVB0M5MzvYwqN5scg== X-Received: by 2002:a05:6e02:16c6:: with SMTP id 6mr477588ilx.320.1643942957194; Thu, 03 Feb 2022 18:49:17 -0800 (PST) Received: from [192.168.0.41] (97-118-100-142.hlrn.qwest.net. [97.118.100.142]) by smtp.gmail.com with ESMTPSA id n1sm338505ilq.50.2022.02.03.18.49.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Feb 2022 18:49:16 -0800 (PST) Message-ID: Date: Thu, 3 Feb 2022 19:49:16 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH 0/3] Enable pointer_query caching throughout. Content-Language: en-US From: Martin Sebor To: David Edelsohn Cc: GCC Patches , Richard Biener References: <008f4f40-3d6c-6e50-5b95-c20444a50873@gmail.com> <751b2c64-9458-5a67-555f-469e00a4ec1c@gmail.com> In-Reply-To: <751b2c64-9458-5a67-555f-469e00a4ec1c@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.7 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Feb 2022 02:49:19 -0000 On 2/3/22 17:33, Martin Sebor wrote: > On 2/3/22 17:18, David Edelsohn wrote: >> On Thu, Feb 3, 2022 at 6:09 PM Martin Sebor wrote: >>> >>> On 2/3/22 15:56, David Edelsohn wrote: >>>> This series of patches has exploded memory usage and I can no longer >>>> bootstrap GCC on AIX. >>>> >>>> As with the Ranger problem exposed by Aldy's patch last September, >>>> something is not freeing memory. >>>> >>>> Even on systems where GCC still bootstrap, this excessive memory usage >>>> severely damages GCC compile performance. >>> >>> Does the change below by any chance make a difference?  (It's just >>> a hunch, I haven't tested it beyond quickly building stage 1 and >>> running a few tests.) >> >> Hi, Martin >> >> Thanks for the quick response.  Yes, I am able to restore bootstrap on >> AIX (32 bit) with the change. > > Let me finish testing it and if all goes well commit it later tonight. Now pushed as r12-7043. Martin > > Thanks for the confirmation! > > Martin > >> >> Thanks, David >> >>> >>> Martin >>> >>> >>> diff --git a/gcc/pointer-query.h b/gcc/pointer-query.h >>> index 4c725eeaf34..801a240c38d 100644 >>> --- a/gcc/pointer-query.h >>> +++ b/gcc/pointer-query.h >>> @@ -164,9 +164,9 @@ class pointer_query >>>      struct cache_type >>>      { >>>        /* 1-based indices into cache.  */ >>> -    vec indices; >>> +    auto_vec indices; >>>        /* The cache itself.  */ >>> -    vec access_refs; >>> +    auto_vec access_refs; >>>      }; >>> >>>    public: >