From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id CEFD63858406 for ; Fri, 4 Mar 2022 13:12:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CEFD63858406 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A26551F38C; Fri, 4 Mar 2022 13:12:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1646399570; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=91Ucr8HTzG0zrk2tlBqEmV5FFfkYonK+/wCwzsO+SuU=; b=RywMHxc09jYn5y74Gof++MmiYwNtv+KRCF7YpdV2p4sr8RObJCK+J6aSz+XX7/4ZoMXCFY ZKNgnfYEAqLstPa1EhI7tfnZJwc0Xl3VTF9cnPTAEH6lZUCFInTyxFtSuZB25a//wsmD1e hLyVjHl8ogK3tHYwpfndLOm98gyssFI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1646399570; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=91Ucr8HTzG0zrk2tlBqEmV5FFfkYonK+/wCwzsO+SuU=; b=fdgfrqi6TCdElMOEfSS0zCwQ7auNGhnjC4Tn9JQVAQyD61UZJ8/JZshG9Zu3Dx1eGE2DL6 PMaJvIMnWIOVc3Aw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8B51B13CCE; Fri, 4 Mar 2022 13:12:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id lXmtIFIQImLhbQAAMHmgww (envelope-from ); Fri, 04 Mar 2022 13:12:50 +0000 Content-Type: multipart/mixed; boundary="------------XSTogqcllg0i0WKMPY0wJr9Z" Message-ID: Date: Fri, 4 Mar 2022 14:12:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] opts: fix -gtoggle + optimize attribute Content-Language: en-US To: Richard Biener Cc: GCC Patches References: <65d104c2-eef6-fa92-7e6d-a42387c7526a@suse.cz> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Mar 2022 13:12:53 -0000 This is a multi-part message in MIME format. --------------XSTogqcllg0i0WKMPY0wJr9Z Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/1/22 09:48, Richard Biener wrote: > I think moving flag_gtoggle handling before the flag_syntax_only handling > is a good thing. But I don't quite understand the flag_var_tracking disabling > or how it worked before. Well, as you know, the debugging options are a can of worms. During GCC 12 development I moved most of the option logic to finish_options which is a place that is used both for command line option processing and optimize/target pragma/attribute processing. That's why we see this problem. OPT_LEVELS_1_PLUS enables flag_var_tracking but we have to drop debug debug_info_level == DINFO_LEVEL_NONE. > At least I think you want to check for > debug_info_level == NONE, no? Why should DINFO_LEVEL_TERSE be > special? No, sending updated version of the patch. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin --------------XSTogqcllg0i0WKMPY0wJr9Z Content-Type: text/x-patch; charset=UTF-8; name="0001-opts-fix-gtoggle-optimize-attribute.patch" Content-Disposition: attachment; filename="0001-opts-fix-gtoggle-optimize-attribute.patch" Content-Transfer-Encoding: base64 RnJvbSAxZDlmNzdmMDBmMjA4Y2NhNDE0MmFiYzljNTY5OTViODY1MjkxMjI5IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gTGlza2EgPG1saXNrYUBzdXNlLmN6PgpE YXRlOiBGcmksIDQgRmViIDIwMjIgMTU6NTA6MTcgKzAxMDAKU3ViamVjdDogW1BBVENIXSBv cHRzOiBmaXggLWd0b2dnbGUgKyBvcHRpbWl6ZSBhdHRyaWJ1dGUKCk5vdGUgLWZ2YXItdHJh Y2tpbmcgaXMgZW5hYmxlZCBhdXRvbWF0aWNhbGx5IHdpdGggT1BUX0xFVkVMU18xX1BMVVMg YW5kCnNvIHdlIG5lZWQgdG8gZHJvcCBpdCBpZiB3ZSBhcmUgY2FsbGVkIGZyb20gb3B0aW1p emUgYXR0cmlidXRlIGFuZCB0aGUKb3B0aW9uIGlzIHVuc2V0LgoKCVBSIG1pZGRsZS1lbmQv MTA0MzgxCgpnY2MvQ2hhbmdlTG9nOgoKCSogb3B0cy5jYyAoZmluaXNoX29wdGlvbnMpOiBJ ZiBkZWJ1ZyBpbmZvIGlzIGRpc2FibGVkCgkoZGVidWdfaW5mb19sZXZlbCkgYW5kIC1mdmFy LXRyYWNraW5nIGlzIHVuc2V0LCBkaXNhYmxlIGl0LgoKZ2NjL3Rlc3RzdWl0ZS9DaGFuZ2VM b2c6CgoJKiBnY2MuZGcvcHIxMDQzODEuYzogTmV3IHRlc3QuCi0tLQogZ2NjL29wdHMuY2Mg ICAgICAgICAgICAgICAgICAgICB8IDQ5ICsrKysrKysrKysrKysrKysrKystLS0tLS0tLS0t LS0tLQogZ2NjL3Rlc3RzdWl0ZS9nY2MuZGcvcHIxMDQzODEuYyB8IDIwICsrKysrKysrKysr KysrCiAyIGZpbGVzIGNoYW5nZWQsIDQ4IGluc2VydGlvbnMoKyksIDIxIGRlbGV0aW9ucygt KQogY3JlYXRlIG1vZGUgMTAwNjQ0IGdjYy90ZXN0c3VpdGUvZ2NjLmRnL3ByMTA0MzgxLmMK CmRpZmYgLS1naXQgYS9nY2Mvb3B0cy5jYyBiL2djYy9vcHRzLmNjCmluZGV4IDE5YzY4YWVk MDY1Li5lZjVmZTliMTFjYSAxMDA2NDQKLS0tIGEvZ2NjL29wdHMuY2MKKysrIGIvZ2NjL29w dHMuY2MKQEAgLTEzMDIsNiArMTMwMiwzNCBAQCBmaW5pc2hfb3B0aW9ucyAoc3RydWN0IGdj Y19vcHRpb25zICpvcHRzLCBzdHJ1Y3QgZ2NjX29wdGlvbnMgKm9wdHNfc2V0LAogICAgIFNF VF9PUFRJT05fSUZfVU5TRVQgKG9wdHMsIG9wdHNfc2V0LCBmbGFnX3ZlY3RfY29zdF9tb2Rl bCwKIAkJCSBWRUNUX0NPU1RfTU9ERUxfQ0hFQVApOwogCisgIGlmIChmbGFnX2d0b2dnbGUp CisgICAgeworICAgICAgLyogTWFrZSBzdXJlIHRvIHByb2Nlc3MgLWd0b2dnbGUgb25seSBv bmNlLiAgKi8KKyAgICAgIGZsYWdfZ3RvZ2dsZSA9IGZhbHNlOworICAgICAgaWYgKGRlYnVn X2luZm9fbGV2ZWwgPT0gRElORk9fTEVWRUxfTk9ORSkKKwl7CisJICBkZWJ1Z19pbmZvX2xl dmVsID0gRElORk9fTEVWRUxfTk9STUFMOworCisJICBpZiAod3JpdGVfc3ltYm9scyA9PSBO T19ERUJVRykKKwkgICAgd3JpdGVfc3ltYm9scyA9IFBSRUZFUlJFRF9ERUJVR0dJTkdfVFlQ RTsKKwl9CisgICAgICBlbHNlCisJZGVidWdfaW5mb19sZXZlbCA9IERJTkZPX0xFVkVMX05P TkU7CisgICAgfQorCisgIGlmICghT1BUSU9OX1NFVF9QIChkZWJ1Z19ub25iaW5kX21hcmtl cnNfcCkpCisgICAgZGVidWdfbm9uYmluZF9tYXJrZXJzX3AKKyAgICAgID0gKG9wdGltaXpl CisJICYmIGRlYnVnX2luZm9fbGV2ZWwgPj0gRElORk9fTEVWRUxfTk9STUFMCisJICYmIGR3 YXJmX2RlYnVnaW5mb19wICgpCisJICYmICEoZmxhZ19zZWxlY3RpdmVfc2NoZWR1bGluZyB8 fCBmbGFnX3NlbGVjdGl2ZV9zY2hlZHVsaW5nMikpOworCisgIC8qIE5vdGUgLWZ2YXItdHJh Y2tpbmcgaXMgZW5hYmxlZCBhdXRvbWF0aWNhbGx5IHdpdGggT1BUX0xFVkVMU18xX1BMVVMg YW5kCisgICAgIHNvIHdlIG5lZWQgdG8gZHJvcCBpdCBpZiB3ZSBhcmUgY2FsbGVkIGZyb20g b3B0aW1pemUgYXR0cmlidXRlLiAgKi8KKyAgaWYgKGRlYnVnX2luZm9fbGV2ZWwgPT0gRElO Rk9fTEVWRUxfTk9ORQorICAgICAgJiYgIU9QVElPTl9TRVRfUCAoZmxhZ192YXJfdHJhY2tp bmcpKQorICAgIGZsYWdfdmFyX3RyYWNraW5nID0gZmFsc2U7CisKICAgLyogT25lIGNvdWxk IHVzZSBFbmFibGVkQnksIGJ1dCBpdCB3b3VsZCBsZWFkIHRvIGEgY2lyY3VsYXIgZGVwZW5k ZW5jeS4gICovCiAgIGlmICghT1BUSU9OX1NFVF9QIChmbGFnX3Zhcl90cmFja2luZ191bmlu aXQpKQogICAgICBmbGFnX3Zhcl90cmFja2luZ191bmluaXQgPSBmbGFnX3Zhcl90cmFja2lu ZzsKQEAgLTEzMjgsMjcgKzEzNTYsNiBAQCBmaW5pc2hfb3B0aW9ucyAoc3RydWN0IGdjY19v cHRpb25zICpvcHRzLCBzdHJ1Y3QgZ2NjX29wdGlvbnMgKm9wdHNfc2V0LAogICAgICAgcHJv ZmlsZV9mbGFnID0gMDsKICAgICB9CiAKLSAgaWYgKGZsYWdfZ3RvZ2dsZSkKLSAgICB7Ci0g ICAgICAvKiBNYWtlIHN1cmUgdG8gcHJvY2VzcyAtZ3RvZ2dsZSBvbmx5IG9uY2UuICAqLwot ICAgICAgZmxhZ19ndG9nZ2xlID0gZmFsc2U7Ci0gICAgICBpZiAoZGVidWdfaW5mb19sZXZl bCA9PSBESU5GT19MRVZFTF9OT05FKQotCXsKLQkgIGRlYnVnX2luZm9fbGV2ZWwgPSBESU5G T19MRVZFTF9OT1JNQUw7Ci0KLQkgIGlmICh3cml0ZV9zeW1ib2xzID09IE5PX0RFQlVHKQot CSAgICB3cml0ZV9zeW1ib2xzID0gUFJFRkVSUkVEX0RFQlVHR0lOR19UWVBFOwotCX0KLSAg ICAgIGVsc2UKLQlkZWJ1Z19pbmZvX2xldmVsID0gRElORk9fTEVWRUxfTk9ORTsKLSAgICB9 Ci0KLSAgaWYgKCFPUFRJT05fU0VUX1AgKGRlYnVnX25vbmJpbmRfbWFya2Vyc19wKSkKLSAg ICBkZWJ1Z19ub25iaW5kX21hcmtlcnNfcAotICAgICAgPSAob3B0aW1pemUKLQkgJiYgZGVi dWdfaW5mb19sZXZlbCA+PSBESU5GT19MRVZFTF9OT1JNQUwKLQkgJiYgZHdhcmZfZGVidWdp bmZvX3AgKCkKLQkgJiYgIShmbGFnX3NlbGVjdGl2ZV9zY2hlZHVsaW5nIHx8IGZsYWdfc2Vs ZWN0aXZlX3NjaGVkdWxpbmcyKSk7CiAKICAgZGlhZ25vc2Vfb3B0aW9ucyAob3B0cywgb3B0 c19zZXQsIGxvYyk7CiB9CmRpZmYgLS1naXQgYS9nY2MvdGVzdHN1aXRlL2djYy5kZy9wcjEw NDM4MS5jIGIvZ2NjL3Rlc3RzdWl0ZS9nY2MuZGcvcHIxMDQzODEuYwpuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMC4uYTNhZWM5MTliZWUKLS0tIC9kZXYvbnVsbAor KysgYi9nY2MvdGVzdHN1aXRlL2djYy5kZy9wcjEwNDM4MS5jCkBAIC0wLDAgKzEsMjAgQEAK Ky8qIHsgZGctZG8gY29tcGlsZSB9ICovCisvKiB7IGRnLW9wdGlvbnMgIi1PMiAtZyAtZ3Rv Z2dsZSAtZmR1bXAtdHJlZS1vcHRpbWl6ZWQiIH0gKi8KKworaW50IGZvbyAoaW50IHgpCit7 CisgIGludCB0ZW0gPSB4ICsgMTsKKyAgaW50IHRlbTIgPSB0ZW0gLSAxOworICByZXR1cm4g dGVtMjsKK30KKworaW50CitfX2F0dHJpYnV0ZV9fKChvcHRpbWl6ZSgibm8tdHJlZS1wcmUi KSkpCitiYXIgKGludCB4KQoreworICBpbnQgdGVtID0geCArIDE7CisgIGludCB0ZW0yID0g dGVtIC0gMTsKKyAgcmV0dXJuIHRlbTI7Cit9CisKKy8vIHsgZGctZmluYWwgeyBzY2FuLXRy ZWUtZHVtcC1ub3QgIkRFQlVHICIgIm9wdGltaXplZCIgfSB9Ci0tIAoyLjM1LjEKCg== --------------XSTogqcllg0i0WKMPY0wJr9Z--