From: Martin Sebor <msebor@gmail.com>
To: Volker Reichelt <v.reichelt@netcologne.de>,
Jason Merrill <jason@redhat.com>
Cc: David Malcolm <dmalcolm@redhat.com>,
gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: [PING] C++ Re: [PATCH] C/C++: fix quoting of "aka" typedef information (PR 62170)
Date: Fri, 14 Jul 2017 16:24:00 -0000 [thread overview]
Message-ID: <e3fe9932-a3f6-99ac-2f1d-0e065d53870e@gmail.com> (raw)
In-Reply-To: <tkrat.cc84a13a7a86f7f9@netcologne.de>
On 06/21/2017 01:59 AM, Volker Reichelt wrote:
> On 20 Jun, Jason Merrill wrote:
>> On Tue, Jun 20, 2017 at 3:06 PM, David Malcolm <dmalcolm@redhat.com> wrote:
>>> It's not clear to me what the issue alluded to with negative
>>> obstack_blank is, but I chose to follow the above docs and use
>>> obstack_blank_fast; am testing an updated patch in which the above line
>>> now looks like:
>>>
>>> obstack_blank_fast (ob, -(type_start + type_len));
>>>
>>> Is the patch OK with that change? (assuming bootstrap®rtesting
>>> pass), or should I re-post?
>>
>> OK with that change.
>>
>>> On a related matter, this patch conflicts with Volker's patch here:
>>>
>>> https://gcc.gnu.org/ml/gcc-patches/2017-04/msg01576.html
>>>
>>> in which he removes the trailing "{enum}" info (and hence all of our
>>> changes to the testsuite conflict between the two patches...)
>>>
>>> Do you have any thoughts on that other patch? [Ccing Volker]
>>
>> That patch makes sense to me; I prefer "enum E" to "E {enum}".
>>
>> Jason
>
> Is 'makes sense' equivalent to 'OK for trunk' here? If so, should my
> patch go in before David's or should we do it the other way round?
I missed this and have been pinging your patch on your behalf
(below). In the interest on making progress on this, IMO trivial,
change I recommend taking Jason's comment as approval.
https://gcc.gnu.org/ml/gcc-patches/2017-07/msg00472.html
Martin
next prev parent reply other threads:[~2017-07-14 16:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 18:29 David Malcolm
2017-06-06 10:57 ` Marek Polacek
2017-06-20 15:51 ` [PING] C++ " David Malcolm
2017-06-20 17:59 ` Jason Merrill
2017-06-20 18:01 ` Jason Merrill
2017-06-20 19:06 ` David Malcolm
2017-06-20 19:12 ` Jason Merrill
2017-06-21 7:59 ` Volker Reichelt
2017-07-14 16:24 ` Martin Sebor [this message]
2017-07-16 10:02 ` Volker Reichelt
2017-06-21 13:59 ` [PATCH] v3: " David Malcolm
2017-07-14 15:47 ` [PING] " David Malcolm
2017-11-22 20:57 ` [committed] v5: " David Malcolm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3fe9932-a3f6-99ac-2f1d-0e065d53870e@gmail.com \
--to=msebor@gmail.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=v.reichelt@netcologne.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).