From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61184 invoked by alias); 28 Jun 2017 14:30:52 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 60935 invoked by uid 89); 28 Jun 2017 14:30:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=53PM, 53pm X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Jun 2017 14:30:41 +0000 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v5SEScKs038328 for ; Wed, 28 Jun 2017 10:30:25 -0400 Received: from e19.ny.us.ibm.com (e19.ny.us.ibm.com [129.33.205.209]) by mx0b-001b2d01.pphosted.com with ESMTP id 2bce4vgdp6-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 28 Jun 2017 10:30:25 -0400 Received: from localhost by e19.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 28 Jun 2017 10:30:24 -0400 Received: from b01cxnp22036.gho.pok.ibm.com (9.57.198.26) by e19.ny.us.ibm.com (146.89.104.206) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 28 Jun 2017 10:30:23 -0400 Received: from b01ledav001.gho.pok.ibm.com (b01ledav001.gho.pok.ibm.com [9.57.199.106]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v5SEUMMR58785838; Wed, 28 Jun 2017 14:30:22 GMT Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 55B5D2803D; Wed, 28 Jun 2017 10:30:16 -0400 (EDT) Received: from oc6462846008.ibm.com (unknown [9.85.166.242]) by b01ledav001.gho.pok.ibm.com (Postfix) with ESMTP id 1884C2803A; Wed, 28 Jun 2017 10:30:16 -0400 (EDT) Subject: Re: Backport [PATCH,rs6000] Handle conflicting target options -mno-power9-vector and -mcpu=power9 To: Segher Boessenkool Cc: gcc-patches@gcc.gnu.org References: <9b8253e6-794f-0c52-1ed1-f60b9a27be80@linux.vnet.ibm.com> <20170322233535.GM4402@gate.crashing.org> <637d9e0f-a8b0-88d0-91d9-e8aba5e2d7f3@linux.vnet.ibm.com> <20170323041720.GN4402@gate.crashing.org> From: Kelvin Nilsen Date: Wed, 28 Jun 2017 14:30:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <20170323041720.GN4402@gate.crashing.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17062814-0056-0000-0000-00000396F655 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007290; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000214; SDB=6.00879938; UDB=6.00438611; IPR=6.00660092; BA=6.00005445; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015991; XFM=3.00000015; UTC=2017-06-28 14:30:23 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17062814-0057-0000-0000-000007CD14EE Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-28_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706280236 X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg02170.txt.bz2 I have bootstrapped and tested this patch on powerpc64le-unkonwn-linux-gnu with no regressions. Is this ok for backporting to gcc 6? On 03/22/2017 10:17 PM, Segher Boessenkool wrote: > On Wed, Mar 22, 2017 at 05:55:53PM -0600, Kelvin Nilsen wrote: >>> Or it could do -mpower9-dform-scalar but disable -mpower9-dform-vector? >>> That seems more reasonable. >> >> The internal problem report sent to me said "-mno-power9-vector should >> override power9-dform unless the latter has been deliberately specified >> by the user." I'm just following orders. > > Heh :-) > >> If you think it preferable to >> only override -mpower-dform-vector, I'll make that modification. > > It is more logical. Or so I though. But as it turns out, > -mpower9-dform-scalar is about vector registers as well. > > So the patch is approved for trunk as-is. Thanks! > >>>> * config/rs6000/rs6000.c (rs6000_option_override_internal): Change >>>> handling of certain combinations of target options, including the >>>> combinations -mpower8-vector vs. -mno-vsx, -mpower8-vector vs. >>>> -mno-power8-vector, and -mpower9_dform vs. -mno-power9-vector. >>> >>> Those other changes are independent? >> >> Actually, these other changes are not independent. My initial attempt >> at a patch only changed the behavior of -mpower9_dform vs. >> -mno-power9-vector. But this actually resulted in a regression of an >> existing test. To "properly" handle the new case without impacting >> existing "established" behavior (as represented in the existing dejagnu >> testsuite), I had to make these other changes as well. > > Too many options :-( > > > Segher > > -- Kelvin Nilsen, Ph.D. kdnilsen@linux.vnet.ibm.com home office: 801-756-4821, cell: 520-991-6727 IBM Linux Technology Center - PPC Toolchain