From: "Martin Liška" <mliska@suse.cz>
To: gcc-patches@gcc.gnu.org
Cc: Martin Jambor <mjambor@suse.cz>
Subject: Re: [PATCH] IPA: do not release body if still needed
Date: Fri, 9 Dec 2022 09:28:08 +0100 [thread overview]
Message-ID: <e415e2de-c2bf-b42b-32ca-a7dd10793560@suse.cz> (raw)
In-Reply-To: <a4208860-1af9-6c47-6109-5c2fe4c9d444@suse.cz>
PING^1
On 12/1/22 10:59, Martin Liška wrote:
> Hi.
>
> Noticed during building of libbackend.a with the LTO partial linking.
>
> The function release_body is called even if clone_of is a clone
> of a another function and thus it shares tree declaration. We should
> preserve it in that situation.
>
> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
>
> Ready to be installed?
> Thanks,
> Martin
>
> PR ipa/107944
>
> gcc/ChangeLog:
>
> * cgraph.cc (cgraph_node::remove): Do not release body
> if a node is clone of another node.
> ---
> gcc/cgraph.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/cgraph.cc b/gcc/cgraph.cc
> index f15cb47c8b8..2e7d77ffd6c 100644
> --- a/gcc/cgraph.cc
> +++ b/gcc/cgraph.cc
> @@ -1893,7 +1893,7 @@ cgraph_node::remove (void)
> else if (clone_of)
> {
> clone_of->clones = next_sibling_clone;
> - if (!clone_of->analyzed && !clone_of->clones && !clones)
> + if (!clone_of->analyzed && !clone_of->clones && !clones && !clone_of->clone_of)
> clone_of->release_body ();
> }
> if (next_sibling_clone)
next prev parent reply other threads:[~2022-12-09 8:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 9:59 Martin Liška
2022-12-09 8:28 ` Martin Liška [this message]
2022-12-28 9:20 ` Martin Liška
2023-01-13 16:49 ` Martin Jambor
2023-01-14 21:36 ` Jan Hubicka
2023-01-16 12:31 ` Martin Liška
2023-01-18 14:35 ` Martin Jambor
2023-01-18 15:33 ` Jan Hubicka
2023-01-19 17:41 ` Martin Jambor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e415e2de-c2bf-b42b-32ca-a7dd10793560@suse.cz \
--to=mliska@suse.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=mjambor@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).