From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id C470E3858D20 for ; Fri, 1 Dec 2023 14:10:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C470E3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C470E3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701439851; cv=none; b=t0H41f2qzY3LhFRvk8K29pVW2jLsaC3Z26eBKNA7Hgg/sPB+9E/+aFu68XFvzeLo5pAMiuuVZG3k4lHVwNoRCdctEWE6yFdgZ5yfgB52neDTmlqTJjUt5A6kJO0AYj57X5huB74Gq/MiThBSOO1sCel5r3Tck9S5gnAtSIe7h/g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701439851; c=relaxed/simple; bh=pFEjTqvFeSLnMeQU5W7RkD9XjM4iCv/Yf30FQ7n2ARg=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=C2xfadobTfnjTmuVMtc30Rm0zP5tKbYsW6tkI3fMiFQKmis5jEojipWjBf1ga1t8xTBc9QmWe+8ztJjYo+K/4h5xFeVVEUMDz8XfH0KlWr076NIsfg6ifnAR+D67KlXpWVwehlqYZlM4I+cAFPpBJ3yUt09YjivSjdzIswZpZ7U= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C56A61007; Fri, 1 Dec 2023 06:11:33 -0800 (PST) Received: from [10.2.78.54] (e120077-lin.cambridge.arm.com [10.2.78.54]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AD0613F73F; Fri, 1 Dec 2023 06:10:46 -0800 (PST) Message-ID: Date: Fri, 1 Dec 2023 14:10:45 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] testsuite, arm: Fix up pr112337.c test Content-Language: en-GB To: Christophe Lyon Cc: Saurabh Jha , "gcc-patches@gcc.gnu.org" , Kyrylo Tkachov References: <85bf6edd-748e-492f-a511-3bdb53edf49a@arm.com> <2d9bccc7-8693-9f5f-3d05-cb90a6856f41@arm.com> From: "Richard Earnshaw (lists)" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3492.7 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_SHORT,NICE_REPLY_A,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 01/12/2023 13:45, Christophe Lyon wrote: > On Fri, 1 Dec 2023 at 13:44, Richard Earnshaw (lists) > wrote: >> >> On 01/12/2023 11:28, Saurabh Jha wrote: >>> Hey, >>> >>> I introduced this test "gcc/testsuite/gcc.target/arm/mve/pr112337.c" in this commit 2365aae84de030bbb006edac18c9314812fc657b before. This had an error which I unfortunately missed. This patch fixes that test. >>> >>> Did regression testing on arm-none-eabi and found no regressions. Output of running gcc/contrib/compare_tests is this: >>> >>> """ >>> Tests that now work, but didn't before (2 tests): >>> >>> arm-eabi-aem/-marm/-march=armv7-a/-mfpu=vfpv3-d16/-mfloat-abi=softfp: gcc.target/arm/mve/pr112337.c (test for excess errors) >>> arm-eabi-aem/-mthumb/-march=armv8-a/-mfpu=crypto-neon-fp-armv8/-mfloat-abi=hard: gcc.target/arm/mve/pr112337.c (test for excess errors) >>> """ >>> >>> Ok for trunk? I don't have commit access so could someone please commit on my behalf? >>> >>> Regards, >>> Saurabh >>> >>> gcc/testsuite/ChangeLog: >>> >>> * gcc.target/arm/mve/pr112337.c: Fix the testcase >> >> >> Hmm, could this be related to the changes Christophe made recently to change the way MVE vector types were set up internally? If so, this might indicate an issue that's going to affect real users with existing code. >> > > My change was only about vector types, here the problem is with a > pointer to a scalar. > Anyway, I ran the test with my commit reverted and it still fails in > the same way, so I think this patch is needed. > > Thanks, > > Christophe > >> Christophe? >> >> R. Ok, thanks for checking. In that case, Saurabh, your patch is OK, but please change 'Fix testcase' to 'Use int32_t instead of int.' Note that ChangeLog entries end with a full stop. R.