From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 9F2B43856DDE for ; Tue, 30 May 2023 09:51:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9F2B43856DDE Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0353724.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34U9Eg3c010524; Tue, 30 May 2023 09:51:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=6ff+YaTb/DCUGoPrr1LfzWITlUmCAzDxfcO8bRLdUsg=; b=GH3WZqJk9PLA9MThwPIERX6J4Je8Ntkk1vbGdxEQlUSRKmgcK7UkKHDODCu0OFRKjv/d QTVdfDJW9erPlBsxZojE7JIZ7lJk9IveqyW5vmObXNoUUT3Ehtyj99ksE6NJxClcGofi 7oZirAftkvpAnRtPnHhlSdJUD1UOI5HNo0J8OD/ktsl9XA8ecRZO/T58idmBE9wBoZae 0ed6e05oF1mPfGLY0AkPl0VE7XggwsPF1fJ6vlUIPkYGQuF+KqTQ60bWRz4GX4E+ueFI bFIEqzAiWIU+pBUmmOnsvsyF9/r7NiUwPU0IeHQX11XUHSJjESRV32QStMBkKhUFdWSC og== Received: from ppma04fra.de.ibm.com (6a.4a.5195.ip4.static.sl-reverse.com [149.81.74.106]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3qweb90xfs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 30 May 2023 09:51:53 +0000 Received: from pps.filterd (ppma04fra.de.ibm.com [127.0.0.1]) by ppma04fra.de.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 34U4lMVw017771; Tue, 30 May 2023 09:51:51 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma04fra.de.ibm.com (PPS) with ESMTPS id 3qu9g516a7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 30 May 2023 09:51:51 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 34U9pm7b43712882 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 30 May 2023 09:51:48 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BBAB520049; Tue, 30 May 2023 09:51:48 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E15B520043; Tue, 30 May 2023 09:51:46 +0000 (GMT) Received: from [9.177.4.2] (unknown [9.177.4.2]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 30 May 2023 09:51:46 +0000 (GMT) Message-ID: Date: Tue, 30 May 2023 17:51:45 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: decremnt IV patch create fails on PowerPC Content-Language: en-US To: "juzhe.zhong@rivai.ai" , rguenther Cc: gcc-patches , "richard.sandiford" References: <3C61C9A7B8836ACA+20230530172617084361351@rivai.ai> From: "Kewen.Lin" In-Reply-To: <3C61C9A7B8836ACA+20230530172617084361351@rivai.ai> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: T028Ro8DBJprPmHGwrX-pmwdjtyDGoHz X-Proofpoint-ORIG-GUID: T028Ro8DBJprPmHGwrX-pmwdjtyDGoHz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-05-30_06,2023-05-29_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 phishscore=0 mlxlogscore=761 spamscore=0 clxscore=1015 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2305300079 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: on 2023/5/30 17:26, juzhe.zhong@rivai.ai wrote: > Ok. > > It seems that for this conditions: > > + /* If we're vectorizing a loop that uses length "controls" and > + can iterate more than once, we apply decrementing IV approach > + in loop control. */ > + if (LOOP_VINFO_CAN_USE_PARTIAL_VECTORS_P (loop_vinfo) > + && !LOOP_VINFO_LENS (loop_vinfo).is_empty () > + && LOOP_VINFO_PARTIAL_LOAD_STORE_BIAS (loop_vinfo) == 0 > + && !(LOOP_VINFO_NITERS_KNOWN_P (loop_vinfo) > + && known_le (LOOP_VINFO_INT_NITERS (loop_vinfo), > + LOOP_VINFO_VECT_FACTOR (loop_vinfo)))) > + LOOP_VINFO_USING_DECREMENTING_IV_P (loop_vinfo) = true; > > > I should add direct_supportted_p (SELECT_VL...) to this is that right? I guess no, with this condition any targets without SELECT_VL are unable to leverage the new decrement scheme for lengths, as your reply in PR109971 you didn't meant to disable it. IIUC, what Richi suggested is to introduce one new IV just like the previous one which has non-variable step, then it's SCEV-ed and some analysis based on it can do a good job. Since this is mainly for targets without SELECT_VL capability, I can follow up this if you don't mind. BR, Kewen