From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jeffreyalaw@gmail.com>
Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635])
	by sourceware.org (Postfix) with ESMTPS id 237F03858038
	for <gcc-patches@gcc.gnu.org>; Tue,  4 Oct 2022 18:45:11 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 237F03858038
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-pl1-x635.google.com with SMTP id x1so13421132plv.5
        for <gcc-patches@gcc.gnu.org>; Tue, 04 Oct 2022 11:45:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :from:to:cc:subject:date;
        bh=n3qvKx5nknxchOoMojIEfOFqWeupwwQ1eEfQWnC61VI=;
        b=oUqc6mTUnMT/it4Zeoa02dTOmI6wgoaQkDAVGd/R47UwbFmXqD1dlWEqjf0ECGNmM5
         gpDyUHgl1U+0NyHBbm2WYsr3oC/EYYy0yXALjMy8ZsZ5gZnQFG07Bd9y5N1l7xgfMlFt
         I7YCX6z2PiHYeIA9dLiTGTj8hVCpsjdF8LwygUkkOa/Dj4ZGr5ad5R9/iVGcRBY4Yg7w
         DGITCyher1j0SdbIj7YFbhlSYO5D83Ty5gjYj1dSPyHlqBwKWsjUPzxtnIOtSH09WKhL
         cAXX6kjmhGUXfa0HBPWp/eDBlJaGpxO0hQ2k5/Hj6jRa3prD7X7ndMGdNxHNz23C1Qfi
         vB5Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:in-reply-to:from:references:cc:to
         :content-language:subject:user-agent:mime-version:date:message-id
         :x-gm-message-state:from:to:cc:subject:date;
        bh=n3qvKx5nknxchOoMojIEfOFqWeupwwQ1eEfQWnC61VI=;
        b=iMw9Jt8HaAjGdr9hV9ZQdMM0mRJFdRhcLKyuJL72XThChCsUpL3NWi7TlIG0QYq6Uf
         Xnq0uoulRRtUyuOWOzrRfLgICP1LTI17BzLKmaPTgBsKJlW3D1vIuiho/uYVQDKAuuMi
         30vcdaJ7ZUp6o1nNWfdFk8rEPjUgdWaoOdyfkI7LPsLXJEjRIDFIhs7Om9Bw8j/K7KVr
         oAPfPyLivtCgyILbRg1zLPi0xwMuKj/DHejU8ehKepGZnyf/RM8/wvTQ/GcbPr9kkjQN
         9L4aPrSEzRTxqhBga9I4dDQHW3CAo6AZay/zY4TrnCswTfE0s2j/kGQyF/VIF1Ab2b6c
         V06g==
X-Gm-Message-State: ACrzQf2dbfz5vWIAFNEI/511zhst+qrxLjmfTOq5Ak+kVQ2ioL65RS17
	5WhFxRiX8FBDDQC8YgUR5Fs=
X-Google-Smtp-Source: AMsMyM5u7UmQJSC/ch81/jh3nEYdkPqxnSMvNJpvGd/MU24mEykN0hwqyjG/JM3gxf0B8DEp/+sqJA==
X-Received: by 2002:a17:902:da83:b0:17a:111:ebdf with SMTP id j3-20020a170902da8300b0017a0111ebdfmr27841043plx.149.1664909109984;
        Tue, 04 Oct 2022 11:45:09 -0700 (PDT)
Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a])
        by smtp.gmail.com with ESMTPSA id a18-20020a630b52000000b004393f60db36sm8817786pgl.32.2022.10.04.11.45.08
        (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
        Tue, 04 Oct 2022 11:45:08 -0700 (PDT)
Message-ID: <e48f7c7e-eca7-a8ae-2d37-2532bdb1be57@gmail.com>
Date: Tue, 4 Oct 2022 12:45:07 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [COMMITTED] Remove assert from set_nonzero_bits.
Content-Language: en-US
To: Aldy Hernandez <aldyh@redhat.com>, GCC patches <gcc-patches@gcc.gnu.org>
Cc: Andrew MacLeod <amacleod@redhat.com>
References: <20221004175221.1493497-1-aldyh@redhat.com>
From: Jeff Law <jeffreyalaw@gmail.com>
In-Reply-To: <20221004175221.1493497-1-aldyh@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>


On 10/4/22 11:52, Aldy Hernandez wrote:
> The assert removed by this patch was there to keep users from passing
> masks of incompatible types.  The self tests are passing host wide
> ints down (set_nonzero_bits (-1)), which seem to be 32 bits, whereas
> some embedded targets have integer_type_node's of 16-bits.  This is
> causing problems in m32c-elf, among others.
>
> I suppose there's no harm in passing a 32-bit mask, because
> set_nonzero_bits calls wide_int::from() to convert the mask to the
> appropriate type.  So we can remove the assert.
>
> Sorry for the pain Jeff.
>
> gcc/ChangeLog:
>
> 	* value-range.cc (irange::set_nonzero_bits): Remove assert.

Thanks.  I'll respin everything that failed this AM and see where we are.


jeff