From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Nick Desaulniers <ndesaulniers@google.com>,
Segher Boessenkool <segher@kernel.crashing.org>
Cc: Jakub Jelinek <jakub@redhat.com>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
clang-built-linux <clang-built-linux@googlegroups.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>
Subject: Re: [PATCH v2 4/6] compiler-gcc.h: add asm_inline definition
Date: Thu, 12 Sep 2019 22:12:00 -0000 [thread overview]
Message-ID: <e4bf09bf-3aa7-aa7b-529b-f930dc75be4a@rasmusvillemoes.dk> (raw)
In-Reply-To: <CAKwvOdmhcaHpnqhMwzpYdjjwfAhgzq7fqA0Hu8b19E5w3AHz4w@mail.gmail.com>
On 12/09/2019 23.54, Nick Desaulniers wrote:
> On Sat, Sep 7, 2019 at 6:11 AM Segher Boessenkool
> <segher@kernel.crashing.org> wrote:
>>
>> On Fri, Sep 06, 2019 at 06:04:54PM -0700, Nick Desaulniers wrote:
>>
>>> How would you even write a version check for that?
>>
>> I wouldn't. Please stop using that straw man. I'm not saying version
>> checks are good, or useful for most things. I am saying they are not.
>
> Then please help Rasmus with a suggestion on how best to detect and
> safely make use of the feature you implemented. As is, the patch in
> question is using version checks.
I was just about to send out an updated version. I'm just going to do
the check in Kconfig - I didn't realize how easy it had become to do
that kind of thing until Masahiro pointed me at his RFC patch from December.
Rasmus
next prev parent reply other threads:[~2019-09-12 22:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190829083233.24162-1-linux@rasmusvillemoes.dk>
[not found] ` <20190830231527.22304-1-linux@rasmusvillemoes.dk>
[not found] ` <20190830231527.22304-5-linux@rasmusvillemoes.dk>
[not found] ` <CAKwvOdktYpMH8WnEQwNE2JJdKn4w0CHv3L=YHkqU2JzQ6Qwkew@mail.gmail.com>
2019-09-05 11:07 ` Rasmus Villemoes
2019-09-05 13:45 ` Segher Boessenkool
2019-09-05 14:23 ` Rasmus Villemoes
2019-09-05 14:47 ` Segher Boessenkool
2019-09-05 15:53 ` Miguel Ojeda
2019-09-05 16:13 ` Miguel Ojeda
2019-09-06 12:23 ` Segher Boessenkool
2019-09-06 15:14 ` Miguel Ojeda
2019-09-06 16:30 ` Segher Boessenkool
2019-09-06 16:39 ` Jakub Jelinek
2019-09-06 18:14 ` Nick Desaulniers via gcc-patches
2019-09-06 22:03 ` Segher Boessenkool
2019-09-06 22:35 ` Nick Desaulniers via gcc-patches
2019-09-06 22:56 ` Segher Boessenkool
2019-09-06 23:43 ` Nick Desaulniers via gcc-patches
2019-09-07 0:14 ` Segher Boessenkool
2019-09-07 1:05 ` Nick Desaulniers via gcc-patches
2019-09-07 13:11 ` Segher Boessenkool
2019-09-08 13:55 ` Miguel Ojeda
2019-09-12 21:55 ` Nick Desaulniers via gcc-patches
2019-09-12 22:12 ` Rasmus Villemoes [this message]
2019-09-20 0:50 ` Segher Boessenkool
2019-09-06 16:48 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4bf09bf-3aa7-aa7b-529b-f930dc75be4a@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=clang-built-linux@googlegroups.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ndesaulniers@google.com \
--cc=segher@kernel.crashing.org \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).