public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Sandra Loosemore <sandra.loosemore@siemens.com>
To: Jakub Jelinek <jakub@redhat.com>,
	Gerald Pfeifer <gerald@pfeifer.com>,
	Joseph Myers <joseph@codesourcery.com>,
	Sandra Loosemore <sandra@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] extend.texi: Fix up defbuiltin* with spaces in return type
Date: Fri, 1 Dec 2023 10:04:38 -0700	[thread overview]
Message-ID: <e4d7ec64-e7d9-a02e-ba61-41777b88bc16@siemens.com> (raw)
In-Reply-To: <ZWm00S+EZNfpqn2l@tucnak>

On 12/1/23 03:26, Jakub Jelinek wrote:
> Hi!
> 
> In https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html#index-_005f_005fbuiltin_005fstdc_005fbit_005ffloor>> I've noticed that while e.g. __builtin_stdc_bit_floor builtin is properly
> rendered in bold and bigger size, for the __builtin_stdc_bit_width builtin
> it is not the builtin name which is marked like that, but the keyword int
> before it.  Also, seems such builtins are missing from the index.
> 
> I've read the texinfo docs and they seem to suggest in
> https://www.gnu.org/software/texinfo/manual/texinfo/html_node/Line-Macros.html>> that return types of functions with spaces in the return type should be
> wrapped with {}s and we already use that e.g. in
> @defbuiltin{{void *} __builtin_thread_pointer (void)}
> 
> The following patch adjusts builtins I found which contained one or two
> spaces in the return type name (plus two spots which used 2 spaces after
> single keyword return type instead of 1 which triggered my search regex as
> well).
> 
> Tested on x86_64-linux, ok for trunk?

Thanks, this looks good to me.  I think I also noticed this weird formatting in 
passing recently when I was looking for something else and did not have time to 
track it down myself.

-Sandra



  parent reply	other threads:[~2023-12-01 17:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-01 10:26 Jakub Jelinek
2023-12-01 15:07 ` Jeff Law
2023-12-01 17:04 ` Sandra Loosemore [this message]
2023-12-01 17:33   ` Jakub Jelinek
2023-12-01 17:43     ` Sandra Loosemore
2023-12-04  7:36       ` [PATCH] extend.texi: Mark builtin arguments with @var{...} Jakub Jelinek
2023-12-11  1:48         ` Sandra Loosemore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e4d7ec64-e7d9-a02e-ba61-41777b88bc16@siemens.com \
    --to=sandra.loosemore@siemens.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gerald@pfeifer.com \
    --cc=jakub@redhat.com \
    --cc=joseph@codesourcery.com \
    --cc=sandra@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).