From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 23CDE385781F for ; Fri, 17 Feb 2023 17:11:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 23CDE385781F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676653876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LcaRPibej3NaSDcTN6oWih6VLiGjOS/B6gFnUxYR+8s=; b=Xnx2ZTiJjTHDIq4EnruDQm/E6nogwQc+pZ3TZAHq2mkvExEDv3yKLLUq8l0imnazGJyrda kSZlo3APvSOKlAoJEKZ9lunximgIZ98Hh3dGfqTlE0qMovB4AqR6+Y3ixTCkIdEPBD/kQ7 68TsyMWZHVRlNZw5LG+6/wyWRroXwjg= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-80-1loGeJuDN1y7bDs3KYnI-w-1; Fri, 17 Feb 2023 12:11:08 -0500 X-MC-Unique: 1loGeJuDN1y7bDs3KYnI-w-1 Received: by mail-qv1-f71.google.com with SMTP id mm12-20020a0562145e8c00b004c72d0e92bcso920676qvb.12 for ; Fri, 17 Feb 2023 09:11:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LcaRPibej3NaSDcTN6oWih6VLiGjOS/B6gFnUxYR+8s=; b=hIsGxCd2IGTGkQ6mdGsrxREItI0QxEd4SaBZaTcpqCSvEE3wKldnpoPeFsIoU3muMK TBYv0UBF7czUWyt+N6JiQ78IrH7SbpfOpN1TSwSkAnbGkQg2dxKiX0idefueGeQTL3WJ TbeFOELeX5OVwV/+L1Z57HoXWzOy8btSb0oFxpzLA53BQ/Rt0vbCHYBo2rLJl5oYXxwo 15g25+g58bi4xcvmlFiCXFK2b6XiWZFyHaLlvV/BbLIV3zrgXQ+Un5RumyfeOLdnpXcW 1241vjBxGMb9S+9+X8AAF8uoyxdm0Qk/lCyCqubAjTlCL1aaRvHqHg0ttptaJMk187GP 65Ig== X-Gm-Message-State: AO0yUKU4D+KmPP6JSLtily3o14orewQq9CqEN4sGbY/75hT6wDAz9mlF oQI7oq/yyDkq3qSXqO3AieU5UhG3hz+1oDpLJ6/lmCAeGLZCBmUzF8xliYEmMeuhn3VtyKPAlf2 QnImsGGJl3tsI54H8wvfrrtM= X-Received: by 2002:a05:622a:4293:b0:3b9:bc8c:c1fd with SMTP id cr19-20020a05622a429300b003b9bc8cc1fdmr9368150qtb.8.1676653866978; Fri, 17 Feb 2023 09:11:06 -0800 (PST) X-Google-Smtp-Source: AK7set+DiDj402ZSadlOpC2NQSJsRqMOg2u6Y3MziTQqRVn+sio5jbuhbwn2/1oeYAY+J6UTYVwBGg== X-Received: by 2002:a05:622a:4293:b0:3b9:bc8c:c1fd with SMTP id cr19-20020a05622a429300b003b9bc8cc1fdmr9368103qtb.8.1676653866618; Fri, 17 Feb 2023 09:11:06 -0800 (PST) Received: from [192.168.1.108] (130-44-159-43.s15913.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.159.43]) by smtp.gmail.com with ESMTPSA id s4-20020a372c04000000b006f9f3c0c63csm3662205qkh.32.2023.02.17.09.11.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Feb 2023 09:11:06 -0800 (PST) Message-ID: Date: Fri, 17 Feb 2023 12:11:03 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH] Accept pmf-vbit-in-delta extra warning To: Alexandre Oliva , gcc-patches@gcc.gnu.org Cc: nathan@acm.org, nickc@redhat.com, richard.earnshaw@arm.com, ramana.gcc@gmail.com, kyrylo.tkachov@arm.com, ro@CeBiTec.Uni-Bielefeld.DE, mikestump@comcast.net References: From: Jason Merrill In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/17/23 23:02, Alexandre Oliva wrote: > > cp_build_binary_op, that issues -Waddress warnings, issues an extra > warning on arm targets, that g++.dg/warn/Waddress-5.C does not expect > when comparing a pointer-to-member-function literal with null. > > The reason for the extra warning is that, on arm targets, > TARGET_PTRMEMFUNC_VBIT_LOCATION == ptrmemfunc_vbit_in_delta, which > causes a different path to be taken, that extracts the > pointer-to-function and the delta fields (minus the vbit) and compares > each one with zero. It's when comparing this pointer-to-function with > zero, in a recursive cp_build_binary_op, that another warning is > issued. > > I suppose there should be a way to skip the warning in this recursive > call, without disabling other warnings that might be issued there, but warning_sentinel ws (warn_address) ? > this patch only arranges for the test to tolerate the extra warning. > > Regstrapped on x86_64-linux-gnu. > Tested on arm-vxworks7 (gcc-12) and arm-eabi (trunk). Ok to install? OK > for gcc/testsuite/ChangeLog > > * g++.dg/warn/Waddress-5.C: Tolerate extra -Waddress warning. > --- > gcc/testsuite/g++.dg/warn/Waddress-5.C | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/gcc/testsuite/g++.dg/warn/Waddress-5.C b/gcc/testsuite/g++.dg/warn/Waddress-5.C > index b1287b2fac316..1de88076f7767 100644 > --- a/gcc/testsuite/g++.dg/warn/Waddress-5.C > +++ b/gcc/testsuite/g++.dg/warn/Waddress-5.C > @@ -23,7 +23,11 @@ void T (bool); > void warn_memptr_if () > { > // Exercise warnings for addresses of nonstatic member functions. > - if (&A::f == 0) // { dg-warning "the address '&A::f'" } > + // On targets with TARGET_PTRMEMFUNC_VBIT_LOCATION == > + // ptrmemfunc_vbit_in_delta, cp_build_binary_op recurses to compare > + // the pfn from the ptrmemfunc with null, so we get two warnings. > + // This matches both. ??? Should we disable one of them? > + if (&A::f == 0) // { dg-warning "A::f" } > T (0); > > if (&A::vf) // { dg-warning "-Waddress" } >