From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by sourceware.org (Postfix) with ESMTPS id 5AA723858C3A for ; Thu, 14 Oct 2021 16:26:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5AA723858C3A Received: by mail-pl1-x634.google.com with SMTP id c4so4530506pls.6 for ; Thu, 14 Oct 2021 09:26:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=eT2qllFiF4NYi+LOnlG28o1ojtZGbdb45eD/JIXtj88=; b=JXM4mtfSj7QJapoak8Z+13maIdYi+CiZ9hydKLh4U28kTlZydYAPGs4fU0OuDIM49D nhVWnUpx4aGOxbcmhwjwMiGOosiBPhJeLUHVPhTVrO1J9YZT2aUBypA64rnOO/MakJ/t B9HSxHO+ekCU0dD0BTwLz0qqtQ6Q+rE6SPg0mKLJrL1NdWpoOMqkmBnWAk7NF7rzSVWw 59T/yCuMVD4RnjshgFWpAswC6nF2xEiVskWLjdMmywsqbR45iRRJYmmeiB1l+7uO5XqM aGn7xah9B6jk20lPT/uq1hEIbCiz56Lwj3VOinHWCTF1fa2kvuVuwvrxMr9pI0717wVZ MalQ== X-Gm-Message-State: AOAM530OtflIMBpFId7DPrujKbb161m74HrC8qA+3oB+foeMPCFJeQZv PZKnRQCF4/xiRujigpTgwn8GIfKdPng= X-Google-Smtp-Source: ABdhPJz7HXOsO2OJYOFvBXmytX5cMxwJXFZ/zIhIFe72f4Vlir5JI9QK52GWoXFsoJUeWGdelu8vkQ== X-Received: by 2002:a17:90a:de84:: with SMTP id n4mr3397258pjv.226.1634228807691; Thu, 14 Oct 2021 09:26:47 -0700 (PDT) Received: from [172.31.0.175] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id j12sm2918157pff.127.2021.10.14.09.26.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Oct 2021 09:26:47 -0700 (PDT) Subject: Re: [PATCH] Allow `make tags` to work from top-level directory To: Eric Gallager Cc: Jeff Law , gcc-patches References: <98b7d7ad-3869-f44f-c95c-289da8cb2828@gmail.com> From: Jeff Law Message-ID: Date: Thu, 14 Oct 2021 10:26:46 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Oct 2021 16:26:51 -0000 On 10/12/2021 1:56 PM, Eric Gallager wrote: > On Tue, Oct 12, 2021 at 9:18 AM Jeff Law wrote: >> >> >> On 10/11/2021 4:05 PM, Eric Gallager via Gcc-patches wrote: >>> On Thu, Oct 13, 2016 at 4:43 PM Eric Gallager wrote: >>>> On 10/13/16, Jeff Law wrote: >>>>> On 10/06/2016 07:21 AM, Eric Gallager wrote: >>>>>> The libdecnumber, libgcc, and libobjc subdirectories are missing TAGS >>>>>> targets in their Makefiles. The attached patch causes them to be >>>>>> skipped when running `make tags`. >>>>>> >>>>>> ChangeLog entry: >>>>>> >>>>>> 2016-10-06 Eric Gallager >>>>>> >>>>>> * Makefile.def: Mark libdecnumber, libgcc, and libobjc as missing >>>>>> TAGS target. >>>>>> * Makefile.in: Regenerate. >>>>>> >>>>> OK. Please install. >>>>> >>>>> Thanks, >>>>> Jeff >>>>> >>>> I'm still waiting to hear back from about my request >>>> for copyright assignment, which I'll need to get sorted out before I >>>> can start committing stuff (like this patch). >>>> >>>> Thanks, >>>> Eric >>> Update: In the intervening years, I got my copyright assignment filed >>> and have recently become able to commit again; is your old approval >>> from 2016 still valid, Jeff, or do I need a re-approval? >>> Ref: https://gcc.gnu.org/legacy-ml/gcc-patches/2016-10/msg00370.html >> It's still valid. Just re-test and commit. >> >> jeff > While re-testing, it seems that the `etags` command on my computer > can't be found any longer; I'm thinking gcc/Makefile.in should be > updated to stop hardcoding etags and use a variable that can be > overridden instead... should I do a separate patch for that, or > combine it with this one? I think this will be simple enough that either way will be fine. jeff