* [PATCH] Update comment about the format of attribute name in attribute_spec handler
@ 2018-05-28 12:53 Jozef Lawrynowicz
2018-05-30 23:34 ` Jeff Law
0 siblings, 1 reply; 2+ messages in thread
From: Jozef Lawrynowicz @ 2018-05-28 12:53 UTC (permalink / raw)
To: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 395 bytes --]
With the changes in r250911 to canonicalize attribute names (i.e. remove
leading and trailing underscores if present) a comment for "handler" in
the attribute_spec struct needs to be updated to reflect that the NAME argument
is now stripped of any underscores.
Patch is attached.
If the patch is acceptable, I would appreciate if someone would commit it for
me, as I don't have write access.
[-- Attachment #2: 0001-Update-comment-about-the-format-of-attribute-name-in.patch --]
[-- Type: text/x-patch, Size: 2305 bytes --]
From 386f8e6aadf5627fcba0955a8dbb6abcec69b1a5 Mon Sep 17 00:00:00 2001
From: Jozef Lawrynowicz <jozef.l@mittosystems.com>
Date: Mon, 28 May 2018 13:04:12 +0100
Subject: [PATCH] Update comment about the format of attribute name in
attribute_spec handler
2018-05-28 Jozef Lawrynowicz <jozef.l@mittosystems.com>
* gcc/tree-core.h: Update comment about the format of NAME string
passed to handler in attribute_spec.
---
gcc/tree-core.h | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/gcc/tree-core.h b/gcc/tree-core.h
index 478c631..f7be51f 100644
--- a/gcc/tree-core.h
+++ b/gcc/tree-core.h
@@ -1942,14 +1942,14 @@ struct attribute_spec {
bool affects_type_identity;
/* Function to handle this attribute. NODE points to the node to which
the attribute is to be applied. If a DECL, it should be modified in
- place; if a TYPE, a copy should be created. NAME is the name of the
- attribute (possibly with leading or trailing __). ARGS is the TREE_LIST
- of the arguments (which may be NULL). FLAGS gives further information
- about the context of the attribute. Afterwards, the attributes will
- be added to the DECL_ATTRIBUTES or TYPE_ATTRIBUTES, as appropriate,
- unless *NO_ADD_ATTRS is set to true (which should be done on error,
- as well as in any other cases when the attributes should not be added
- to the DECL or TYPE). Depending on FLAGS, any attributes to be
+ place; if a TYPE, a copy should be created. NAME is the canonicalized
+ name of the attribute i.e. without any leading or trailing underscores.
+ ARGS is the TREE_LIST of the arguments (which may be NULL). FLAGS gives
+ further information about the context of the attribute. Afterwards, the
+ attributes will be added to the DECL_ATTRIBUTES or TYPE_ATTRIBUTES, as
+ appropriate, unless *NO_ADD_ATTRS is set to true (which should be done on
+ error, as well as in any other cases when the attributes should not be
+ added to the DECL or TYPE). Depending on FLAGS, any attributes to be
applied to another type or DECL later may be returned;
otherwise the return value should be NULL_TREE. This pointer may be
NULL if no special handling is required beyond the checks implied
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Update comment about the format of attribute name in attribute_spec handler
2018-05-28 12:53 [PATCH] Update comment about the format of attribute name in attribute_spec handler Jozef Lawrynowicz
@ 2018-05-30 23:34 ` Jeff Law
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Law @ 2018-05-30 23:34 UTC (permalink / raw)
To: Jozef Lawrynowicz, gcc-patches
On 05/28/2018 06:25 AM, Jozef Lawrynowicz wrote:
> With the changes in r250911 to canonicalize attribute names (i.e. remove
> leading and trailing underscores if present) a comment for "handler" in
> the attribute_spec struct needs to be updated to reflect that the NAME argument
>
> is now stripped of any underscores.
>
> Patch is attached.
>
> If the patch is acceptable, I would appreciate if someone would commit it for
>
> me, as I don't have write access.
We should probably get you write access if you're going to continue to
submit patches.
https://sourceware.org/cgi-bin/pdw/ps_form.cgi
List me as approving your request.
>
>
> 0001-Update-comment-about-the-format-of-attribute-name-in.patch
>
>
> From 386f8e6aadf5627fcba0955a8dbb6abcec69b1a5 Mon Sep 17 00:00:00 2001
> From: Jozef Lawrynowicz <jozef.l@mittosystems.com>
> Date: Mon, 28 May 2018 13:04:12 +0100
> Subject: [PATCH] Update comment about the format of attribute name in
> attribute_spec handler
>
> 2018-05-28 Jozef Lawrynowicz <jozef.l@mittosystems.com>
>
> * gcc/tree-core.h: Update comment about the format of NAME string
> passed to handler in attribute_spec.
Thanks. Installed on the trunk.
jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-30 23:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-28 12:53 [PATCH] Update comment about the format of attribute name in attribute_spec handler Jozef Lawrynowicz
2018-05-30 23:34 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).