From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id AF7AC3857342 for ; Wed, 4 May 2022 12:41:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AF7AC3857342 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 75C63210E7; Wed, 4 May 2022 12:41:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1651668117; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sNScn3R886w6gLPjuvLplvJtQHOJrRiL9T2PJjmvnIk=; b=B/Z0hnF/i5XomUuthYPnVux75Yu5sAqD3Y4GZxwzjQ+8YjCwNj1Azf1T/mYPRSf0UCN9tK NFwnOvOV7cJdhxcOuoq7aokTlJ6ldRND2jU5UAlHH08pjNwHMk64qEczgOW70d5kE9Fv7G Um7SE86tFO40oVZ9fuq4O7Ei7d5QoIQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1651668117; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sNScn3R886w6gLPjuvLplvJtQHOJrRiL9T2PJjmvnIk=; b=ABkgTrvhS4hLISmzsD7gj90Rfoqs9KiMH2+dkfj+/E01soyEecB7XAAdyAknlOmScvAHDQ EBHiboKCmRv8zWAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5EF91132C4; Wed, 4 May 2022 12:41:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id CeDSFZV0cmJlYwAAMHmgww (envelope-from ); Wed, 04 May 2022 12:41:57 +0000 Content-Type: multipart/mixed; boundary="------------i6Prf7mlmceedGiCe8x1VmLQ" Message-ID: Date: Wed, 4 May 2022 14:41:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] lto-plugin: add support for feature detection Content-Language: en-US To: Alexander Monakov Cc: gcc-patches@gcc.gnu.org, Jan Hubicka References: <63633ead-aa7e-c424-9851-ac332ac13df3@suse.cz> <27841a42-baef-d53e-c601-ad265030854d@suse.cz> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2022 12:42:00 -0000 This is a multi-part message in MIME format. --------------i6Prf7mlmceedGiCe8x1VmLQ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 5/4/22 14:32, Alexander Monakov wrote: > On Wed, 4 May 2022, Martin Liška wrote: > >> The patch is a follow-up of the discussion we've got in: >> https://gcc.gnu.org/pipermail/gcc-patches/2022-May/593901.html >> >> Mold linker would appreciate knowing in advance if get_symbols_v3 is supported >> by a GCC plug-in or not. >> >> Ready to be installed? > > Quick note: if the linker is supposed to check for presence of this symbol > via dlsym(), I expect it won't work as-is since lto-plugin.map hides every > symbol except 'onload'. Oh, good point! Changing that, I get now: $ nm ./lto-plugin/.libs/liblto_plugin.so | grep v3 0000000000015008 D supports_get_symbols_v3 > > (also it might be nicer to reword the comment to say 'Presence of the following > symbols is used for ...', because you're leaving the value as 'false'). Sure. I'm also changing it's default value. Sending v2. Cheers, Martin > > Alexander > >> Thanks, >> Martin >> >> lto-plugin/ChangeLog: >> >> * lto-plugin.c (supports_get_symbols_v3): Add symbol. >> --- >> lto-plugin/lto-plugin.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/lto-plugin/lto-plugin.c b/lto-plugin/lto-plugin.c >> index 47378435612..049f3841d5b 100644 >> --- a/lto-plugin/lto-plugin.c >> +++ b/lto-plugin/lto-plugin.c >> @@ -1554,3 +1554,8 @@ onload (struct ld_plugin_tv *tv) >> >> return LDPS_OK; >> } >> + >> +/* The following symbols are used for dynamic detection of plug-in features >> + from linker side. */ >> + >> +bool supports_get_symbols_v3; --------------i6Prf7mlmceedGiCe8x1VmLQ Content-Type: text/x-patch; charset=UTF-8; name="0001-lto-plugin-add-support-for-feature-detection.patch" Content-Disposition: attachment; filename="0001-lto-plugin-add-support-for-feature-detection.patch" Content-Transfer-Encoding: base64 RnJvbSA3YjVhY2Q3OWE3NDllNTBiYzgyNWE0OWIyODNkNGY5ZTgyYTVlMWI1IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gTGlza2EgPG1saXNrYUBzdXNlLmN6PgpE YXRlOiBUdWUsIDEgTWFyIDIwMjIgMTI6Mjc6NDUgKzAxMDAKU3ViamVjdDogW1BBVENIXSBs dG8tcGx1Z2luOiBhZGQgc3VwcG9ydCBmb3IgZmVhdHVyZSBkZXRlY3Rpb24KCmx0by1wbHVn aW4vQ2hhbmdlTG9nOgoKCSogbHRvLXBsdWdpbi5jIChzdXBwb3J0c19nZXRfc3ltYm9sc192 Myk6IEFkZCBzeW1ib2wgYW5kCglpbml0aWFsaXplIGl0IHRvIHRydWU7CgpsdG8tcGx1Z2lu L0NoYW5nZUxvZzoKCgkqIGx0by1wbHVnaW4ubWFwOiBBZGQgc3VwcG9ydHNfZ2V0X3N5bWJv bHNfdjMgc3ltYm9sLgotLS0KIGx0by1wbHVnaW4vbHRvLXBsdWdpbi5jICAgfCA1ICsrKysr CiBsdG8tcGx1Z2luL2x0by1wbHVnaW4ubWFwIHwgNSArKysrLQogMiBmaWxlcyBjaGFuZ2Vk LCA5IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9sdG8tcGx1 Z2luL2x0by1wbHVnaW4uYyBiL2x0by1wbHVnaW4vbHRvLXBsdWdpbi5jCmluZGV4IDQ3Mzc4 NDM1NjEyLi42YWFjNTg2NzA2NiAxMDA2NDQKLS0tIGEvbHRvLXBsdWdpbi9sdG8tcGx1Z2lu LmMKKysrIGIvbHRvLXBsdWdpbi9sdG8tcGx1Z2luLmMKQEAgLTE1NTQsMyArMTU1NCw4IEBA IG9ubG9hZCAoc3RydWN0IGxkX3BsdWdpbl90diAqdHYpCiAKICAgcmV0dXJuIExEUFNfT0s7 CiB9CisKKy8qIFByZXNlbmNlIG9mIHRoZSBmb2xsb3dpbmcgc3ltYm9scyBpcyB1c2VkIGZv ciBkeW5hbWljIGRldGVjdGlvbiBvZiBwbHVnLWluIGZlYXR1cmVzCisgICBmcm9tIGxpbmtl ciBzaWRlLiAgKi8KKworYm9vbCBzdXBwb3J0c19nZXRfc3ltYm9sc192MyA9IHRydWU7CmRp ZmYgLS1naXQgYS9sdG8tcGx1Z2luL2x0by1wbHVnaW4ubWFwIGIvbHRvLXBsdWdpbi9sdG8t cGx1Z2luLm1hcAppbmRleCAzZDYwZTcxY2MyZC4uNDJkYzUwYTgxOWMgMTAwNjQ0Ci0tLSBh L2x0by1wbHVnaW4vbHRvLXBsdWdpbi5tYXAKKysrIGIvbHRvLXBsdWdpbi9sdG8tcGx1Z2lu Lm1hcApAQCAtMSwzICsxLDYgQEAKIHsKLSAgZ2xvYmFsOiBvbmxvYWQ7IGxvY2FsOiAqOwor ICBnbG9iYWw6IG9ubG9hZDsKKyAgICAgICAgICBzdXBwb3J0c19nZXRfc3ltYm9sc192MzsK KworICBsb2NhbDogKjsKIH07Ci0tIAoyLjM2LjAKCg== --------------i6Prf7mlmceedGiCe8x1VmLQ--