From: "Lynn A. Boger" <laboger@linux.vnet.ibm.com>
To: Ian Lance Taylor <iant@golang.org>,
Eric Botcazou <ebotcazou@adacore.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch v2] Get rid of stack trampolines for nested functions (1/4)
Date: Tue, 06 Dec 2016 21:59:00 -0000 [thread overview]
Message-ID: <e57abc32-bffa-912b-0505-c4a25e093895@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAOyqgcV5TEZVFaA74cd_1AHFX9faoXbHLJwyY-wDKVWjK_xrRw@mail.gmail.com>
I tried this patch applied against latest and it fixed the testcases
that I had reported as failing, but the patch also causes
libgo reflect testcase to fail. Still testing to verify and will report
the failure details.
On 12/06/2016 02:18 PM, Ian Lance Taylor wrote:
> On Tue, Dec 6, 2016 at 9:52 AM, Eric Botcazou <ebotcazou@adacore.com> wrote:
>>> There are a couple of changes to the RTL expander for calls; they are
>>> supposed to be transparent but they might have tripped on a latent issue.
>> Tentative fix attached, I need to test it extensively in Ada though.
> Thanks. Lynn, can you see if this patch fixes the bugs you see?
>
>> Btw, Ian, if the heap trampoline support is no longer used by the Go compiler,
>> you might want to remove it from the middle-end.
> Yes, I suppose so. The Go frontend hasn't used them for a while.
>
> Ian
>
>
next prev parent reply other threads:[~2016-12-06 21:59 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-04 20:10 [patch v2] Get rid of stack trampolines for nested functions (0/4) Eric Botcazou
2016-09-04 20:12 ` [patch v2] Get rid of stack trampolines for nested functions (1/4) Eric Botcazou
2016-09-12 19:41 ` Jeff Law
2016-09-12 19:45 ` Jeff Law
2016-12-05 20:52 ` Ian Lance Taylor
2016-12-05 21:29 ` Lynn A. Boger
2016-12-05 22:41 ` Ian Lance Taylor
2016-12-05 22:12 ` Eric Botcazou
2016-12-06 17:52 ` Eric Botcazou
2016-12-06 20:18 ` Ian Lance Taylor
2016-12-06 21:59 ` Lynn A. Boger [this message]
2016-12-06 22:26 ` Eric Botcazou
2016-12-07 13:38 ` Lynn A. Boger
2016-12-07 13:56 ` Eric Botcazou
2016-12-07 7:23 ` Eric Botcazou
2017-03-23 16:48 ` Andreas Schwab
2017-03-28 17:01 ` Eric Botcazou
2017-03-29 10:05 ` Andreas Schwab
2017-03-29 14:05 ` Eric Botcazou
2017-03-29 14:15 ` Andreas Schwab
2016-09-04 20:14 ` [patch v2] Get rid of stack trampolines for nested functions (2/4) Eric Botcazou
2016-09-04 20:15 ` [patch v2] Get rid of stack trampolines for nested functions (3/4) Eric Botcazou
2016-09-05 10:52 ` Segher Boessenkool
2016-09-12 19:56 ` Jeff Law
2016-09-04 21:31 ` [patch v2] Get rid of stack trampolines for nested functions (4/4) Eric Botcazou
2016-10-16 20:29 ` [patch v2] Get rid of stack trampolines for nested functions (0/4) Eric Botcazou
2016-10-17 10:40 ` Andreas Schwab
2016-10-17 11:14 ` Eric Botcazou
2016-10-17 22:35 ` Eric Botcazou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e57abc32-bffa-912b-0505-c4a25e093895@linux.vnet.ibm.com \
--to=laboger@linux.vnet.ibm.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=iant@golang.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).