From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120060 invoked by alias); 6 Dec 2016 21:59:40 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 119615 invoked by uid 89); 6 Dec 2016 21:59:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,RCVD_IN_SEMBACKSCATTER autolearn=no version=3.3.2 spammy=H*UA:i686, Btw, H*u:i686, H*f:sk:1024777 X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Dec 2016 21:59:29 +0000 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id uB6Lt6oZ094538 for ; Tue, 6 Dec 2016 16:59:27 -0500 Received: from e37.co.us.ibm.com (e37.co.us.ibm.com [32.97.110.158]) by mx0a-001b2d01.pphosted.com with ESMTP id 2764gg2x22-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 06 Dec 2016 16:59:27 -0500 Received: from localhost by e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 6 Dec 2016 14:59:26 -0700 Received: from d03dlp01.boulder.ibm.com (9.17.202.177) by e37.co.us.ibm.com (192.168.1.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 6 Dec 2016 14:59:25 -0700 Received: from b03cxnp07029.gho.boulder.ibm.com (b03cxnp07029.gho.boulder.ibm.com [9.17.130.16]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id 96AC71FF001F; Tue, 6 Dec 2016 14:59:03 -0700 (MST) Received: from b03ledav001.gho.boulder.ibm.com (b03ledav001.gho.boulder.ibm.com [9.17.130.232]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id uB6LxMZv16974240; Tue, 6 Dec 2016 14:59:24 -0700 Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9A3F56E03D; Tue, 6 Dec 2016 14:59:24 -0700 (MST) Received: from oc3540537726.ibm.com (unknown [9.10.86.47]) by b03ledav001.gho.boulder.ibm.com (Postfix) with ESMTP id 5E9C46E038; Tue, 6 Dec 2016 14:59:24 -0700 (MST) Subject: Re: [patch v2] Get rid of stack trampolines for nested functions (1/4) To: Ian Lance Taylor , Eric Botcazou References: <1518726.5fkcUnkpqM@arcturus.home> <3049494.GQlGFrCAi9@polaris> <10247773.6SAYMWXB7c@polaris> Cc: gcc-patches From: "Lynn A. Boger" Date: Tue, 06 Dec 2016 21:59:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16120621-0024-0000-0000-000015348AF2 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006206; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000194; SDB=6.00790228; UDB=6.00382666; IPR=6.00567967; BA=6.00004946; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00013560; XFM=3.00000011; UTC=2016-12-06 21:59:26 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16120621-0025-0000-0000-000046BDF137 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-06_12:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1612060323 X-IsSubscribed: yes X-SW-Source: 2016-12/txt/msg00505.txt.bz2 I tried this patch applied against latest and it fixed the testcases that I had reported as failing, but the patch also causes libgo reflect testcase to fail. Still testing to verify and will report the failure details. On 12/06/2016 02:18 PM, Ian Lance Taylor wrote: > On Tue, Dec 6, 2016 at 9:52 AM, Eric Botcazou wrote: >>> There are a couple of changes to the RTL expander for calls; they are >>> supposed to be transparent but they might have tripped on a latent issue. >> Tentative fix attached, I need to test it extensively in Ada though. > Thanks. Lynn, can you see if this patch fixes the bugs you see? > >> Btw, Ian, if the heap trampoline support is no longer used by the Go compiler, >> you might want to remove it from the middle-end. > Yes, I suppose so. The Go frontend hasn't used them for a while. > > Ian > >