From: chenglulu <chenglulu@loongson.cn>
To: Xi Ruoyao <xry111@xry111.site>, gcc-patches@gcc.gnu.org
Cc: i@xen0n.name, xuchenghua@loongson.cn
Subject: Re: Pushed: [PATCH v2] LoongArch: Use finer-grained DBAR hints
Date: Tue, 14 Nov 2023 16:48:15 +0800 [thread overview]
Message-ID: <e5804576-3584-665b-9ab6-5c10bb1af17a@loongson.cn> (raw)
In-Reply-To: <41e81bc766f9cc66cd426d313e4a4c858360822e.camel@xry111.site>
[-- Attachment #1: Type: text/plain, Size: 1284 bytes --]
在 2023/11/14 下午4:34, Xi Ruoyao 写道:
> On Tue, 2023-11-14 at 10:26 +0800, chenglulu wrote:
>> Hi,
>>
>>
>> * Before calling this template, the function get_memmodel is called to process memmodel, which has a piece of code:
>>
>> /* Workaround for Bugzilla 59448. GCC doesn't track consume properly, so
>> be conservative and promote consume to acquire. */
>> if (val == MEMMODEL_CONSUME)
>> val = MEMMODEL_ACQUIRE;
>>
>> * So I think MEMMODEL_CONSUME don't need to be processed here either.
>>
>>
>> Otherwise is OK.
> Thanks, I've removed case MEMMODEL_CONSUME and there seems no issue.
> RISC-V mem_thread_fence expansion also does not handle MEMMODEL_CONSUME.
>
> Pushed r14-5432 with case MEMMODEL_CONSUME removed and comment adjusted,
> as attached.
>
> But curiously there are various references to MEMMODEL_CONSUME in
> gcc/config:
>
> $ grep -lr MEMMODEL_CONSUME gcc/config
> gcc/config/aarch64/aarch64.cc
> gcc/config/riscv/riscv.cc
> gcc/config/ia64/ia64.cc
> gcc/config/ia64/sync.md
> gcc/config/gcn/gcn.md
> gcc/config/loongarch/loongarch.cc
> gcc/config/rs6000/rs6000.cc
> gcc/config/rs6000/sync.md
> gcc/config/nvptx/nvptx.cc
>
> Maybe all of them are redundant?
>
I think so.:-)
*
prev parent reply other threads:[~2023-11-14 8:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 23:18 [PATCH] " Xi Ruoyao
2023-11-14 2:26 ` chenglulu
2023-11-14 8:34 ` Pushed: [PATCH v2] " Xi Ruoyao
2023-11-14 8:48 ` chenglulu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5804576-3584-665b-9ab6-5c10bb1af17a@loongson.cn \
--to=chenglulu@loongson.cn \
--cc=gcc-patches@gcc.gnu.org \
--cc=i@xen0n.name \
--cc=xry111@xry111.site \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).