From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 41FBF3858D20 for ; Tue, 14 Nov 2023 08:48:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 41FBF3858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 41FBF3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699951702; cv=none; b=FSbPvys3eE12UY8KtJ0gwmfJkVs7RDIg355X7VDpFw6PwwwK+n9DWj8F+vpzHQW2XEC5Bon9BnBFqiaKxngF/ArNRreRRb5a43xknx3j9/ymW7xsPNGtwOqsg9iyTtBclfBhnEwfMfRmm05rZX4C6TqzPoptpzUrRyt21oCP4sw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699951702; c=relaxed/simple; bh=/ZRoO/AVZJSe34fyySz3SFefqM6ptflGfyL/+CTdnwk=; h=Subject:To:From:Message-ID:Date:MIME-Version; b=QbIeBmpxfpMLSVM59qfZTFqyK1gKrRnhAgyIXMXchJg5133E3xjb0rv6hCDLe2huKti3Tu1zY3O13hxfHT9Bun3vgXLc/mdYAvBfMSpysb1kv6f95fajr0C0gcbHnx4RubaUQEigOcFCALPmGnZDkswifXPJvzo5JrzAPKPpxa8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from loongson.cn (unknown [10.20.4.107]) by gateway (Coremail) with SMTP id _____8Cx77tPNFNlv+Q5AA--.54705S3; Tue, 14 Nov 2023 16:48:16 +0800 (CST) Received: from [10.20.4.107] (unknown [10.20.4.107]) by localhost.localdomain (Coremail) with SMTP id AQAAf8DxiuRPNFNlDbxBAA--.14396S3; Tue, 14 Nov 2023 16:48:15 +0800 (CST) Subject: Re: Pushed: [PATCH v2] LoongArch: Use finer-grained DBAR hints To: Xi Ruoyao , gcc-patches@gcc.gnu.org Cc: i@xen0n.name, xuchenghua@loongson.cn References: <20231113231837.369907-1-xry111@xry111.site> <01e49973-227f-f7aa-f1f9-25c4392dfb78@loongson.cn> <41e81bc766f9cc66cd426d313e4a4c858360822e.camel@xry111.site> From: chenglulu Message-ID: Date: Tue, 14 Nov 2023 16:48:15 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <41e81bc766f9cc66cd426d313e4a4c858360822e.camel@xry111.site> Content-Type: multipart/alternative; boundary="------------31B6AF8DD58E7E0DEC56AD8E" Content-Language: en-US X-CM-TRANSID:AQAAf8DxiuRPNFNlDbxBAA--.14396S3 X-CM-SenderInfo: xfkh0wpoxo3qxorr0wxvrqhubq/ X-Coremail-Antispam: 1Uk129KBj93XoWrtFy5ZFy7Aw45Wr1DWF4DGFX_yoW8JF4Upr Z5Ca1rAr98AF4SqrWjyry8W3yfJr17tw4avw4fWFy8Aw4DA34Yvrs8W3y29rWDWr4v9r4I vrWFgFyav3yUA3cCm3ZEXasCq-sJn29KB7ZKAUJUUUU5529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnRJUUUv0b4IE77IF4wAF F20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r 1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAF wI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv67 AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AKxVW8Jr0_Cr1UM2AIxVAIcxkEcVAq 07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx1lYx0E2Ix0cI8IcVAFwI0_Jrv_JF 1lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCj r7xvwVCIw2I0I7xG6c02F41lc7I2V7IY0VAS07AlzVAYIcxG8wCF04k20xvY0x0EwIxGrw CFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r106r1rMI8I3I0E7480Y4vE 14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2 IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxK x2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI 0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IUbNJ57UUUUU== X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,BODY_8BITS,HTML_MESSAGE,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------31B6AF8DD58E7E0DEC56AD8E Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit 在 2023/11/14 下午4:34, Xi Ruoyao 写道: > On Tue, 2023-11-14 at 10:26 +0800, chenglulu wrote: >> Hi, >> >> >>  * Before calling this template, the function get_memmodel is called to process memmodel, which has a piece of code: >> >>        /* Workaround for Bugzilla 59448. GCC doesn't track consume properly, so >>         be conservative and promote consume to acquire. */ >>      if (val == MEMMODEL_CONSUME) >>        val = MEMMODEL_ACQUIRE; >> >>  * So I think MEMMODEL_CONSUME don't need to be processed here either. >> >> >> Otherwise is OK. > Thanks, I've removed case MEMMODEL_CONSUME and there seems no issue. > RISC-V mem_thread_fence expansion also does not handle MEMMODEL_CONSUME. > > Pushed r14-5432 with case MEMMODEL_CONSUME removed and comment adjusted, > as attached. > > But curiously there are various references to MEMMODEL_CONSUME in > gcc/config: > > $ grep -lr MEMMODEL_CONSUME gcc/config > gcc/config/aarch64/aarch64.cc > gcc/config/riscv/riscv.cc > gcc/config/ia64/ia64.cc > gcc/config/ia64/sync.md > gcc/config/gcn/gcn.md > gcc/config/loongarch/loongarch.cc > gcc/config/rs6000/rs6000.cc > gcc/config/rs6000/sync.md > gcc/config/nvptx/nvptx.cc > > Maybe all of them are redundant? > I think so.:-) * --------------31B6AF8DD58E7E0DEC56AD8E--