From: Jeff Law <jeffreyalaw@gmail.com>
To: Robin Dapp <rdapp.gcc@gmail.com>,
Kito Cheng <kito.cheng@gmail.com>,
Juzhe-Zhong <juzhe.zhong@rivai.ai>
Cc: gcc-patches@gcc.gnu.org, kito.cheng@sifive.com
Subject: Re: [PATCH V4] RISC-V: Enable vec_int testsuite for RVV VLA vectorization
Date: Mon, 28 Aug 2023 12:49:50 -0600 [thread overview]
Message-ID: <e5fc8f8c-aad0-4ad7-c044-6af5b4b17cc5@gmail.com> (raw)
In-Reply-To: <07474492-1fa9-db00-5b3f-0cd9b63e6c34@gmail.com>
On 8/28/23 08:27, Robin Dapp via Gcc-patches wrote:
>> LGTM from my side, but I would like to wait Robin is ok too
>
> In principle I'm OK with it as well, realizing we will still need to fine-tune
> a lot here anyway. For now, IMHO it's good to have some additional test coverage
> in the vector space but we should not expect every test to be correct/a good match
> for everything we do yet. Juzhe mentioned he doesn't want to commit this before
> all/most bugs are addresses anyway, right?
No strong opinions on my side. We could enable now knowing there's
failures and that list of failures becomes a TODO list. Or we could
wait for more to be working before committing to keep our test results
reasonably clean.
I could make an argument for either direction, but since Juzhe & Robin
are doing most of the autovec work, happy to go with whatever they prefer.
jeff
next prev parent reply other threads:[~2023-08-28 18:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 11:42 Juzhe-Zhong
2023-08-28 14:18 ` Kito Cheng
2023-08-28 14:27 ` Robin Dapp
2023-08-28 18:49 ` Jeff Law [this message]
2023-08-29 0:40 ` juzhe.zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5fc8f8c-aad0-4ad7-c044-6af5b4b17cc5@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@gmail.com \
--cc=kito.cheng@sifive.com \
--cc=rdapp.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).