From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by sourceware.org (Postfix) with ESMTPS id E9C353858D28 for ; Mon, 28 Aug 2023 18:49:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E9C353858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-68bed2c786eso2418708b3a.0 for ; Mon, 28 Aug 2023 11:49:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693248593; x=1693853393; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Qdm7AKCjc1aAwj+luhqPcWbWtx/iUm16gHsnF0qtloc=; b=ZouigrtdlhJQbDMr9lTHq6jWfBmd3fSPl1t1z8bGvCWc0HCKbPd+8tDHAwKuoKAKX9 GM0AgRK4BtYdRfcKHqfBQbE2YxgubYnQHk77Sj4BLcTGzEmlv2fC9VFtL+L74nwvRskY IdGRhKZG5AB878AesYOcBGny5v6NokaNkII4Wmqq+iHhzeA5tPrG3MRknJZesZguiCl4 Thn+ft6TKUAbXM2GxfrIMzp4PtU5h9xs6VhhXaARtxOmZQHErhwR0zG6CndYkg6qyWUH xAAP00XnSr+NZcbnBXargByQi6S9a1WrM/SGUu83LUgOizSJ3saWaeoZSViLWpzA9Ons rlRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693248593; x=1693853393; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Qdm7AKCjc1aAwj+luhqPcWbWtx/iUm16gHsnF0qtloc=; b=Y1zRTdAbKiMP3ZcHu6SEigXm3uecnCMDhx5byutWhtKYF/pe+7SKch05lD4NZL5UQU N1Rdntoei84lBy2suEtTtcGH3V4Pcdzpl6qSa6gylx8d7Gr5NYfrrW0NGJKDG6KVH54N c1k8peSey/YIGJwmTCTdgBV6GF/k29u2QpUWQ7rnXAvStiZAOVl6cWcrScp8/TwQGvcV 6M5mryLEtjQzBcCsp9kODY4Df5sx/ImSXGz2IQZ2jz6EROTTOy4MfHSdY6yZrw3qdQ4r Ri82BdnII3lf++XHOnZZf5nL6YqeCPHpj0OMCduOALvsl60uwJEkOfceeSTdWyxC4Bxj VcIQ== X-Gm-Message-State: AOJu0YzMOwfmelsIWh7KLEa02SPonfwsmJ9B/cHr2QP1xZntqt1glt6c BDNld7Q4cCU17iZCgrQJyU8= X-Google-Smtp-Source: AGHT+IFpVzyU4MmIv1dqdR5QLthKU/ZL0PrSATCSMlbojYyRQiSUZreWvaJauReRcMQaRBZGzYWS8A== X-Received: by 2002:a05:6a20:8f0d:b0:132:cd2d:16fd with SMTP id b13-20020a056a208f0d00b00132cd2d16fdmr26112668pzk.38.1693248592456; Mon, 28 Aug 2023 11:49:52 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id a25-20020aa78659000000b00666b3706be6sm7021262pfo.107.2023.08.28.11.49.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Aug 2023 11:49:51 -0700 (PDT) Message-ID: Date: Mon, 28 Aug 2023 12:49:50 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH V4] RISC-V: Enable vec_int testsuite for RVV VLA vectorization Content-Language: en-US To: Robin Dapp , Kito Cheng , Juzhe-Zhong Cc: gcc-patches@gcc.gnu.org, kito.cheng@sifive.com References: <20230828114249.2917296-1-juzhe.zhong@rivai.ai> <07474492-1fa9-db00-5b3f-0cd9b63e6c34@gmail.com> From: Jeff Law In-Reply-To: <07474492-1fa9-db00-5b3f-0cd9b63e6c34@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/28/23 08:27, Robin Dapp via Gcc-patches wrote: >> LGTM from my side, but I would like to wait Robin is ok too > > In principle I'm OK with it as well, realizing we will still need to fine-tune > a lot here anyway. For now, IMHO it's good to have some additional test coverage > in the vector space but we should not expect every test to be correct/a good match > for everything we do yet. Juzhe mentioned he doesn't want to commit this before > all/most bugs are addresses anyway, right? No strong opinions on my side. We could enable now knowing there's failures and that list of failures becomes a TODO list. Or we could wait for more to be working before committing to keep our test results reasonably clean. I could make an argument for either direction, but since Juzhe & Robin are doing most of the autovec work, happy to go with whatever they prefer. jeff