From: Andrew MacLeod <amacleod@redhat.com>
To: Jeff Law <jeffreyalaw@gmail.com>,
gcc-patches <gcc-patches@gcc.gnu.org>,
Aldy Hernandez <aldyh@redhat.com>,
Richard Biener <richard.guenther@gmail.com>,
Jakub Jelinek <jakub@redhat.com>
Subject: [COMMITTED] Ranger : Do not process abnormal ssa-names.
Date: Fri, 15 Oct 2021 12:05:25 -0400 [thread overview]
Message-ID: <e629f746-05b9-2c93-d5fb-943a13c90f21@redhat.com> (raw)
In-Reply-To: <86d78306-d33b-4263-824d-5ef1712ebe41@gmail.com>
On 10/15/21 10:17 AM, Jeff Law wrote:
>
>>
>> I don't want to push it quite yet as I wanted feedback to make sure
>> we don't actually do anything I'm not aware of with SSA_NAMES which
>> have the ABNORMAL_PHI flag set. Most of the code i can find in VRP
>> and vr-values appears to punt, so I presume not even considering
>> those names is fine?
>>
>> This also seems like something that might be worth back-porting,
>> especially the hybrid pass parts...
> Punting on the abnormals seems perfectly fine to me. They rarely, if
> ever, provide information that improves optimization.
>
> Jeff
>
pushed as commit 93ac832f1846e4867aa6537f76f510fab8e3e87d
Andrew
next prev parent reply other threads:[~2021-10-15 16:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 13:50 [PATCH] " Andrew MacLeod
2021-10-15 14:17 ` Jeff Law
2021-10-15 16:05 ` Andrew MacLeod [this message]
2021-10-15 14:21 ` Aldy Hernandez
2021-10-15 14:23 ` Jeff Law
2021-10-16 9:27 ` Andrew Pinski
2021-10-16 16:22 ` Iain Sandoe
2021-10-18 16:08 ` Andrew MacLeod
2021-10-18 9:49 ` Richard Biener
2021-10-18 22:05 ` [COMMITTED] tree-optimization/102796 - Process EH edges again Andrew MacLeod
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e629f746-05b9-2c93-d5fb-943a13c90f21@redhat.com \
--to=amacleod@redhat.com \
--cc=aldyh@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jeffreyalaw@gmail.com \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).