From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by sourceware.org (Postfix) with ESMTPS id 42C2B3858D20 for ; Thu, 25 Apr 2024 14:17:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 42C2B3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 42C2B3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::129 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714054624; cv=none; b=neWNYvRbgxRGCZU2NwxJNnqQpfP2XvQM1ugDTH4xCk5EqLD+99IfQ3CpsIBZaCywMI7P7P5xOzEu9ECmcb0HBAxqgqefIFEaPysP9CzxBjLpJESj6q0/kZpuEYcV00LN/hzccAZU/F9V2np5p1zw71soBqdT5k186U38iBOQybo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714054624; c=relaxed/simple; bh=WjSfxqxh4lrqU/r9VK+yvFkSPdC6Mm0lVGILaPEph+0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=QCRlDrnPv9JvGqcQ64155VA/7xteYGu6olT5ojY3RKkuDy6MyRJNnqrsv9PgBjeoNhpqYqdKU+lTVRmJEiSAZK+nVrlOh+N3vwEe7wi9EbUCVppEpXognpbG1iiB3R+SLunQlUcOB02LW4JM7lc4dsLfgLB2Ky2VMVdvvc7rv0s= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x129.google.com with SMTP id e9e14a558f8ab-36a0d09e6ffso4799955ab.0 for ; Thu, 25 Apr 2024 07:17:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714054621; x=1714659421; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3cCXtOvsI4JQ36SJPgx3SRygKF4nwle9fcvWOSAZ5cU=; b=iOkkV34U2fOzhlIuZdzHDWybzYGIjTauRGYREmMf61YzYw/nyPDdY2rcug/lxfR39U XrUpLCfzbM74L8qZnsoVDQgsswGKIMqhrO5mHIvciYahhE1SDebIZqLH3DizSpsA73+2 B73ukF+hRpYouA17NXxY/qWwB/WJ8rfSiyR6+LK43dKQ6ql8X8lfsIXM6ENj/k4Vgi04 01bnQcUl+Ek/Q/zx5paHLT1XUvZunFzGtFCTfdA9czu/mJdGIAy/ARdCfGW2oqbioLxG vCBtQaY+Q95zQwVrsjUUM/Xobt2O3tlkHLDfMFVg4FSD1+CQ5l/HWGYy9CJs5jlNByXN fogQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714054621; x=1714659421; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3cCXtOvsI4JQ36SJPgx3SRygKF4nwle9fcvWOSAZ5cU=; b=c/SwoUYlp/qRYbcTXYAHMICCe80robi7tOI14gJ6alkPRfjONW1RDCax68LT9uZT1u rC4i/oLITjPYYf7B26IxBo9EydioLB2EiKxT64w2ZlUzJUuhXXk8zrpOmtYn3Za4ULId wxnd9iMGvOAtcFSOfjwPx/+bYJnsHr9fmIa9CPNxKzKKc8MAI+jYlxe0G5y5oOMbQVfn BNknPs0zF5LO113MyifPBSQx+Yf+waD9qNX/Pe7W+T0VpMHpylGsA3U8OZaLKGI0Pvc+ zs0n084+G9s6SA+KUEMitleI7iOZzw+2u5DH89HV9fpBMGJnj4onD94OkJTkMnnHQFFR aXYQ== X-Forwarded-Encrypted: i=1; AJvYcCUniNV/Flj80rvIsgAqxfpBG6WNCBcVKsfyFhUDOmvwJ+d5XEwv0L9sp2MijTfXQRRql/MGcRKCl9Mq5Yk2R2rg6ewkizirkQ== X-Gm-Message-State: AOJu0Yx00IVqdR9zIuqY7jIHUIk16QD1sWGNRdGu6aj4oGFL3Yq8z2Eh fA0rGy/YngKbzXexjuK1JX/YfAJ8aIiAb184aJBmFKXF6fke3DbI X-Google-Smtp-Source: AGHT+IHQjrToDZtw0OJdBXA0ekteBCCIBfo7leCeCKndqIY4sl8VYLiMmP9UhfTUPIT0UZMA/axaMQ== X-Received: by 2002:a05:6e02:1aae:b0:36c:c6d:54af with SMTP id l14-20020a056e021aae00b0036c0c6d54afmr6940918ilv.8.1714054621357; Thu, 25 Apr 2024 07:17:01 -0700 (PDT) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id h18-20020a92c092000000b0036a2d4bc290sm3588763ile.28.2024.04.25.07.17.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Apr 2024 07:17:00 -0700 (PDT) Message-ID: Date: Thu, 25 Apr 2024 08:16:59 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH v1] RISC-V: Revert RVV wv instructions overlap and xfail tests Content-Language: en-US To: =?UTF-8?B?6ZKf5bGF5ZOy?= , patrick , "pan2.li" , "rdapp.gcc" , gcc-patches Cc: "kito.cheng" References: <20240419142901.1585821-1-pan2.li@intel.com> <102e32cd-a6ff-47dc-b054-5c87638eb161@gmail.com> <4987EAADD3EAF406+2024042306075876990914@rivai.ai> From: Jeff Law In-Reply-To: <4987EAADD3EAF406+2024042306075876990914@rivai.ai> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/22/24 4:07 PM, 钟居哲 wrote: > Apologize that we didn't post our (me, kito and Li Pan) disscussions. > > This is the story: > We found that my previous patches which support highpart register > overlap with register filter for instructions like (vwadd.wv) > cause ICE reported by: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114714 gcc.gnu.org/bugzilla/show_bug.cgi?id=114714> > and this is obviously a regression (No ICE on GCC 13.2, but ICE on GCC 14) Just a note for the future, this wouldn't really be considered a regression since GCC-13 didn't have any vector support. I'm happy to help with this kind of judgment call, as are many other GCC developers such as Jakub, Richi, etc. We've been making these kinds of judgment calls for decades. > > We have tried several fixes to work around this ICE, however, we failed. > And also I found my previous patches are quite wrong which is not the > perfect solution to support register group overlap > for vwadd.wv. > So, finally we decide to revert those patches. It would have been useful to bring others into the discussion. Both Robin and I would have likely wanted to understand why disabling the alternative wasn't sufficient. Looking at this more generally, we need to keep in mind that the closer we get to a release, the more careful we need to be. We can take the time to bring more engineers into the technical discussion. We can take the time to evaluate the pros/cons of different approaches and balance them against the needs of the upcoming release and other factors that may come into play. So let's learn, adjust & move on. Thanks, jeff