From: "Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>
To: Richard Henderson <richard.henderson@linaro.org>,
gcc-patches@gcc.gnu.org
Cc: segher@kernel.crashing.org, Wilco.Dijkstra@arm.com,
marcus.shawcroft@arm.com
Subject: Re: [PATCH v2 00/11] aarch64: Implement TImode comparisons
Date: Fri, 3 Apr 2020 12:34:04 +0100 [thread overview]
Message-ID: <e66dbabe-059b-197e-bc3d-87121287ae39@arm.com> (raw)
In-Reply-To: <20200402185353.11047-1-richard.henderson@linaro.org>
On 02/04/2020 19:53, Richard Henderson via Gcc-patches wrote:
> This is attacking case 3 of PR 94174.
>
> In v2, I unify the various subtract-with-borrow and add-with-carry
> patterns that also output flags with unspecs. As suggested by
> Richard Sandiford during review of v1. It does seem cleaner.
>
Really? I didn't need to use any unspecs for the Arm version of this.
R.
>
> r~
>
>
> Richard Henderson (11):
> aarch64: Accept 0 as first argument to compares
> aarch64: Accept zeros in add<GPI>3_carryin
> aarch64: Provide expander for sub<GPI>3_compare1
> aarch64: Introduce aarch64_expand_addsubti
> aarch64: Use UNSPEC_SBCS for subtract-with-borrow + output flags
> aarch64: Use UNSPEC_ADCS for add-with-carry + output flags
> aarch64: Remove CC_ADCmode
> aarch64: Accept -1 as second argument to add<mode>3_carryin
> aarch64: Adjust result of aarch64_gen_compare_reg
> aarch64: Implement TImode comparisons
> aarch64: Implement absti2
>
> gcc/config/aarch64/aarch64-protos.h | 10 +-
> gcc/config/aarch64/aarch64.c | 303 +++++----
> gcc/config/aarch64/aarch64-modes.def | 1 -
> gcc/config/aarch64/aarch64-simd.md | 18 +-
> gcc/config/aarch64/aarch64-speculation.cc | 5 +-
> gcc/config/aarch64/aarch64.md | 762 ++++++++++------------
> gcc/config/aarch64/predicates.md | 15 +-
> 7 files changed, 527 insertions(+), 587 deletions(-)
>
next prev parent reply other threads:[~2020-04-03 11:34 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 18:53 Richard Henderson
2020-04-02 18:53 ` [PATCH v2 01/11] aarch64: Accept 0 as first argument to compares Richard Henderson
2020-04-02 18:53 ` [PATCH v2 02/11] aarch64: Accept zeros in add<GPI>3_carryin Richard Henderson
2020-04-02 18:53 ` [PATCH v2 03/11] aarch64: Provide expander for sub<GPI>3_compare1 Richard Henderson
2020-04-02 18:53 ` [PATCH v2 04/11] aarch64: Introduce aarch64_expand_addsubti Richard Henderson
2020-04-02 18:53 ` [PATCH v2 05/11] aarch64: Use UNSPEC_SBCS for subtract-with-borrow + output flags Richard Henderson
2020-04-09 21:52 ` Segher Boessenkool
2020-04-10 3:50 ` Richard Henderson
2020-04-02 18:53 ` [PATCH v2 06/11] aarch64: Use UNSPEC_ADCS for add-with-carry " Richard Henderson
2020-04-02 18:53 ` [PATCH v2 07/11] aarch64: Remove CC_ADCmode Richard Henderson
2020-04-02 18:53 ` [PATCH v2 08/11] aarch64: Accept -1 as second argument to add<mode>3_carryin Richard Henderson
2020-04-02 18:53 ` [PATCH v2 09/11] aarch64: Adjust result of aarch64_gen_compare_reg Richard Henderson
2020-04-02 18:53 ` [PATCH v2 10/11] aarch64: Implement TImode comparisons Richard Henderson
2020-04-02 18:53 ` [PATCH v2 11/11] aarch64: Implement absti2 Richard Henderson
2020-04-02 18:55 ` [PATCH v2 00/11] aarch64: Implement TImode comparisons Richard Henderson
2020-04-03 11:34 ` Richard Earnshaw (lists) [this message]
2020-04-03 12:27 ` Richard Sandiford
2020-04-03 13:17 ` Richard Earnshaw (lists)
2020-04-03 15:03 ` Richard Sandiford
2020-04-06 9:27 ` Richard Earnshaw (lists)
2020-04-06 11:19 ` Richard Sandiford
2020-04-06 12:22 ` Richard Biener
2020-04-08 9:10 ` Richard Sandiford
2020-04-07 9:52 ` Richard Earnshaw (lists)
2020-04-07 16:32 ` Richard Sandiford
2020-04-07 17:05 ` Richard Henderson
2020-04-07 19:43 ` Segher Boessenkool
2020-04-07 20:27 ` Segher Boessenkool
2020-04-07 21:43 ` Richard Henderson
2020-04-07 23:58 ` Segher Boessenkool
2020-04-08 0:50 ` Richard Henderson
2020-04-08 20:56 ` Segher Boessenkool
2020-04-08 9:06 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e66dbabe-059b-197e-bc3d-87121287ae39@arm.com \
--to=richard.earnshaw@arm.com \
--cc=Wilco.Dijkstra@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=marcus.shawcroft@arm.com \
--cc=richard.henderson@linaro.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).