From: Lulu Cheng <chenglulu@loongson.cn>
To: Xi Ruoyao <xry111@xry111.site>
Cc: Richard Biener <richard.guenther@gmail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Chenghua Xu <xuchenghua@loongson.cn>,
Weining Lu <luweining@loongson.cn>, Wang Xuerui <i@xen0n.name>
Subject: Re: [PATCH] loongarch: use -mno-check-zero-division as the default for optimized code
Date: Sat, 2 Jul 2022 16:35:15 +0800 [thread overview]
Message-ID: <e6737e48-ffed-5d41-fc89-835726c33387@loongson.cn> (raw)
In-Reply-To: <311645282e42983004bb8f39e53ea4211e066285.camel@xry111.site>
在 2022/7/2 下午4:24, Xi Ruoyao 写道:
> On Sat, 2022-07-02 at 15:39 +0800, Lulu Cheng wrote:
>
>> diff --git a/gcc/common/config/loongarch/loongarch-common.cc
>> b/gcc/common/config/loongarch/loongarch-common.cc
>> index b6cbd84b873..f8b4660fabf 100644
>> --- a/gcc/common/config/loongarch/loongarch-common.cc
>> +++ b/gcc/common/config/loongarch/loongarch-common.cc
>> @@ -38,7 +38,4 @@ static const struct default_options
>> loongarch_option_optimization_table[] =
>> { OPT_LEVELS_NONE, 0, NULL, 0 }
>> };
>>
>> -#undef TARGET_DEFAULT_TARGET_FLAGS
>> -#define TARGET_DEFAULT_TARGET_FLAGS MASK_CHECK_ZERO_DIV
>> -
>>
>> I think this modifications are needed, and there is no problem with the
>> rest.
> Yes, this hook is unneeded now. Though the removal is not strictly
> needed, it's good to remove irrelevant code (CWE-1164 says we shouldn't
> keep any irrelevant code).
>
> I'll commit the patch with the hook removed after another regtest on
> loongarch64-linux-gnu. I just rebuilt the entire system on my 3A5000,
> so I need some time to set it up. Expectation time to commit is today
> evening or tomorrow morning.
>
> BTW I've included this patch building my system, no bad things has
> happened so far.
Ok,Thanks!:-)
next prev parent reply other threads:[~2022-07-02 8:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 2:59 Xi Ruoyao
2022-06-30 6:55 ` Richard Biener
2022-07-02 7:39 ` Lulu Cheng
2022-07-02 8:24 ` Xi Ruoyao
2022-07-02 8:35 ` Lulu Cheng [this message]
2022-07-03 3:06 ` Xi Ruoyao
2022-07-04 6:25 ` Lulu Cheng
2022-07-04 6:55 ` Xi Ruoyao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6737e48-ffed-5d41-fc89-835726c33387@loongson.cn \
--to=chenglulu@loongson.cn \
--cc=gcc-patches@gcc.gnu.org \
--cc=i@xen0n.name \
--cc=luweining@loongson.cn \
--cc=richard.guenther@gmail.com \
--cc=xry111@xry111.site \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).