From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by sourceware.org (Postfix) with ESMTPS id 619823858D35 for ; Tue, 22 Nov 2022 20:02:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 619823858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x102d.google.com with SMTP id y14-20020a17090a2b4e00b002189a1b84d4so8879736pjc.2 for ; Tue, 22 Nov 2022 12:02:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=InVZD0PfctfJtopKSLpNE58TkIe408+nbFKMvYvj5As=; b=pyfM9Z7s2pITbOXsovvI9mLPSfdwJIa1XU2QdQJAY8+B0lmb5dqOsaetlmZL6CrCqc Q0uNCMqWaRTeEDn5aki7eOV/b5BSePk1uL0Fe51UHoA6PSJXlq7wKGCIOin1rh+eIozr P3TwgsMsO+9nLY+IBXu+Uy3919ETJREV0AeHLBivSHYvONitRmkvWI1/Eh0lj6nEMkDz vn0ZygjGaGUn+UUc/oiDDP1NY6vg0tHq2y6+dJqjdbvQciKU7V5P5Yt1bgJ659/aP8Ug 29y4CGHDu2tJCBoR5CI6ozBm8yl1ILurk5CwQxU5hejx6nv4M9niyWhC21eIMh+SvjL3 fLsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=InVZD0PfctfJtopKSLpNE58TkIe408+nbFKMvYvj5As=; b=w8NWBSwhbI2egjv27YoAd8LUY/vHWKrTWTWk71nWJOFe9sB3IUVNgqVcJ31sfFv/OZ CBa3EnLS3yPGDMJvhE3rsVi80rp3DGHa8w+lZzIEDc1m7aF9pXAsj5LxVfpTvfic7bC1 auHwKzpynBNRY7bDdnuKvfesrIKzWGEMf2/UTHDbArE+t2gYuJ5ZK079PJM69F800k9s mp2sOcatmo5uS5bnq0ajR49R7sVhBKAnmnMdAgaf7H5c7ms0SAFIqnhulrTaM8EpqysA My+uW5r5KxEqAWlQDumLXyYgsncqTzgfIkR2vTnmwRyxciYx+xV7T4EowtioWHBjC/5P XnHw== X-Gm-Message-State: ANoB5pkx2RARGhfOo/cpPH+ATB7rS42mCF64uj+8MQ3Q3hiPvBi3flV4 4GTFtXpuZWSymTVl5y/JEW4= X-Google-Smtp-Source: AA0mqf7Yv2EfpGnOzhzHliFYUgpNOTP870pnGZabkcFU7+LCYUpZRp8sEirgNnp3Y64+KOiOfqFUvQ== X-Received: by 2002:a17:903:289:b0:189:25fb:8e83 with SMTP id j9-20020a170903028900b0018925fb8e83mr7566650plr.20.1669147369306; Tue, 22 Nov 2022 12:02:49 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::99f? ([2601:681:8600:13d0::99f]) by smtp.gmail.com with ESMTPSA id c16-20020a170903235000b00186f0f59c85sm6592738plh.235.2022.11.22.12.02.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Nov 2022 12:02:48 -0800 (PST) Message-ID: Date: Tue, 22 Nov 2022 13:02:47 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH] Fix count comparison in ipa-cp Content-Language: en-US To: Eugene Rozenfeld , "gcc-patches@gcc.gnu.org" References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/21/22 14:26, Eugene Rozenfeld via Gcc-patches wrote: > The existing comparison was incorrect for non-PRECISE counts > (e.g., AFDO): we could end up with a 0 base_count, which could > lead to asserts, e.g., in good_cloning_opportunity_p. > > gcc/ChangeLog: > > * ipa-cp.cc (ipcp_propagate_stage): Fix profile count comparison. OK.  Probably somewhat painful to pull together a reliable test for this, right? Jeff