From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id 425FD3858D32 for ; Thu, 16 Nov 2023 12:45:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 425FD3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 425FD3858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=89.208.246.23 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700138727; cv=none; b=UhM4Quzksb5rUSDlzskq+AVemGZ1E4bZcTms9XiubOxe7Tlr2Bf14AkXz+3wV9Mo2PdAgQnUk2U8TXiRPyaEqYj4nxy6ScPN1AgxIh6g9ghm1O9F+7tYabo++xIQ6lSQz8D43cbmr3MN0maL/J90QfbmtuWTtQavubNGearTnxw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700138727; c=relaxed/simple; bh=Q4vqv2tB0aSBMhNYrWxgqWmuyKWMUivmwBib8/J5Y+8=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=nauaXBEeuFni89oqZJiO1HToEC+ThGPNtpkX8PLV4C4gYrGR8Up5Pb6CO8vePp4KpbjCCIys2Cju9ll60tvAQOfYoYzDfDZVxyijX2vzerOQ0m6NV9316AeGv5h0iZN7A7Q9eQw8X99rb8lpXQH5K8AbuWzRQBVT9ll2pUH791s= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1700138719; bh=Q4vqv2tB0aSBMhNYrWxgqWmuyKWMUivmwBib8/J5Y+8=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=jBkkeY4CYiQ4JdAsQToHD01Phq2AtxGDuCCVnuP6pKHwLNVNaRIMrAGQn1tSTRQnZ JYL0iSYcLn21ce0r+5O0x68KXBddCrQPEIrLEQ3Kots9tc+O76ZMpUZB5UE36rF1D+ C6KiYyn9FGS5ekddduK+4U0+jRVdvUh5BX4BzO20= Received: from [192.168.124.15] (unknown [113.200.174.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 557E066A03; Thu, 16 Nov 2023 07:45:17 -0500 (EST) Message-ID: Subject: Re: [PATCH v1] LoongArch: Implement C[LT]Z_DEFINED_VALUE_AT_ZERO From: Xi Ruoyao To: Li Wei , gcc-patches@gcc.gnu.org Cc: i@xen0n.name, xuchenghua@loongson.cn, chenglulu@loongson.cn Date: Thu, 16 Nov 2023 20:45:13 +0800 In-Reply-To: <20231116123004.3731806-1-liwei@loongson.cn> References: <20231116123004.3731806-1-liwei@loongson.cn> Autocrypt: addr=xry111@xry111.site; prefer-encrypt=mutual; keydata=mDMEYnkdPhYJKwYBBAHaRw8BAQdAsY+HvJs3EVKpwIu2gN89cQT/pnrbQtlvd6Yfq7egugi0HlhpIFJ1b3lhbyA8eHJ5MTExQHhyeTExMS5zaXRlPoiTBBMWCgA7FiEEkdD1djAfkk197dzorKrSDhnnEOMFAmJ5HT4CGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQrKrSDhnnEOPHFgD8D9vUToTd1MF5bng9uPJq5y3DfpcxDp+LD3joA3U2TmwA/jZtN9xLH7CGDHeClKZK/ZYELotWfJsqRcthOIGjsdAPuDgEYnkdPhIKKwYBBAGXVQEFAQEHQG+HnNiPZseiBkzYBHwq/nN638o0NPwgYwH70wlKMZhRAwEIB4h4BBgWCgAgFiEEkdD1djAfkk197dzorKrSDhnnEOMFAmJ5HT4CGwwACgkQrKrSDhnnEOPjXgD/euD64cxwqDIqckUaisT3VCst11RcnO5iRHm6meNIwj0BALLmWplyi7beKrOlqKfuZtCLbiAPywGfCNg8LOTt4iMD Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.1 MIME-Version: 1.0 X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,LIKELY_SPAM_FROM,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 2023-11-16 at 20:30 +0800, Li Wei wrote: > The LoongArch has defined ctz and clz on the backend, but if we want GCC > do CTZ transformation optimization in forwprop2 pass, GCC need to know > the value of c[lt]z at zero, which may be beneficial for some test cases > (like spec2017 deepsjeng_r). >=20 > After implementing the macro, we test dynamic instruction count on > deepsjeng_r: > - before 1688423249186 > - after=C2=A0 1660311215745 (1.66% reduction) LGTM, nice catch! > --- > =C2=A0gcc/config/loongarch/loongarch.h | 5 +++++ > =C2=A0gcc/testsuite/gcc.dg/pr90838.c=C2=A0=C2=A0 | 5 +++++ > =C2=A02 files changed, 10 insertions(+) >=20 > diff --git a/gcc/config/loongarch/loongarch.h b/gcc/config/loongarch/loon= garch.h > index ddac8e98ea9..115222e70fd 100644 > --- a/gcc/config/loongarch/loongarch.h > +++ b/gcc/config/loongarch/loongarch.h > @@ -1239,3 +1239,8 @@ struct GTY (()) machine_function > =C2=A0 > =C2=A0#define TARGET_EXPLICIT_RELOCS \ > =C2=A0=C2=A0 (la_opt_explicit_relocs =3D=3D EXPLICIT_RELOCS_ALWAYS) > + > +#define CLZ_DEFINED_VALUE_AT_ZERO(MODE, VALUE) \ > +=C2=A0 ((VALUE) =3D GET_MODE_UNIT_BITSIZE (MODE), 2) > +#define CTZ_DEFINED_VALUE_AT_ZERO(MODE, VALUE) \ > +=C2=A0 ((VALUE) =3D GET_MODE_UNIT_BITSIZE (MODE), 2) > diff --git a/gcc/testsuite/gcc.dg/pr90838.c b/gcc/testsuite/gcc.dg/pr9083= 8.c > index 759059683a9..40aad70499d 100644 > --- a/gcc/testsuite/gcc.dg/pr90838.c > +++ b/gcc/testsuite/gcc.dg/pr90838.c > @@ -83,3 +83,8 @@ int ctz4 (unsigned long x) > =C2=A0/* { dg-final { scan-assembler-times "ctz\t" 3 { target { rv32 } } = } } */ > =C2=A0/* { dg-final { scan-assembler-times "andi\t" 1 { target { rv32 } }= } } */ > =C2=A0/* { dg-final { scan-assembler-times "mul\t" 1 { target { rv32 } } = } } */ > + > +/* { dg-final { scan-tree-dump-times {=3D \.CTZ} 4 "forwprop2" { target = { loongarch64*-*-* } } } } */ > +/* { dg-final { scan-assembler-times "ctz.d\t" 1 { target { loongarch64*= -*-* } } } } */ > +/* { dg-final { scan-assembler-times "ctz.w\t" 3 { target { loongarch64*= -*-* } } } } */ > +/* { dg-final { scan-assembler-times "andi\t" 4 { target { loongarch64*-= *-* } } } } */ --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University