From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) by sourceware.org (Postfix) with ESMTPS id 436683887F5E for ; Fri, 7 Oct 2022 15:23:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 436683887F5E Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=acm.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qt1-x82f.google.com with SMTP id e3so2185613qts.1 for ; Fri, 07 Oct 2022 08:23:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=2VMNzGbBiRRibl+iZkv4vu1yWotfrQhaspDmCLa/7kU=; b=AtVhbEg0NLDpEzlstz3t+JzoT0baVyoKGhu7I3fi9sF667+j9WVWuNo3+pRwD+mwG1 5gXcgFG+Q5bW/GXvD5ZPOU6augk0xDcVxK2MkHAh0FdgiGFMy1jjzkdyaCpzDd7JZMjK wErEwy8Y704iQxuZMOxuzgnZSrgdKJEXPcFl+yNIDBkWUZ6JD8gjH45tyIJbBmHxZoAU wpxPOUMv6kGJzt4pxQnv90E/M0jK+8eZuYWR9pzCnI9RgqDS22lYjlcnJYZlCs310wgT /3sEi2vLEbqu7jwKF1iGK0NXCvqUXtVsoAdW58cG4qM2pnF1uHZ08FlLEpXin3pHR3Fq kDPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2VMNzGbBiRRibl+iZkv4vu1yWotfrQhaspDmCLa/7kU=; b=hLH2S1a7p3Ys20s5Ba+E8iy1Cn8Z0Iphgfrt306bbH8Kr0T/xLEt0vGGLn6uJna4c+ pIr5DDAK+CHUfEizbxZsWZZC5y0FQH4uoyUGbD9RqOQZ3LSen8O/pWr8AVcOx2d4KHIX 7TJhkATUgWWIflM7hJkblt1Ek3PKgD4fmSEUHBLPr+U9seTotEybgkGY97VOGiFb62Ih dmNQoyaQc1UHsDwVOmSCsm/WXlVCQQfd5fkPVHx5Y/R/0q++YM4RA06lz7Z59d/LQZH5 DwuaTOkHxDh+TbmB5sqzMGQxBGd3Y3VZi8uNaMTqm2wsV8ONsEthjvWMfpVUQtS3nRUW dcZg== X-Gm-Message-State: ACrzQf0p2Oyfqvvpb8CrKvoVuKNJlT5CNLjrTaEEDC6G3ojYavxrcO16 OdmVtrfpn7WziKE+6lIkH8BVOmg6O68= X-Google-Smtp-Source: AMsMyM4ps4UjSRk8T+hJvYVtUVTrIYoRTe+wovdRO0ENwOwAd0BKC9nveXxNpss4oLPpyUOnwg+Brw== X-Received: by 2002:a05:622a:1210:b0:35b:bbed:9b13 with SMTP id y16-20020a05622a121000b0035bbbed9b13mr4555578qtx.606.1665156212275; Fri, 07 Oct 2022 08:23:32 -0700 (PDT) Received: from ?IPV6:2620:10d:c0a3:1407:942e:c420:cf80:2f69? ([2620:10d:c091:500::6:7323]) by smtp.googlemail.com with ESMTPSA id i13-20020a05620a248d00b006b5e296452csm2360905qkn.54.2022.10.07.08.23.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Oct 2022 08:23:32 -0700 (PDT) Sender: Nathan Sidwell Message-ID: Date: Fri, 7 Oct 2022 11:23:31 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH] c++ modules: ICE with bitfield member in class template Content-Language: en-US To: Patrick Palka , gcc-patches@gcc.gnu.org Cc: jason@redhat.com References: <20221007150952.102429-1-ppalka@redhat.com> From: Nathan Sidwell In-Reply-To: <20221007150952.102429-1-ppalka@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3040.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/7/22 11:09, Patrick Palka wrote: > According to grokbitfield, DECL_BITFIELD_REPRESENTATIVE may "temporarily" > contain the width of the bitfield until we layout the class type (after > which it'll contain a FIELD_DECL). But for a class template, it'll always > be the width since we don't/can't layout dependent types. > > Tested on x86_64-pc-linux-gnu, does this look OK for trunk? ok, but could you add a comment on why it might not be a decl? > > gcc/cp/ChangeLog: > > * module.cc (trees_out::mark_class_def): Guard against > DECL_BITFIELD_REPRESENTATIVE not being a decl. > > gcc/testsuite/ChangeLog: > > * g++.dg/modules/bfield-3.H: New test. > --- > gcc/cp/module.cc | 3 ++- > gcc/testsuite/g++.dg/modules/bfield-3.H | 8 ++++++++ > 2 files changed, 10 insertions(+), 1 deletion(-) > create mode 100644 gcc/testsuite/g++.dg/modules/bfield-3.H > > diff --git a/gcc/cp/module.cc b/gcc/cp/module.cc > index cb1929bc5d5..172a72e92b9 100644 > --- a/gcc/cp/module.cc > +++ b/gcc/cp/module.cc > @@ -11919,7 +11919,8 @@ trees_out::mark_class_def (tree defn) > mark_class_member (member); > if (TREE_CODE (member) == FIELD_DECL) > if (tree repr = DECL_BIT_FIELD_REPRESENTATIVE (member)) > - mark_declaration (repr, false); > + if (DECL_P (repr)) > + mark_declaration (repr, false); > } > > /* Mark the binfo hierarchy. */ > diff --git a/gcc/testsuite/g++.dg/modules/bfield-3.H b/gcc/testsuite/g++.dg/modules/bfield-3.H > new file mode 100644 > index 00000000000..4fd4db7116a > --- /dev/null > +++ b/gcc/testsuite/g++.dg/modules/bfield-3.H > @@ -0,0 +1,8 @@ > +// { dg-additional-options -fmodule-header } > +// { dg-module-cmi {} } > + > +template > +struct A { > + int x : 1; > + int y : N; > +}; -- Nathan Sidwell