From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52469 invoked by alias); 3 Aug 2016 16:14:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 52459 invoked by uid 89); 3 Aug 2016 16:14:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=imaging, Hx-languages-length:1123 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 03 Aug 2016 16:14:19 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 03462C057FA6; Wed, 3 Aug 2016 16:14:18 +0000 (UTC) Received: from localhost.localdomain (ovpn-116-194.phx2.redhat.com [10.3.116.194]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u73GEH8D010272; Wed, 3 Aug 2016 12:14:17 -0400 Subject: Re: [RFC, v2] Test coverage for --param boundary values To: =?UTF-8?Q?Martin_Li=c5=a1ka?= , Joseph Myers References: <69e2f7ea-7f29-6a9a-fafe-7247d1bcf81f@suse.cz> <8760s7e57g.fsf@kepler.schwinge.homeip.net> <0c94bf32-becc-2885-61bf-2cb1d0e084a6@suse.cz> Cc: Thomas Schwinge , Jakub Jelinek , gcc-patches@gcc.gnu.org, Andreas Schwab From: Jeff Law Message-ID: Date: Wed, 03 Aug 2016 16:14:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-08/txt/msg00217.txt.bz2 On 08/01/2016 06:02 AM, Martin Liška wrote: > On 07/28/2016 11:26 PM, Joseph Myers wrote: >> On Mon, 18 Jul 2016, Martin Liška wrote: >> >>> Well, I can imaging a guard which will test whether >>> "$objdir/../../params.options" file exits, and if so, then the tests are >>> executed? Is it acceptable approach? >> >> The correct way to test for build-tree testing is [info exists >> TESTING_IN_BUILD_TREE]. When testing outside the build tree, you should >> not assume anything about directories outside of the test and source >> directories, meaning you should not test for existence of paths in >> $objdir/../ in that case. > > Thank you for the hint, I'm attaching patch. > >> >> (The preferable approach is to factor out the code generating this file so >> it can be run from the testsuite. Then you don't need to distinguish >> build-tree and other testing at all.) >> > > That would be the best approach, but I've got quite limited experience with DejaGNU, > I would postpone it and write it on my TODO list. > > May I install the suggested patch? Yes. jeff