From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 3AFFF3858D1E for ; Fri, 30 Sep 2022 19:46:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3AFFF3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664567164; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8e/R4avPRrdvEQnsk6e1HkR+JS07/XBBXb09qLnKh+A=; b=MVmqEc01NopBexxxSN1ixeP73N84AhX94cabhcxJjnNoIrpJM9LuLCJWGEBe9yGv1eouXi /7TqOM9ekD6r9tr8SidyYDZ1DWgTFdlZe0NusLrCqe3+yLM4p9u7ba+CjR4GlUSsCCZtKO XMXKPxQOo0IY0ZU6XYddDq9ThdHalSI= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-605-8oUgxNXBMxeLAy5j9ALC_w-1; Fri, 30 Sep 2022 15:46:03 -0400 X-MC-Unique: 8oUgxNXBMxeLAy5j9ALC_w-1 Received: by mail-qv1-f72.google.com with SMTP id g12-20020a0cfdcc000000b004ad431ceee0so3470389qvs.7 for ; Fri, 30 Sep 2022 12:46:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=8e/R4avPRrdvEQnsk6e1HkR+JS07/XBBXb09qLnKh+A=; b=0St1ZBGE9VLIxyXoNdssj731TJeXg6SmwP1oFOySXC/fyweTl6nA//ysF0bjuYnK/q AT6r/NBLwhqz3N/hfZWqc4WcBUZjd+RPx6ZnDm5AnX8GeSU8CJS5ebyQOSkSSrI4FkxT WqhylSGS3Fr0SYedIqJgYcB3QoRP0CnRsgWxT0Y4XSAEXn8InZqJaVYuP6jyNKdKWVCu svHwfFQJ0zWEOQeQ7mI1959nloeRV0pBJsK9Q8f1RN5749DGOQ2O3q2kHTrhfdAV10Ay uJ7S68+yBt7Q4RxXD/E2pZMUjNQjasUey6YhPP+OycFtaVVkbhggcd6xZG60HDAgmdXz kkaA== X-Gm-Message-State: ACrzQf12TaBa772nq8G8AWiN/NyYI/7hz+tnyRPBmAbzkQe2fIC79Vrc Mu8cNAWi0JK2IsDLjs9UUqMAaG1k+L3Jj03D1sc1/fmSoh+sEmxAsNnQeaEISTf4QWsVBzpjjGq g2CRKTMPasia7hRRlAg== X-Received: by 2002:a05:620a:2005:b0:6ce:3f31:e02d with SMTP id c5-20020a05620a200500b006ce3f31e02dmr7347170qka.678.1664567163038; Fri, 30 Sep 2022 12:46:03 -0700 (PDT) X-Google-Smtp-Source: AMsMyM49OH2GfKOzyORV6qlz3ZnafG/YJ8mD+f5a2l9F1wQLIz171Eu6SevuKB8LfVuTiGUK4eA6wg== X-Received: by 2002:a05:620a:2005:b0:6ce:3f31:e02d with SMTP id c5-20020a05620a200500b006ce3f31e02dmr7347155qka.678.1664567162770; Fri, 30 Sep 2022 12:46:02 -0700 (PDT) Received: from [192.168.1.101] (130-44-159-43.s15913.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.159.43]) by smtp.gmail.com with ESMTPSA id v19-20020a05622a131300b0031e9ab4e4cesm2889641qtk.26.2022.09.30.12.46.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Sep 2022 12:46:02 -0700 (PDT) Message-ID: Date: Fri, 30 Sep 2022 15:46:01 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [PATCH] c++: make some cp_trait_kind switch statements exhaustive To: Patrick Palka Cc: gcc-patches@gcc.gnu.org References: <20220930172019.1459433-1-ppalka@redhat.com> <5dacc85d-d972-aed1-fac4-a325c5422a50@idea> From: Jason Merrill In-Reply-To: <5dacc85d-d972-aed1-fac4-a325c5422a50@idea> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/30/22 13:37, Patrick Palka wrote: > > On Fri, 30 Sep 2022, Patrick Palka wrote: > >> This replaces the unreachable default case in some cp_trait_kind >> switches with an exhaustive listing of the _unexpected_ trait codes, >> so that when adding a new trait we'll get a -Wswitch diagnostic if we >> forget to handle the trait code in one of these switches. >> >> Bootstrappend and regtested on x86_64-pc-linux-gnu, does this look OK >> for trunk? >> >> gcc/cp/ChangeLog: >> >> * semantics.cc (trait_expr_value): Make cp_trait_kind switch >> exhaustive. >> (finish_trait_expr): Likewise. >> (finish_trait_type): Likewise. >> --- >> gcc/cp/semantics.cc | 31 +++++++++++++++++++++++++------ >> 1 file changed, 25 insertions(+), 6 deletions(-) >> >> diff --git a/gcc/cp/semantics.cc b/gcc/cp/semantics.cc >> index 66ee2186a84..91ad8aa340f 100644 >> --- a/gcc/cp/semantics.cc >> +++ b/gcc/cp/semantics.cc >> @@ -12052,10 +12052,15 @@ trait_expr_value (cp_trait_kind kind, tree type1, tree type2) >> case CPTK_REF_CONVERTS_FROM_TEMPORARY: >> return ref_xes_from_temporary (type1, type2, /*direct_init=*/false); >> >> - default: >> - gcc_unreachable (); >> - return false; >> +#define DEFTRAIT_TYPE(CODE, NAME, ARITY) \ >> + case CPTK_##CODE: >> +#include "cp-trait.def" >> +#undef DEFTRAIT_EXPR > > Whoops, this should be #undef DEFTRAIT_TYPE OK with that fix. >> + /* These are handled by finish_trait_type. */ >> + break; >> } >> + >> + gcc_unreachable (); >> } >> >> /* Returns true if TYPE meets the requirements for the specified KIND, >> @@ -12204,7 +12209,11 @@ finish_trait_expr (location_t loc, cp_trait_kind kind, tree type1, tree type2) >> return error_mark_node; >> break; >> >> - default: >> +#define DEFTRAIT_TYPE(CODE, NAME, ARITY) \ >> + case CPTK_##CODE: >> +#include "cp-trait.def" >> +#undef DEFTRAIT_TYPE >> + /* These are handled by finish_trait_type. */ >> gcc_unreachable (); >> } >> >> @@ -12250,9 +12259,19 @@ finish_trait_type (cp_trait_kind kind, tree type1, tree type2) >> if (TYPE_REF_P (type1)) >> type1 = TREE_TYPE (type1); >> return cv_unqualified (type1); >> - default: >> - gcc_unreachable (); >> + >> +#define DEFTRAIT_EXPR(CODE, NAME, ARITY) \ >> + case CPTK_##CODE: >> +#include "cp-trait.def" >> +#undef DEFTRAIT_EXPR >> + /* These are handled by finish_trait_expr. */ >> + case CPTK_BASES: >> + case CPTK_DIRECT_BASES: >> + /* These are handled by finish_bases. */ >> + break; >> } >> + >> + gcc_unreachable (); >> } >> >> /* Do-nothing variants of functions to handle pragma FLOAT_CONST_DECIMAL64, >> -- >> 2.38.0.rc2 >> >> >