public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <law@redhat.com>
To: Bernd Edlinger <bernd.edlinger@hotmail.de>,
	"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	Richard Biener <rguenther@suse.de>
Subject: Re: [PATCH] Fix PR 91605
Date: Tue, 03 Sep 2019 18:47:00 -0000	[thread overview]
Message-ID: <e71f18a2-3691-6ae5-fc04-be0a26310c50@redhat.com> (raw)
In-Reply-To: <AM6PR10MB2566BA1FAF5CB117AD8FF512E4B90@AM6PR10MB2566.EURPRD10.PROD.OUTLOOK.COM>

On 9/3/19 12:46 PM, Bernd Edlinger wrote:
> On 9/3/19 8:40 PM, Jeff Law wrote:
>> On 9/1/19 4:36 AM, Bernd Edlinger wrote:
>>> Hi,
>>>
>>> this fixes an oversight in r274986.
>>> We need to avoid using movmisalign on DECL_P which are not in memory,
>>> similar to the !mem_ref_refers_to_non_mem_p which unfortunately can't
>>> handle DECL_P.
>>>
>>>
>>> Bootstrapped and reg-tested on x86_64-pc-linux-gnu.
>>> Is it OK for trunk?
>>>
>>>
>>> Thanks
>>> Bernd.
>>>
>>>
>>> patch-pr91605.diff
>>>
>>> 2019-09-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
>>>
>>> 	PR middle-end/91605
>>> 	* expr.c (expand_assignment): Avoid DECL_P with DECL_RTL
>>> 	not being MEM_P.
>>>
>>> testsuite:
>>> 2019-09-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
>>>
>>> 	PR middle-end/91605
>>> 	* g++.target/i386/pr91605.C: New test.
>> OK.
>> Jeff
>>
> 
> Thanks Jeff,
> 
> but I have already applied a slightly improved patch which
> has approved by Richi:
> 
> https://gcc.gnu.org/ml/gcc-patches/2019-09/msg00059.html
OK.  Go with that one instead :-)  I'd looked at that one too, noticed
the ChangeLog didn't seem to match the patch well and set it aside to
dig further into.

jeff

      reply	other threads:[~2019-09-03 18:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-01 10:36 Bernd Edlinger
2019-09-02  7:50 ` Richard Biener
2019-09-02 14:02   ` Bernd Edlinger
2019-09-02 14:04     ` Richard Biener
2019-09-03 18:40 ` Jeff Law
2019-09-03 18:46   ` Bernd Edlinger
2019-09-03 18:47     ` Jeff Law [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e71f18a2-3691-6ae5-fc04-be0a26310c50@redhat.com \
    --to=law@redhat.com \
    --cc=bernd.edlinger@hotmail.de \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).