From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73654 invoked by alias); 29 Jun 2017 14:47:10 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 73629 invoked by uid 89); 29 Jun 2017 14:47:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-yw0-f174.google.com Received: from mail-yw0-f174.google.com (HELO mail-yw0-f174.google.com) (209.85.161.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Jun 2017 14:47:06 +0000 Received: by mail-yw0-f174.google.com with SMTP id 63so37952589ywr.0 for ; Thu, 29 Jun 2017 07:47:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:to:from:subject:message-id:date :user-agent:mime-version:content-language; bh=U8F/I8wpUJaJRk5qZtinx4YNMUg/fdYhpbmMy6Oe+YY=; b=E8vi7r7trFFPITi0nY5VjDfCo3yZ+9A/yo8VFVLjAU+NLQE5ij2bj3B7TEkzUQ001Q 9acvciS/fktdeNUeOas/H4TDkvyjGFzundpilPtny9HW56xwG3uPE6rbXSCvVEU/rtk/ qIzuALnIo5oerSvmSETj6PipFEhUdZ3HnEZbfJTvmAYuyMeRnTmad/JtzkEFJhD0hO5M s0L6soSUlkerODiyvEXGFCC+5rskz6pt9S0Q2XvyuAMB2967wsVdSk7iZ85dUkbFZJGn QvlCBM20FhZI8pnQ/TnCc4Q5dEl1PVrB/WwSAjas5iWNChooOgXJ1xvez9GP+Cb+IiMP Kmig== X-Gm-Message-State: AKS2vOzXQBel3UhgzUEl0u5AtAUwIv6kcDxT71Fgm9MpE6TtMZKuYFuE YoRWeK26rmdNqw== X-Received: by 10.129.164.21 with SMTP id b21mr12899514ywh.255.1498747624989; Thu, 29 Jun 2017 07:47:04 -0700 (PDT) Received: from ?IPv6:2620:10d:c0a3:20fb:7500:e7fb:4a6f:2254? ([2620:10d:c091:200::1:9018]) by smtp.googlemail.com with ESMTPSA id z10sm1561032ywg.11.2017.06.29.07.47.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Jun 2017 07:47:04 -0700 (PDT) To: GCC Patches From: Nathan Sidwell Subject: [C++ PATCH] maybe_add_lang_type_raw simplification Message-ID: Date: Thu, 29 Jun 2017 14:47:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------696F63EA2C8F0B5346ED43C9" X-SW-Source: 2017-06/txt/msg02285.txt.bz2 This is a multi-part message in MIME format. --------------696F63EA2C8F0B5346ED43C9 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-length: 154 I found maybe_add_lang_type_raw benefitted from simply returning false early, rather than use a bool flag. applied to trunk. nathan -- Nathan Sidwell --------------696F63EA2C8F0B5346ED43C9 Content-Type: text/x-patch; name="lex.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="lex.diff" Content-length: 1204 2017-06-29 Nathan Sidwell * lex.c (maybe_add_lang_type_raw): Exit early, rather than use a flag. Index: lex.c =================================================================== --- lex.c (revision 249779) +++ lex.c (working copy) @@ -741,21 +741,21 @@ copy_type (tree type MEM_STAT_DECL) static bool maybe_add_lang_type_raw (tree t) { - bool add = (RECORD_OR_UNION_CODE_P (TREE_CODE (t)) - || TREE_CODE (t) == BOUND_TEMPLATE_TEMPLATE_PARM); - if (add) - { - TYPE_LANG_SPECIFIC (t) - = (struct lang_type *) (ggc_internal_cleared_alloc - (sizeof (struct lang_type))); + if (!(RECORD_OR_UNION_CODE_P (TREE_CODE (t)) + || TREE_CODE (t) == BOUND_TEMPLATE_TEMPLATE_PARM)) + return false; + + TYPE_LANG_SPECIFIC (t) + = (struct lang_type *) (ggc_internal_cleared_alloc + (sizeof (struct lang_type))); - if (GATHER_STATISTICS) - { - tree_node_counts[(int)lang_type] += 1; - tree_node_sizes[(int)lang_type] += sizeof (struct lang_type); - } + if (GATHER_STATISTICS) + { + tree_node_counts[(int)lang_type] += 1; + tree_node_sizes[(int)lang_type] += sizeof (struct lang_type); } - return add; + + return true; } tree --------------696F63EA2C8F0B5346ED43C9--