From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12f.google.com (mail-il1-x12f.google.com [IPv6:2607:f8b0:4864:20::12f]) by sourceware.org (Postfix) with ESMTPS id 23EFB385773F for ; Thu, 1 Jun 2023 14:52:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 23EFB385773F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-il1-x12f.google.com with SMTP id e9e14a558f8ab-33b4b70693eso3804305ab.1 for ; Thu, 01 Jun 2023 07:52:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685631174; x=1688223174; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Nxx2VGAixtULm+4eYH3KEevsqO0zKnGMk+oL/RypSBE=; b=JIxJI4hpypTZhLLf19REw7B6IHZ8e7k+5f82epi7CDIYSD3zMXGS9aDMqnmwONY9DW jTLa2UUX3E1gvuAXBFaZWZyH+KI5RfxTT9wpftpIIkWoVZSNdcjH+891s+XPABXxnVBT OoadwC8zi3mdd9JF8AxzHrgIkRcyAYamJThlboU2MRLpKWDZnR+nr1lItO8R5/yKHBpn oidjiVAS7tL6nc0sdFaLjBhgL22rixF7X5UozfAQdobLqsX85EMMnZ7GxyrxoUUMG0KY EWylxInrAokzFgZ+sFuO4qvT5uvMTF26ohtzk8ADazVkH1VR9X84kTa4d8B6shnOnGa4 FnRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685631174; x=1688223174; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Nxx2VGAixtULm+4eYH3KEevsqO0zKnGMk+oL/RypSBE=; b=erLUjjKWHP9bSRScB7BkcvxCYkuPS4p4qHmc9r9NR9rWaxey/1NzK2XcrvODwOuSPl 5qMqrKrQEFk2q+AF+hyEPhmi/KmxwIVBs4H5rBD6HZc4vS5iCc8F9e1/91fODG7TXEux iwSZENdxncwryz+CLve5rzJVsOLNRw4SR2fGkx+5fgFoSD3nlEX+4ckXzljTNqqHO1/Y MJ/AIN++vbeDbHo3AiNWibEJ4/CjElJBhRIAdn1TLGAs7Fp7N5X2UWajUCn7RFJUgrEZ fyOrlrTs2zetTOU1tHieh214N3VWQbWUOiyXVz7/JRcpbtZ6CpEVmmBPyidZ045ENU5R 4JHw== X-Gm-Message-State: AC+VfDxUKOVvwVlwQnZV+hGGoYwbb0opeluwNtfiunOs+tngwaVrebBC cv4uPSeSvnc6F1vQL3yWmOw= X-Google-Smtp-Source: ACHHUZ4ZULTnVHS12DXBxZM/l2zLDoMOFTsD+1GBS7FLw25x/ndFCeaxUf8lAUue+YcJiegLOyOlpQ== X-Received: by 2002:a92:db4b:0:b0:325:eb13:1045 with SMTP id w11-20020a92db4b000000b00325eb131045mr6596120ilq.2.1685631174226; Thu, 01 Jun 2023 07:52:54 -0700 (PDT) Received: from ?IPV6:2601:681:8d00:265::f0a? ([2601:681:8d00:265::f0a]) by smtp.gmail.com with ESMTPSA id cv4-20020a056638498400b0041659b1e2afsm2367671jab.14.2023.06.01.07.52.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Jun 2023 07:52:53 -0700 (PDT) Message-ID: Date: Thu, 1 Jun 2023 08:52:52 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 1/3] testsuite: Unbork multilib testing on RISC-V (and any target really) Content-Language: en-US To: Vineet Gupta , gcc-patches@gcc.gnu.org Cc: kito.cheng@gmail.com, Palmer Dabbelt , Philipp Tomsich , Christoph Mullner , gnu-toolchain@rivosinc.com References: <20230531162534.119952-1-vineetg@rivosinc.com> <20230531162534.119952-2-vineetg@rivosinc.com> From: Jeff Law In-Reply-To: <20230531162534.119952-2-vineetg@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/31/23 10:25, Vineet Gupta wrote: > Multilib testing on trunk is currently busted (and surprisingly this > affects any/all targets but it seems nobody cares). We currently get the > following splat: > > | ERROR: tcl error code NONE > | ERROR: torture-init: torture_without_loops is not empty as expected > > And this takes down pretty much all of testsuite. > > | ========= Summary of gcc testsuite ========= > | | # of unexpected case / # of unique unexpected case > | | gcc | g++ | gfortran | > | rv64imafdc/ lp64d/ medlow | 5421 / 4 | 1 / 1 | 72 / 12 | > | rv32imafdc/ ilp32d/ medlow | 5422 / 5 | 3 / 2 | 72 / 12 | > | rv32imac/ ilp32/ medlow | 391 / 5 | 3 / 2 | 109 / 19 | > | rv64imac/ lp64/ medlow | 5422 / 5 | 1 / 1 | 109 / 19 | > > There have been recent improvements in test harness around pairing of > torture-{init,finish} and checking for leaking torture options. This > however triggers a latent bug introduced way back in 2009: commit 3dd1415dc88 > "i386-prefetch.exp: Skip tests when multilib flags contain -march" which > missed a pairing torture-finish. It was benign so far but in the new > regime it causes extra state "torture-init-done" confusing the 2nd round of > tests (in multilib). > > This fix moves the early exit outside of torture-{init,finish} bracket > and brings RISC-V testing back to sanity. > > | rv64imafdc/ lp64d/ medlow | 3 / 2 | 1 / 1 | 72 / 12 | > | rv32imafdc/ ilp32d/ medlow | 4 / 3 | 3 / 2 | 72 / 12 | > | rv32imac/ ilp32/ medlow | 3 / 2 | 3 / 2 | 109 / 19 | > | rv64imac/ lp64/ medlow | 5 / 4 | 1 / 1 | 109 / 19 | > > gcc/testsuite: > * gcc.misc-tests/i386-prefetch.exp: Move early return outside > the torture-{init,finish} OK after addressing Thomas's comments which I think just amounted to moving the code to a different place and adjusting the comments in the commit message. jeff