From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 3800A3858D35 for ; Wed, 28 Jun 2023 23:36:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3800A3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687995406; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fV603HUKBDNlv70HkgyS2OPMmhBgt1z05g9rJ/pTOl0=; b=LPJSdk5vFmeZxKjukdWVH6ywwEwOZFxhbFanluAA7mYdSjpiOEtVRojuaxM6QU0HQlTFVt w08ehsqHFBOs9bJ+gXYJJJa8Umyde+11E9bCPPzYTTxpqfYxocP6A6yN+ZSQ3uckmx7EZO hsIIE07FjmdJXtx8/oR53jfgHlWb3bU= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-288-vjdiivXAOgKsD2vWnMkA3Q-1; Wed, 28 Jun 2023 19:36:45 -0400 X-MC-Unique: vjdiivXAOgKsD2vWnMkA3Q-1 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4032e14e9c5so1233971cf.1 for ; Wed, 28 Jun 2023 16:36:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687995405; x=1690587405; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fV603HUKBDNlv70HkgyS2OPMmhBgt1z05g9rJ/pTOl0=; b=k0RJHT5I/CgIZbevGUURIol15eSxkptPPBR5MgIMXQTGl3qsOfYbmB1rHei5hP5enD agmplzHYFHF8Hg9UbRdRjVttAbDF9sCqoTxaAgfchNkVZlGoxODPwsEeL2qr41XrCBlU MqIporOMWpuz4d1pXY5ex2w+QPYHy+4qwxZVr2iXM4WpExDhCsLlWoN6eLoFT0cJvjlb RzStwg764g3CLlCwaKjC1yDShUZanaT18xX+QEKSuyQ2Anf4nkK3aET+P9twha5Vd3Fc 5AcyNcVCi+B80ZzbmNiSSLMHIzTDQ2Tpvf4xn4tTAQG1NBwhe7yxxuM4GrVXNRC7dtko yKUg== X-Gm-Message-State: AC+VfDxsPpFFNb9TH0AYHQqVomPo1cu6NwcpxNNewwLtZCB/uZz/8XRz 3MBXMlbwTqUBsslhUAOU/fT2mTlAGKUt7EIu1rxpUqJmAI24mMXaBNiMe6eubTFMs8ymhYSYScv p/YLt9XpjJoGX0yxTGA== X-Received: by 2002:a05:622a:20b:b0:3f4:dec2:76cc with SMTP id b11-20020a05622a020b00b003f4dec276ccmr38037202qtx.49.1687995404759; Wed, 28 Jun 2023 16:36:44 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4u8diYqmXzLHVxipiRN/0f3k0TuxNKDBHY3LbrWgllpKYLpS59BpxlA1PAgtGAcY+A7fWD2w== X-Received: by 2002:a05:622a:20b:b0:3f4:dec2:76cc with SMTP id b11-20020a05622a020b00b003f4dec276ccmr38037185qtx.49.1687995404418; Wed, 28 Jun 2023 16:36:44 -0700 (PDT) Received: from t14s.localdomain (c-76-28-97-5.hsd1.ma.comcast.net. [76.28.97.5]) by smtp.gmail.com with ESMTPSA id cj25-20020a05622a259900b00401e04c66fesm3731357qtb.37.2023.06.28.16.36.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jun 2023 16:36:44 -0700 (PDT) Message-ID: Subject: Re: [PATCH] analyzer: Fix regression bug after r14-1632-g9589a46ddadc8b [pr110198] From: David Malcolm To: priour.be@gmail.com, gcc-patches@gcc.gnu.org Date: Wed, 28 Jun 2023 19:36:42 -0400 In-Reply-To: <20230622195522.1834793-1-vultkayn@gcc.gnu.org> References: <20230622195522.1834793-1-vultkayn@gcc.gnu.org> User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 2023-06-22 at 21:55 +0200, priour.be@gmail.com wrote: > From: benjamin priour >=20 > Resend with proper subject line ... >=20 > Hi, Hi Benjamin >=20 > Below is the fix to regression bug > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D110198 > Was bootstrapped and regtested successfully on x86_64-linux-gnu > Considering mishap from last patch, I'd would appreciate if you could > also regtest it, to be sure :) I tried this, but it didn't apply cleanly to my working copy. Which version of master was this against / when did you last rebase this? I see in comment #5 of PR 110198 that the results have been changing. [...snip...] > g++.dg/analyzer/pr100244.C was failing after a patch of PR109439. > The reason was a spurious preemptive return of get_store_value upon out-o= f-bounds read that > was preventing further checks. Now instead, a boolean value check_poisone= d goes to false when > a OOB is detected, and is later on given to get_or_create_initial_value. >=20 > gcc/analyzer/ChangeLog: >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0* region-model-manager.cc= (region_model_manager::get_or_create_initial_value): Take an > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0optional boolean value to bypass poisoning checks > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0* region-model-manager.h:= Update declaration of the above function. > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0* region-model.cc (region= _model::get_store_value): No longer > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0returns on OOB, but rather gives a boolean to get_o= r_create_initial_value. > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0(region_model::check_regi= on_access): Update docstring. > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0(region_model::check_regi= on_for_write): Update docstring. Something's gone a bit wrong with the formatting of the ChangeLog entries. Ideally they shouldn't go wider than 74 columns, so they need a few newlines. Also, some of the lines have too many leading tabs. [...snip...] The content of the patch itself looks reasonable. Thanks Dave