From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 782E938582BA for ; Fri, 8 Jul 2022 13:41:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 782E938582BA Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-590-hvLhpc9FNaafE_zmyVNTkQ-1; Fri, 08 Jul 2022 09:41:55 -0400 X-MC-Unique: hvLhpc9FNaafE_zmyVNTkQ-1 Received: by mail-qt1-f200.google.com with SMTP id q21-20020ac84115000000b0031bf60d9b35so18358531qtl.4 for ; Fri, 08 Jul 2022 06:41:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=bwV+NWaEnzvCCWrePV6w+4FHjckjD5x7ihNcnGtEqLA=; b=zMLf7W66JOUymqujHu7fXT3gyN4Xo1/MmFGHeXOQ3y9XMbfXvoNcwi1HWu6c2OrlLk CNH7PS63QSljDPWCGwVqtZxYIotWP4cE0eOWrK+g/CR62hwO5F5wviChr0I2RV7nD/uu W6zX8cYkT+e6ZOXiz5f7zTH2YVTzVkKlXmjIpWNQrO/pUyqz4APKzsl8Az4DTUWWDV8b eDB4bgJUKnCtgE1Gczlq0W0PZA+h6rItv9VOZFkM8lYzHRFEJXNNCCyJl2T8ZOKGxi5X Ocd3S2F8rMOT0lZxpSP8hGI2dTx1vPO1fYYXi5jsPS/J3NYCQm8edXAWPzYiPmHZHpNf yWgQ== X-Gm-Message-State: AJIora9tDz4zLj2U/bRL0TpZ5lYIEr1ZipSYX7vBfsOBz30qkb03LKZw t8mKv0hMU6zT0BAUTU4xzWfzbGlHsNYnNPqqOX7RjF5N77HJkbC91XzD15Udj4RCKIbKDaIZLid 255kn0+Irt9yBReqg5w== X-Received: by 2002:a05:622a:138d:b0:319:a288:44a5 with SMTP id o13-20020a05622a138d00b00319a28844a5mr3036331qtk.338.1657287713233; Fri, 08 Jul 2022 06:41:53 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t9GH7YZSOLSobRpqLx5fkhftOwlqNwaSMk2r5Fp1Le/MNpmIH5mee/3xBWJfCN/AQx42vh5g== X-Received: by 2002:a05:622a:138d:b0:319:a288:44a5 with SMTP id o13-20020a05622a138d00b00319a28844a5mr3036186qtk.338.1657287711691; Fri, 08 Jul 2022 06:41:51 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.ma.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id w20-20020a05620a445400b006af37b005bdsm29041051qkp.128.2022.07.08.06.41.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jul 2022 06:41:51 -0700 (PDT) Message-ID: Subject: Re: [PATCH] diagnostics: Make line-ending logic consistent with libcpp [PR91733] From: David Malcolm To: Lewis Hyatt , gcc-patches@gcc.gnu.org Date: Fri, 08 Jul 2022 09:41:50 -0400 In-Reply-To: <20220708015614.GA90703@ldh-imac.local> References: <20220708015614.GA90703@ldh-imac.local> User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jul 2022 13:41:58 -0000 On Thu, 2022-07-07 at 21:56 -0400, Lewis Hyatt wrote: > Hello- > > The PR (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91733) points > out that, > while libcpp recognizes a lone '\r' as a valid line-ending character, > the > infrastructure that obtains source lines to be printed in diagnostics > does > not, and hence diagnostics do not output the intended portion of a > source > file that uses such line endings. The PR's author suggests that > libcpp > should stop accepting '\r' line endings, but that seems rather > controversial > and not likely to change. Fixing the diagnostics is easy enough > though, and > that's done by the attached patch. Please let me know if it looks OK, > thanks! bootstrap + regtest all languages looks good, with just new > PASSes > for the new testcase. > > FAIL 103 103 > PASS 543592 543627 > UNSUPPORTED 15298 15298 > UNTESTED 136 136 > XFAIL 4130 4130 > XPASS 20 20 > The patch looks good to me. Thanks Dave