From: Jeff Law <jeffreyalaw@gmail.com>
To: Maxim Blinov <maxim.blinov@embecosm.com>, gcc-patches@gcc.gnu.org
Cc: iain@sandoe.co.uk, Andrew Burgess <andrew.burgess@embecosm.com>
Subject: Re: [PATCH 3/4] Add aarch64-linux support for off-stack trampolines
Date: Thu, 2 Dec 2021 20:20:31 -0700 [thread overview]
Message-ID: <e8009e9f-9d23-276a-ecd5-38e35f2d4647@gmail.com> (raw)
In-Reply-To: <20211113094525.96299-3-maxim.blinov@embecosm.com>
On 11/13/2021 2:45 AM, Maxim Blinov wrote:
> Implement the __builtin_nested_func_ptr_{created,deleted} functions
> for the aarch64-linux platform. This serves to exercise the
> infrastructure added in libgcc (--enable-off-stack-trampolines) and
> gcc (-foff-stack-trampolines) in supporting off-stack trampoline
> generation, and is intended primarily for demonstration and debugging
> purposes.
>
> Co-authored-by: Andrew Burgess <andrew.burgess@embecosm.com>
>
> libgcc/ChangeLog:
>
> * config/aarch64/heap-trampoline.c: New file: Implement off-stack
> trampolines for aarch64.
> * config/aarch64/t-heap-trampoline: Add rule to build
> config/aarch64/heap-trampoline.c
> * config.host (aarch64-*-linux*): Handle
> --enable-off-stack-trampolines.
> * configure.ac (--enable-off-stack-trampolines): Permit setting
> for target aarch64-*-linux*.
> * configure: Regenerate.
I'd leave this to the aarch64 maintainers. I don't see anything
particularly bad. I'd probably drop the all the configure time
selectability stuff and just have the aarch64 darwin default to this
implementation if the basic concept goes forward.
jeff
next prev parent reply other threads:[~2021-12-03 3:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-13 9:45 [PATCH 1/4] Generate off-stack nested function trampolines Maxim Blinov
2021-11-13 9:45 ` [PATCH 2/4] Add x86_64-linux support for off-stack trampolines Maxim Blinov
2021-12-03 3:18 ` Jeff Law
2021-11-13 9:45 ` [PATCH 3/4] Add aarch64-linux " Maxim Blinov
2021-12-03 3:20 ` Jeff Law [this message]
2021-11-13 9:45 ` [PATCH 4/4] Add aarch64-darwin " Maxim Blinov
2021-11-22 14:49 ` [PATCH 0/4] " Maxim Blinov
2021-12-03 3:12 ` Jeff Law
2021-12-03 7:53 ` Iain Sandoe
2021-12-03 17:08 ` Jeff Law
2021-11-16 0:19 ` [PATCH 1/4] Generate off-stack nested function trampolines Joseph Myers
2021-12-03 3:17 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8009e9f-9d23-276a-ecd5-38e35f2d4647@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=andrew.burgess@embecosm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=iain@sandoe.co.uk \
--cc=maxim.blinov@embecosm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).