public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <jeffreyalaw@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>,
	Iain Sandoe <iain@sandoe-acoustics.co.uk>
Cc: Jan Hubicka <jh@suse.cz>,
	gcc-patches@gcc.gnu.org, Nathan Sidwell <nathan@acm.org>
Subject: Re: [PATCH] libgcov: Fix build on Darwin [PR99406]
Date: Sat, 6 Mar 2021 07:43:21 -0700	[thread overview]
Message-ID: <e812879b-da71-f0b8-6d68-7024d8aba821@gmail.com> (raw)
In-Reply-To: <20210305204143.GL745611@tucnak>



On 3/5/21 1:41 PM, Jakub Jelinek via Gcc-patches wrote:
> On Fri, Mar 05, 2021 at 04:19:47PM +0000, Iain Sandoe wrote:
>> Jakub Jelinek via Gcc-patches <gcc-patches@gcc.gnu.org> wrote:
>>
>>> As reported, bootstrap currently fails on older Darwin because
>>> MAP_ANONYMOUS
>>> is not defined.
>>>
>>> The following is what gcc/system.h does, so I think it should work for
>>> libgcov.
>>> Build tested on x86_64-linux, ok for trunk?
>> bootstrap suceeded r11-7524 + this patch on Darwin11.
> And bootstrap/regtest succeeded on x86_64-linux and i686-linux too.
>
>>> 2021-03-05  Jakub Jelinek  <jakub@redhat.com>
>>>
>>> 	PR gcov-profile/99406
>>> 	* libgcov.h (MAP_FAILED, MAP_ANONYMOUS): If HAVE_SYS_MMAN_H is
>>> 	defined, define these macros if not defined already.
OK
jeff


      reply	other threads:[~2021-03-06 14:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-05 14:00 Jakub Jelinek
2021-03-05 16:19 ` Iain Sandoe
2021-03-05 20:41   ` Jakub Jelinek
2021-03-06 14:43     ` Jeff Law [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e812879b-da71-f0b8-6d68-7024d8aba821@gmail.com \
    --to=jeffreyalaw@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=iain@sandoe-acoustics.co.uk \
    --cc=jakub@redhat.com \
    --cc=jh@suse.cz \
    --cc=nathan@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).