From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 21DCD3858C53 for ; Thu, 2 Feb 2023 14:59:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 21DCD3858C53 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.97,267,1669104000"; d="diff'?scan'208";a="96696082" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 02 Feb 2023 06:59:47 -0800 IronPort-SDR: CvDnJgo87Jo6D1HcAPIrRdpXrD+NrK1JjUe9Nz9Z09VWQyTKU+FmrFCYlK6RI1tQsieEFQMSam CDF1OrIGmuaklBdZ3Wv3M1CT4oGkoCk5WAwXJ5uiz2LXHCuZrwoIUIv8WdUe8F3zp63V8lO9gj RML0yrh88hIZSRED+AXEAL0cXqLc5LA4T/Y29Pg7ebc7EXj8WMX6kWpSs/EI09fP8BaXmNAgx8 Qe+YUiTirYVHPeLDQct/WtZJpnq3VAEZUBIprS28qu0QvsD+IsPfqGM7n31INrTPkDF+8GYUsa Zc0= Content-Type: multipart/mixed; boundary="------------42FvSUL7KeWvxFFnBgNB7X1a" Message-ID: Date: Thu, 2 Feb 2023 15:59:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [Patch] libgomp: enable reverse offload for AMDGCN Content-Language: en-US From: Tobias Burnus To: gcc-patches , Jakub Jelinek , Andrew Stubbs References: In-Reply-To: X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --------------42FvSUL7KeWvxFFnBgNB7X1a Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable Maybe it becomes better reviewable with an attached patch ... On 02.02.23 15:31, Tobias Burnus wrote: > Now that the stack handling has been changed for AMDGCN, this patch > enables reverse offload. > (cf. today's "[committed] amdgcn, libgomp: Manually allocated stacks" > patch email/commit > by Andrew). > > Any comments, suggestions? > > Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955 --------------42FvSUL7KeWvxFFnBgNB7X1a Content-Type: text/x-patch; charset="UTF-8"; name="gcn-offload-v2.diff" Content-Disposition: attachment; filename="gcn-offload-v2.diff" Content-Transfer-Encoding: base64 bGliZ29tcDogZW5hYmxlIHJldmVyc2Ugb2ZmbG9hZCBmb3IgQU1ER0NOCgpsaWJnb21wL0No YW5nZUxvZzoKCgkqIGxpYmdvbXAudGV4aSAoNS4wIEltcGwuIFN0YXR1cywgZ2NuIHNwZWNp Zmljcyk6IFVwZGF0ZSBmb3IKCXJldmVyc2Ugb2ZmbG9hZC4KCSogcGx1Z2luL3BsdWdpbi1n Y24uYyAoR09NUF9PRkZMT0FEX2dldF9udW1fZGV2aWNlcyk6IEFjY2VwdAoJcmV2ZXJzZS1v ZmZsb2FkIHJlcXVpcmVtZW50LgoKIGxpYmdvbXAvbGliZ29tcC50ZXhpICAgICAgICB8IDEz ICsrKysrKysrLS0tLS0KIGxpYmdvbXAvcGx1Z2luL3BsdWdpbi1nY24uYyB8ICAzICsrLQog MiBmaWxlcyBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL2xpYmdvbXAvbGliZ29tcC50ZXhpIGIvbGliZ29tcC9saWJnb21wLnRleGkK aW5kZXggMWY4NGIwNTBlYjIuLjY5OGFlMzMwOTQyIDEwMDY0NAotLS0gYS9saWJnb21wL2xp YmdvbXAudGV4aQorKysgYi9saWJnb21wL2xpYmdvbXAudGV4aQpAQCAtMjI3LDggKzIyNyw3 IEBAIFRoZSBPcGVuTVAgNC41IHNwZWNpZmljYXRpb24gaXMgZnVsbHkgc3VwcG9ydGVkLgog QGl0ZW0gQGNvZGV7YWxsb2NhdGV9IGRpcmVjdGl2ZSBAdGFiIE4gQHRhYgogQGl0ZW0gQGNv ZGV7YWxsb2NhdGV9IGNsYXVzZSBAdGFiIFAgQHRhYiBJbml0aWFsIHN1cHBvcnQKIEBpdGVt IEBjb2Rle3VzZV9kZXZpY2VfYWRkcn0gY2xhdXNlIG9uIEBjb2Rle3RhcmdldCBkYXRhfSBA dGFiIFkgQHRhYgotQGl0ZW0gQGNvZGV7YW5jZXN0b3J9IG1vZGlmaWVyIG9uIEBjb2Rle2Rl dmljZX0gY2xhdXNlCi0gICAgICBAdGFiIFkgQHRhYiBIb3N0IGZhbGxiYWNrIHdpdGggR0NO IGRldmljZXMKK0BpdGVtIEBjb2Rle2FuY2VzdG9yfSBtb2RpZmllciBvbiBAY29kZXtkZXZp Y2V9IGNsYXVzZSBAdGFiIFkgQHRhYgogQGl0ZW0gSW1wbGljaXQgZGVjbGFyZSB0YXJnZXQg ZGlyZWN0aXZlIEB0YWIgWSBAdGFiCiBAaXRlbSBEaXNjb250aWd1b3VzIGFycmF5IHNlY3Rp b24gd2l0aCBAY29kZXt0YXJnZXQgdXBkYXRlfSBjb25zdHJ1Y3QKICAgICAgIEB0YWIgTiBA dGFiCkBAIC00NDU1LDkgKzQ0NTQsMTMgQEAgVGhlIGltcGxlbWVudGF0aW9uIHJlbWFyazoK IEBpdGVtIEkvTyB3aXRoaW4gT3Blbk1QIHRhcmdldCByZWdpb25zIGFuZCBPcGVuQUNDIHBh cmFsbGVsL2tlcm5lbHMgaXMgc3VwcG9ydGVkCiAgICAgICB1c2luZyB0aGUgQyBsaWJyYXJ5 IEBjb2Rle3ByaW50Zn0gZnVuY3Rpb25zIGFuZCB0aGUgRm9ydHJhbgogICAgICAgQGNvZGV7 cHJpbnR9L0Bjb2Rle3dyaXRlfSBzdGF0ZW1lbnRzLgotQGl0ZW0gT3Blbk1QIGNvZGUgdGhh dCBoYXMgYSByZXF1aXJlcyBkaXJlY3RpdmUgd2l0aCBAY29kZXt1bmlmaWVkX2FkZHJlc3N9 LAotICAgICAgQGNvZGV7dW5pZmllZF9zaGFyZWRfbWVtb3J5fSBvciBAY29kZXtyZXZlcnNl X29mZmxvYWR9IHdpbGwgcmVtb3ZlCi0gICAgICBhbnkgR0NOIGRldmljZSBmcm9tIHRoZSBs aXN0IG9mIGF2YWlsYWJsZSBkZXZpY2VzIChgYGhvc3QgZmFsbGJhY2snJykuCitAaXRlbSBS ZXZlcnNlIG9mZmxvYWQgKGkuZS4gQGNvZGV7dGFyZ2V0fSByZWdpb25zIHdpdGgKKyAgICAg IEBjb2Rle2RldmljZShhbmNlc3RvcjoxKX0pIGFyZSBwcm9jZXNzZWQgc2VyaWFsbHkgcGVy IEBjb2Rle3RhcmdldH0gcmVnaW9uCisgICAgICBzdWNoIHRoYXQgdGhlIG5leHQgcmV2ZXJz ZSBvZmZsb2FkIHJlZ2lvbiBpcyBvbmx5IGV4ZWN1dGVkIGFmdGVyIHRoZSBwcmV2aW91cwor ICAgICAgb25lIHJldHVybmVkLgorQGl0ZW0gT3Blbk1QIGNvZGUgdGhhdCBoYXMgYSByZXF1 aXJlcyBkaXJlY3RpdmUgd2l0aCBAY29kZXt1bmlmaWVkX2FkZHJlc3N9IG9yCisgICAgICBA Y29kZXt1bmlmaWVkX3NoYXJlZF9tZW1vcnl9IHdpbGwgcmVtb3ZlIGFueSBHQ04gZGV2aWNl IGZyb20gdGhlIGxpc3Qgb2YKKyAgICAgIGF2YWlsYWJsZSBkZXZpY2VzIChgYGhvc3QgZmFs bGJhY2snJykuCiBAZW5kIGl0ZW1pemUKIAogCmRpZmYgLS1naXQgYS9saWJnb21wL3BsdWdp bi9wbHVnaW4tZ2NuLmMgYi9saWJnb21wL3BsdWdpbi9wbHVnaW4tZ2NuLmMKaW5kZXggYTdi MzUwNTlhYjMuLjExY2U2YjBmYThkIDEwMDY0NAotLS0gYS9saWJnb21wL3BsdWdpbi9wbHVn aW4tZ2NuLmMKKysrIGIvbGliZ29tcC9wbHVnaW4vcGx1Z2luLWdjbi5jCkBAIC0zMjYyLDcg KzMyNjIsOCBAQCBHT01QX09GRkxPQURfZ2V0X251bV9kZXZpY2VzICh1bnNpZ25lZCBpbnQg b21wX3JlcXVpcmVzX21hc2spCiAgICAgcmV0dXJuIDA7CiAgIC8qIFJldHVybiAtMSBpZiBu byBvbXBfcmVxdWlyZXNfbWFzayBjYW5ub3QgYmUgZnVsZmlsbGVkIGJ1dAogICAgICBkZXZp Y2VzIHdlcmUgcHJlc2VudC4gICovCi0gIGlmIChoc2FfY29udGV4dC5hZ2VudF9jb3VudCA+ IDAgJiYgb21wX3JlcXVpcmVzX21hc2sgIT0gMCkKKyAgaWYgKGhzYV9jb250ZXh0LmFnZW50 X2NvdW50ID4gMAorICAgICAgJiYgKG9tcF9yZXF1aXJlc19tYXNrICYgfkdPTVBfUkVRVUlS RVNfUkVWRVJTRV9PRkZMT0FEKSAhPSAwKQogICAgIHJldHVybiAtMTsKICAgcmV0dXJuIGhz YV9jb250ZXh0LmFnZW50X2NvdW50OwogfQo= --------------42FvSUL7KeWvxFFnBgNB7X1a--