From: Patrick O'Neill <patrick@rivosinc.com>
To: Juzhe-Zhong <juzhe.zhong@rivai.ai>, gcc-patches@gcc.gnu.org
Subject: Re: [Committed V2] RISC-V: Fix VSETVL PASS bug
Date: Wed, 6 Dec 2023 12:08:04 -0800 [thread overview]
Message-ID: <e882160a-b0cc-44dd-93cd-41108cd1016c@rivosinc.com> (raw)
In-Reply-To: <20231206142646.3402479-1-juzhe.zhong@rivai.ai>
Hi Juzhe,
An assert added in this patch is firing on a testcase on rv64gcv:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112888
Thanks,
Patrick
On 12/6/23 06:26, Juzhe-Zhong wrote:
> As PR112855 mentioned, the VSETVL PASS insert vsetvli in unexpected location.
>
> Due to 2 reasons:
> 1. incorrect transparant computation LCM data. We need to check VL operand defs and uses.
> 2. incorrect fusion of unrelated edge which is the edge never reach the vsetvl expression.
>
> PR target/112855
>
> gcc/ChangeLog:
>
> * config/riscv/riscv-vsetvl.cc (pre_vsetvl::compute_lcm_local_properties): Fix transparant LCM data.
> (pre_vsetvl::earliest_fuse_vsetvl_info): Disable earliest fusion for unrelated edge.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/riscv/rvv/autovec/pr112855.c: New test.
prev parent reply other threads:[~2023-12-06 20:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 14:26 Juzhe-Zhong
2023-12-06 20:08 ` Patrick O'Neill [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e882160a-b0cc-44dd-93cd-41108cd1016c@rivosinc.com \
--to=patrick@rivosinc.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=juzhe.zhong@rivai.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).