From: Jason Merrill <jason@redhat.com>
To: "Martin Liška" <mliska@suse.cz>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] C++: target attribute - local decl
Date: Tue, 16 Mar 2021 16:12:15 -0400 [thread overview]
Message-ID: <e8b753a7-4213-81e7-6de2-d085d4676076@redhat.com> (raw)
In-Reply-To: <3982b6fb-4533-9680-5998-694686ccd549@suse.cz>
On 3/8/21 4:33 AM, Martin Liška wrote:
> On 3/4/21 9:54 PM, Jason Merrill wrote:
>> On 3/4/21 10:52 AM, Martin Liška wrote:
>>> On 3/4/21 4:45 PM, Jason Merrill wrote:
>>>>
>>>> Sure, I guess you do need to set that flag for the local decls, but
>>>> that should be all.
>>>>
>>>> Jason
>>>
>>> Doing that also fails :/
>>> This time likely due to how we set RECORD argument of
>>> maybe_version_functions function:
>>>
>>> gcc/cp/decl.c: && maybe_version_functions (newdecl, olddecl,
>>> gcc/cp/decl.c-
>>> (!DECL_FUNCTION_VERSIONED (newdecl)
>>> gcc/cp/decl.c- ||
>>> !DECL_FUNCTION_VERSIONED (olddecl))))
>>
>> That is odd.
>>
>> The other problem is that DECL_LOCAL_DECL_ALIAS isn't always set
>> before we get to maybe_version_functions; it's set further down in
>> do_pushdecl. We need it to be set or things break.
>
> Oh, I see.
>
>>
>> This seems to work for me, what do you think?
>
> Seems good to me, please apply the patch.
Done.
Jason
prev parent reply other threads:[~2021-03-16 20:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 12:15 Martin Liška
2021-02-22 22:53 ` Jason Merrill
2021-03-01 12:43 ` Martin Liška
2021-03-01 16:36 ` Jason Merrill
2021-03-01 16:59 ` Martin Liška
2021-03-01 19:58 ` Jason Merrill
2021-03-02 10:34 ` Martin Liška
2021-03-02 17:57 ` Jason Merrill
2021-03-04 8:19 ` Martin Liška
2021-03-04 15:03 ` Jason Merrill
2021-03-04 15:39 ` Martin Liška
2021-03-04 15:45 ` Jason Merrill
2021-03-04 15:52 ` Martin Liška
2021-03-04 20:54 ` Jason Merrill
2021-03-08 9:33 ` Martin Liška
2021-03-16 20:12 ` Jason Merrill [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8b753a7-4213-81e7-6de2-d085d4676076@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).