From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id B47E23858D32 for ; Fri, 13 Jan 2023 10:53:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B47E23858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=foss.arm.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=foss.arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8C5DDFEC; Fri, 13 Jan 2023 02:54:29 -0800 (PST) Received: from [10.2.78.76] (e126323.cambridge.arm.com [10.2.78.76]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C38F53F587; Fri, 13 Jan 2023 02:53:46 -0800 (PST) Message-ID: Date: Fri, 13 Jan 2023 10:53:45 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 3/9] arm: Don't add crtfastmath.o for -shared Content-Language: en-GB To: Richard Biener , gcc-patches@gcc.gnu.org Cc: richard.earnshaw@arm.com References: <20230113080015.6E41613913@imap2.suse-dmz.suse.de> From: Richard Earnshaw In-Reply-To: <20230113080015.6E41613913@imap2.suse-dmz.suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3495.6 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,NICE_REPLY_A,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 13/01/2023 08:00, Richard Biener via Gcc-patches wrote: > Don't add crtfastmath.o for -shared to avoid altering the FP > environment when loading a shared library. > > PR target/55522 > * config/arm/linux-eabi.h (ENDFILE_SPEC): Don't add > crtfastmath.o for -shared. > * config/arm/unknown-elf.h (STARTFILE_SPEC): Likewise. OK. R. > --- > gcc/config/arm/linux-eabi.h | 2 +- > gcc/config/arm/unknown-elf.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gcc/config/arm/linux-eabi.h b/gcc/config/arm/linux-eabi.h > index 57f830f0176..a119875599d 100644 > --- a/gcc/config/arm/linux-eabi.h > +++ b/gcc/config/arm/linux-eabi.h > @@ -121,7 +121,7 @@ > > #undef ENDFILE_SPEC > #define ENDFILE_SPEC \ > - "%{Ofast|ffast-math|funsafe-math-optimizations:crtfastmath.o%s} " \ > + "%{Ofast|ffast-math|funsafe-math-optimizations:%{!shared:crtfastmath.o%s}} " \ > LINUX_OR_ANDROID_LD (GNU_USER_TARGET_ENDFILE_SPEC, ANDROID_ENDFILE_SPEC) > > /* Use the default LIBGCC_SPEC, not the version in linux-elf.h, as we > diff --git a/gcc/config/arm/unknown-elf.h b/gcc/config/arm/unknown-elf.h > index 464d38b6cc6..397ac3f68b9 100644 > --- a/gcc/config/arm/unknown-elf.h > +++ b/gcc/config/arm/unknown-elf.h > @@ -33,7 +33,7 @@ > > #undef STARTFILE_SPEC > #define STARTFILE_SPEC \ > - "%{Ofast|ffast-math|funsafe-math-optimizations:crtfastmath.o%s} " \ > + "%{Ofast|ffast-math|funsafe-math-optimizations:%{!shared:crtfastmath.o%s}} " \ > UNKNOWN_ELF_STARTFILE_SPEC > > #define UNKNOWN_ELF_ENDFILE_SPEC "crtend%O%s crtn%O%s"