From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 0D55A3858032 for ; Wed, 19 Jan 2022 09:33:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0D55A3858032 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E54B12177B; Wed, 19 Jan 2022 09:33:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1642584820; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2MOnRPbrGTjfi5RVqGGwqMOJxuUtR/Ksy83bQiVNs9E=; b=DosSkp0HMr8EjATcnokUMfxH2XZjQEE49z2kOfhVeTPnobon2eN9uvT1SuCe2d2ZbxZJsw VNPEHWL44I+QaW0NeJhDcOfcqmcsHQdYyDqnK1ZhmWmAp6vLaxg+stJMD/ylp9mf2aDFtz 48uYdtue/vAXUsoa0ntFoglL/M87zQ8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1642584820; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2MOnRPbrGTjfi5RVqGGwqMOJxuUtR/Ksy83bQiVNs9E=; b=Z8I01wYqO1DRZAmM+M4lpwZ0FvqBuyjItz0zXlFnslMaZDGJyt+JdE5o2BU2c12D6YybT3 EAUyt3JWOztaedBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D03A713E11; Wed, 19 Jan 2022 09:33:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 72esMfTa52GKKAAAMHmgww (envelope-from ); Wed, 19 Jan 2022 09:33:40 +0000 Content-Type: multipart/mixed; boundary="------------0M1rFImWygdTOdBR0V7sWCrY" Message-ID: Date: Wed, 19 Jan 2022 10:33:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] riscv: fix -Wformat-diag errors. Content-Language: en-US To: Joseph Myers Cc: gcc-patches@gcc.gnu.org References: <3f0a77b3-734b-8d37-29bd-5ba7e7b086a8@suse.cz> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jan 2022 09:33:43 -0000 This is a multi-part message in MIME format. --------------0M1rFImWygdTOdBR0V7sWCrY Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/18/22 23:00, Joseph Myers wrote: > On Tue, 18 Jan 2022, Martin Liška wrote: > >> @@ -3309,8 +3309,8 @@ riscv_handle_type_attribute (tree *node >> ATTRIBUTE_UNUSED, tree name, tree args, >> && strcmp (string, "machine")) >> { >> warning (OPT_Wattributes, >> - "argument to %qE attribute is not \"user\", >> \"supervisor\", or \"machine\"", >> - name); >> + "argument to %qE attribute is not %, >> %, " >> + "or %", name); >> *no_add_attrs = true; > > My reading is that the attribute arguments here are string constants, not > identifiers - that is, the ASCII double quotes are correct in the > diagnostic output, because those double quotes are part of the literal > text that's supposed to appear in the program. (Maybe %<\"user\"%> is the > right way of marking it up to indicate that the double quotes are part of > the literal program text, not English-level quoting.) Makes sense, I' going to install the following patch. Martin --------------0M1rFImWygdTOdBR0V7sWCrY Content-Type: text/x-patch; charset=UTF-8; name="0001-Update-on-riscv-Wformat-diag-string.patch" Content-Disposition: attachment; filename="0001-Update-on-riscv-Wformat-diag-string.patch" Content-Transfer-Encoding: base64 RnJvbSBmZGYzMWFlMjVmNjZjZDQ4NmU2NTVkN2ViZGEzNjgyNjAyNWI5ZDBlIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gTGlza2EgPG1saXNrYUBzdXNlLmN6PgpE YXRlOiBXZWQsIDE5IEphbiAyMDIyIDEwOjMyOjEzICswMTAwClN1YmplY3Q6IFtQQVRDSF0g VXBkYXRlIG9uIHJpc2N2IC1XZm9ybWF0LWRpYWcgc3RyaW5nLgoKZ2NjL0NoYW5nZUxvZzoK CgkqIGNvbmZpZy9yaXNjdi9yaXNjdi5jYyAocmlzY3ZfaGFuZGxlX3R5cGVfYXR0cmlidXRl KToKCVVwZGF0ZSBvbmUgLVdmb3JtYXQtZGlhZyBzdHJpbmcgaW4gd2FybmluZyBtZXNzYWdl LgotLS0KIGdjYy9jb25maWcvcmlzY3YvcmlzY3YuY2MgfCA0ICsrLS0KIDEgZmlsZSBjaGFu Z2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZ2Nj L2NvbmZpZy9yaXNjdi9yaXNjdi5jYyBiL2djYy9jb25maWcvcmlzY3YvcmlzY3YuY2MKaW5k ZXggODMxNDg2NGQ1ZTcuLjY4ODViNGJiYWQyIDEwMDY0NAotLS0gYS9nY2MvY29uZmlnL3Jp c2N2L3Jpc2N2LmNjCisrKyBiL2djYy9jb25maWcvcmlzY3YvcmlzY3YuY2MKQEAgLTMzMDks OCArMzMwOSw4IEBAIHJpc2N2X2hhbmRsZV90eXBlX2F0dHJpYnV0ZSAodHJlZSAqbm9kZSBB VFRSSUJVVEVfVU5VU0VELCB0cmVlIG5hbWUsIHRyZWUgYXJncywKIAkgICAgICAmJiBzdHJj bXAgKHN0cmluZywgIm1hY2hpbmUiKSkKIAkgICAgewogCSAgICAgIHdhcm5pbmcgKE9QVF9X YXR0cmlidXRlcywKLQkJICAgICAgICJhcmd1bWVudCB0byAlcUUgYXR0cmlidXRlIGlzIG5v dCAlPHVzZXIlPiwgJTxzdXBlcnZpc29yJT4sICIKLQkJICAgICAgICJvciAlPG1hY2hpbmUl PiIsIG5hbWUpOworCQkgICAgICAgImFyZ3VtZW50IHRvICVxRSBhdHRyaWJ1dGUgaXMgbm90 ICU8XCJ1c2VyXCIlPiwgJTxcInN1cGVydmlzb3JcIiU+LCAiCisJCSAgICAgICAib3IgJTxc Im1hY2hpbmVcIiU+IiwgbmFtZSk7CiAJICAgICAgKm5vX2FkZF9hdHRycyA9IHRydWU7CiAJ ICAgIH0KIAl9Ci0tIAoyLjM0LjEKCg== --------------0M1rFImWygdTOdBR0V7sWCrY--