From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111649 invoked by alias); 17 Nov 2016 17:59:19 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 111550 invoked by uid 89); 17 Nov 2016 17:59:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=242519, learn X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 Nov 2016 17:59:08 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6273A8FCEF; Thu, 17 Nov 2016 17:59:07 +0000 (UTC) Received: from localhost.localdomain (ovpn-116-64.phx2.redhat.com [10.3.116.64]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAHHx6Mu014006; Thu, 17 Nov 2016 12:59:06 -0500 Subject: Re: Ping: Re: [PATCH 1/2] gcc: Remove unneeded global flag. To: Andrew Burgess , Mike Stump References: <512a967c-39c4-44f5-6f24-d75ef543979d@redhat.com> <20160629192130.GF8823@embecosm.com> <20160914130048.GC31794@embecosm.com> <03bef940-2b86-af7d-d2d2-b96b8283596f@redhat.com> <20161116200930.GG5975@embecosm.com> <20161116221217.GH5975@embecosm.com> Cc: Bernd Schmidt , gcc-patches@gcc.gnu.org, Jakub Jelinek From: Jeff Law Message-ID: Date: Thu, 17 Nov 2016 17:59:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161116221217.GH5975@embecosm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg01837.txt.bz2 On 11/16/2016 03:12 PM, Andrew Burgess wrote: > * Mike Stump [2016-11-16 12:59:53 -0800]: > >> On Nov 16, 2016, at 12:09 PM, Andrew Burgess wrote: >>> My only remaining concern is the new tests, I've tried to restrict >>> them to targets that I suspect they'll pass on with: >>> >>> /* { dg-final-use { scan-assembler "\.section\[\t \]*\.text\.unlikely\[\\n\\r\]+\[\t \]*\.size\[\t \]*foo\.cold\.0" { target *-*-linux* *-*-gnu* } } } */ >>> >>> but I'm still nervous that I'm going to introduce test failures. Is >>> there any advice / guidance I should follow before I commit, or are >>> folk pretty relaxed so long as I've made a reasonable effort? >> >> So, if you are worried about the way the line is constructed, I usually test it by misspelling the *-*-linux* *-*-gnu* part as *-*-linNOTux* *-*-gnNOTu* and see if the test then doesn't run on your machine. If it doesn't then you can be pretty confident that only machines that match the target triplet can be impacted. I usually do this type of testing by running the test case in isolation (not the full tests suite). Anyway, do the best you can, and don't worry about t it too much, learn from the experience, even if it goes wrong in some way. If it did go wrong, just be responsive (don't check it in just before a 6 week vacation) about fixing it, if you can. >> > > Thanks for the feedback. > > Change committed as revision 242519. If anyone sees any issues just > let me know. Thanks. And thanks for seeing this through... I know it's a pain sometimes. jeff