From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 577F038582AF for ; Mon, 13 Jun 2022 18:30:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 577F038582AF Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-517-oZStQW5uNwa_041eaDvKnQ-1; Mon, 13 Jun 2022 14:30:09 -0400 X-MC-Unique: oZStQW5uNwa_041eaDvKnQ-1 Received: by mail-qv1-f70.google.com with SMTP id 7-20020a0562140d0700b0046bd3ff4a9dso4379600qvh.10 for ; Mon, 13 Jun 2022 11:30:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=0lc2TgJKndh+mC01CMbT665RIWedA/neAf1ffh+ORTo=; b=C/rxh9esNWf5BUgam87FXDrqgRbTe2ixDsSDg9Qs+hENkKXOweFEH61wbPlvVOzNpF fkgCVrU8WlQgNVcg0qsGhiQgbTZ3ubvK6UqjW6EKZl+nucZxMzarziYb2j1KAXn3wUbh lQts4lbBewT3NiUJwaVpwk+7q4uJh+j0LBdima1ZD9BmDkoJYcRDE2jPEneOKifhL+OP 8fxOvb7EDtje6/dU1cuLR3wskQSKIKf2sOWiC420DHSo/GV8qCW3NOqrZ/qUppvjeG68 yaLrr1l0rkh6+gr59QEQJPWQOI0sXS4Z0ANQN2glXIsqWgIfm6I4AD5Y7qFqUe/z955v vu2g== X-Gm-Message-State: AOAM532CBKYay6NPxSWzWXBPIKU52TX7Zhl90i4mXdhCdWHrFYEvvnJK 66CENKELekTN4SQAtK4kWUCcpUEScXKesH8nTSO29RSA07ZU3C8i00jTRCsmTUkaKHypcvgudO8 cUyjSzXubZ9E2KXONgdoc0GCdPC8l6DMZo0OufHuoKC7PGNHXYD49yCguXZNIdnGVWYvJQQ== X-Received: by 2002:ac8:4e81:0:b0:304:fea7:882d with SMTP id 1-20020ac84e81000000b00304fea7882dmr933849qtp.371.1655145007897; Mon, 13 Jun 2022 11:30:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4xsZLyyp/6pkzcgVIHI4YH7Ohk+oll+yYn3dO/DbPUqtxWatPaVLQvbg2P1BljCy6QS1H9w== X-Received: by 2002:ac8:4e81:0:b0:304:fea7:882d with SMTP id 1-20020ac84e81000000b00304fea7882dmr933818qtp.371.1655145007399; Mon, 13 Jun 2022 11:30:07 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.ma.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id bi13-20020a05620a318d00b006a6dcd92eb3sm6938233qkb.121.2022.06.13.11.30.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jun 2022 11:30:06 -0700 (PDT) Message-ID: Subject: PING: Re: [PATCH 08/10] i386: add 'final' and 'override' to scalar_chain vfunc impls From: David Malcolm To: gcc-patches@gcc.gnu.org Date: Mon, 13 Jun 2022 14:30:05 -0400 In-Reply-To: <20220523192834.3785673-9-dmalcolm@redhat.com> References: <20220523192834.3785673-1-dmalcolm@redhat.com> <20220523192834.3785673-9-dmalcolm@redhat.com> User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jun 2022 18:30:11 -0000 Ping for this patch: https://gcc.gnu.org/pipermail/gcc-patches/2022-May/595440.html OK for trunk? Thanks Dave On Mon, 2022-05-23 at 15:28 -0400, David Malcolm wrote: > gcc/ChangeLog: >         * config/i386/i386-features.h: Add "final" and "override" to >         scalar_chain vfunc implementations as appropriate. > > Signed-off-by: David Malcolm > --- >  gcc/config/i386/i386-features.h | 16 ++++++++-------- >  1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/gcc/config/i386/i386-features.h b/gcc/config/i386/i386- > features.h > index 5c307607ae5..f46a6d95b74 100644 > --- a/gcc/config/i386/i386-features.h > +++ b/gcc/config/i386/i386-features.h > @@ -169,18 +169,18 @@ class general_scalar_chain : public scalar_chain >   public: >    general_scalar_chain (enum machine_mode smode_, enum machine_mode > vmode_); >    ~general_scalar_chain (); > -  int compute_convert_gain (); > +  int compute_convert_gain () final override; >   private: >    hash_map defs_map; >    bitmap insns_conv; >    unsigned n_sse_to_integer; >    unsigned n_integer_to_sse; > -  void mark_dual_mode_def (df_ref def); > -  void convert_insn (rtx_insn *insn); > +  void mark_dual_mode_def (df_ref def) final override; > +  void convert_insn (rtx_insn *insn) final override; >    void convert_op (rtx *op, rtx_insn *insn); >    void convert_reg (rtx_insn *insn, rtx dst, rtx src); >    void make_vector_copies (rtx_insn *, rtx); > -  void convert_registers (); > +  void convert_registers () final override; >    int vector_const_cost (rtx exp); >  }; >   > @@ -190,14 +190,14 @@ class timode_scalar_chain : public scalar_chain >    timode_scalar_chain () : scalar_chain (TImode, V1TImode) {} >   >    /* Convert from TImode to V1TImode is always faster.  */ > -  int compute_convert_gain () { return 1; } > +  int compute_convert_gain () final override { return 1; } >   >   private: > -  void mark_dual_mode_def (df_ref def); > +  void mark_dual_mode_def (df_ref def) final override; >    void fix_debug_reg_uses (rtx reg); > -  void convert_insn (rtx_insn *insn); > +  void convert_insn (rtx_insn *insn) final override; >    /* We don't convert registers to difference size.  */ > -  void convert_registers () {} > +  void convert_registers () final override {} >  }; >   >  } // anon namespace