public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: David Malcolm <dmalcolm@redhat.com>
To: Jonathan Wakely <jwakely@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] doc: Improve punctuation and grammar in -fdiagnostics-format docs
Date: Mon, 29 Jul 2024 15:12:17 -0400	[thread overview]
Message-ID: <e99da356ce7dc69b851a6378c2c194316147b17f.camel@redhat.com> (raw)
In-Reply-To: <20240315130309.2915229-1-jwakely@redhat.com>

On Fri, 2024-03-15 at 13:02 +0000, Jonathan Wakely wrote:
> OK for trunk?

LGTM, thanks

Dave

> 
> -- >8 --
> 
> The hyphen can be misunderstood to mean "emitted to -" i.e. stdout.
> Refer to both forms by name, rather than using "the former" for one
> and
> referring to the other by name.
> 
> gcc/ChangeLog:
> 
>         * doc/invoke.texi (Diagnostic Message Formatting Options):
>         Replace hyphen with a new sentence. Replace "the former" with
>         the actual value.
> ---
>  gcc/doc/invoke.texi | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
> index 85c938d4a14..d850b5fcdcc 100644
> --- a/gcc/doc/invoke.texi
> +++ b/gcc/doc/invoke.texi
> @@ -5737,8 +5737,9 @@ named @file{@var{source}.sarif}, respectively.
>  
>  The @samp{json} format is a synonym for @samp{json-stderr}.
>  The @samp{json-stderr} and @samp{json-file} formats are identical,
> apart from
> -where the JSON is emitted to - with the former, the JSON is emitted
> to stderr,
> -whereas with @samp{json-file} it is written to
> @file{@var{source}.gcc.json}.
> +where the JSON is emitted to.  With @samp{json-stderr}, the JSON is
> emitted
> +to stderr, whereas with @samp{json-file} it is written to
> +@file{@var{source}.gcc.json}.
>  
>  The emitted JSON consists of a top-level JSON array containing JSON
> objects
>  representing the diagnostics.




      parent reply	other threads:[~2024-07-29 19:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-15 13:02 Jonathan Wakely
2024-07-29 12:00 ` Jonathan Wakely
2024-07-29 19:12 ` David Malcolm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e99da356ce7dc69b851a6378c2c194316147b17f.camel@redhat.com \
    --to=dmalcolm@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jwakely@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).