From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id E881F3858408 for ; Mon, 29 Jul 2024 19:12:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E881F3858408 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E881F3858408 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1722280343; cv=none; b=MojbWGP5wq3s6/HdbFNYPikO3PukKFnFjjVwt22m0ykVCdQyy+eqLv1gAkVTqz6QmdSefKZhAfTpFRHM+pIIQ/tB8tn19zBsHg3x4d+Xe2ysolwh7O1oJUfKieMExmpyf+wlJWZBnyLk+ZIi6gYSHD4DEFEO+iMGM4YNf9B6aps= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1722280343; c=relaxed/simple; bh=skFAuTTBDdLr3zPu+pmjHgQlZz579DaridJw4cR08ac=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=tEctKBac6R7xmuN04rFdKMTvRn51fZVF+s8zHfSv6gf5Vu5K57rvEPD3IgmdQ3RIYeIxRz1x6LHwGNZYWeP9NMxLTO4d7yQHK0QC7WzVf3SJt+z4kjhxThgTeKfxVNjatoRR+UkiBmgjNlnffWzOpjVOBwGvlhaPmQfG/7WCd7o= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722280341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=skFAuTTBDdLr3zPu+pmjHgQlZz579DaridJw4cR08ac=; b=dQpLvC3TqpHuQKez4A9hmsbSF+0783BbOD6myVMmY6KMjAOQC9NB4/To7BTh+0sfmvskdW TFQtcw0eQ8PY3InqAjjJbNtJKdkbgQ1qjtKlZ40Pn1laRS3KcpnbseVNz8FeYivezcirHI dkywEX1VPHaAO+AGMGlSe46t9oMTzUA= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-427-7iIyr9YsOHSVTiz7BrND2w-1; Mon, 29 Jul 2024 15:12:20 -0400 X-MC-Unique: 7iIyr9YsOHSVTiz7BrND2w-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6b79170baf3so53631336d6.3 for ; Mon, 29 Jul 2024 12:12:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722280339; x=1722885139; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=skFAuTTBDdLr3zPu+pmjHgQlZz579DaridJw4cR08ac=; b=ppjvSgoUmZQ/q2skqPq5dAXrTSKZl6HfrVR7QsoBCqgDulrbYpHKyUZUGcvrfOrGaU Oq+N2EfIvagv/FG2OkcMXFwEPA0+2DFe7ElWSCc/KrytsEUVuToeSmyiRO0AB5EUk3kh xcZkZAn4B66IUqKo2Slw56H2Clhz+kEYnLrDQZdwavK+GzCAhyapHEQz+bc8ywHJY7eI Jns5+q8tu/Ev+8T6yQ/OBfCoT0djWCUUTxNpa9wmQT4WsWVMpJQWbSlaZd7v/RbbiDnp 3osYynEhGCxK0ehbLUqlfDL9XK0zWF8D10E92RjBLEAz7Cr3dBxOTgjxi3f1vrVUtswP XWGw== X-Forwarded-Encrypted: i=1; AJvYcCVeuEoeYcKfhzjfu2xeTy71qbL807RPZ/YJR9d+o0l+A1rCBOSeKQaSCcF8fFGbINbcTHYVxTnTn6uLdzNs+faTXrIfN/Ec9Q== X-Gm-Message-State: AOJu0YzOXomVbdagbNboEHebxBVBuhX+dkHnVRMjmUfg9NCH/CnZ7b2V nyKrpZFSWrhfOy4J+5nX050zL1BRZDUDOJbbEfvqVK8KSlfNi5cVzLujXM3buh3XAChxtfyZFM1 V9ulzgzk99GdknrT1xMaGMSk7njLE3oxMAud5YX5nBkMMiTLzxRUiBRC2n3xAVq4= X-Received: by 2002:a05:620a:40c4:b0:7a1:c40d:7573 with SMTP id af79cd13be357-7a1e52ea2d8mr1142490185a.49.1722280339343; Mon, 29 Jul 2024 12:12:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHtOtDsCbNpCu5L8wkun+RRlerJIxD0JDQ0EXi4aNTR6pqzNoRyBSLN0PZpsoeuBQzphlRIsA== X-Received: by 2002:a05:620a:40c4:b0:7a1:c40d:7573 with SMTP id af79cd13be357-7a1e52ea2d8mr1142488485a.49.1722280338992; Mon, 29 Jul 2024 12:12:18 -0700 (PDT) Received: from t14s.localdomain (c-76-28-97-5.hsd1.ma.comcast.net. [76.28.97.5]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a1f49dbb80sm129257585a.103.2024.07.29.12.12.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jul 2024 12:12:18 -0700 (PDT) Message-ID: Subject: Re: [PATCH] doc: Improve punctuation and grammar in -fdiagnostics-format docs From: David Malcolm To: Jonathan Wakely , gcc-patches@gcc.gnu.org Date: Mon, 29 Jul 2024 15:12:17 -0400 In-Reply-To: <20240315130309.2915229-1-jwakely@redhat.com> References: <20240315130309.2915229-1-jwakely@redhat.com> User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 2024-03-15 at 13:02 +0000, Jonathan Wakely wrote: > OK for trunk? LGTM, thanks Dave >=20 > -- >8 -- >=20 > The hyphen can be misunderstood to mean "emitted to -" i.e. stdout. > Refer to both forms by name, rather than using "the former" for one > and > referring to the other by name. >=20 > gcc/ChangeLog: >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0* doc/invoke.texi (Diagno= stic Message Formatting Options): > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Replace hyphen with a new= sentence. Replace "the former" with > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0the actual value. > --- > =C2=A0gcc/doc/invoke.texi | 5 +++-- > =C2=A01 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi > index 85c938d4a14..d850b5fcdcc 100644 > --- a/gcc/doc/invoke.texi > +++ b/gcc/doc/invoke.texi > @@ -5737,8 +5737,9 @@ named @file{@var{source}.sarif}, respectively. > =C2=A0 > =C2=A0The @samp{json} format is a synonym for @samp{json-stderr}. > =C2=A0The @samp{json-stderr} and @samp{json-file} formats are identical, > apart from > -where the JSON is emitted to - with the former, the JSON is emitted > to stderr, > -whereas with @samp{json-file} it is written to > @file{@var{source}.gcc.json}. > +where the JSON is emitted to.=C2=A0 With @samp{json-stderr}, the JSON is > emitted > +to stderr, whereas with @samp{json-file} it is written to > +@file{@var{source}.gcc.json}. > =C2=A0 > =C2=A0The emitted JSON consists of a top-level JSON array containing JSON > objects > =C2=A0representing the diagnostics.