From: Jason Merrill <jason@redhat.com>
To: Paolo Carlini <paolo.carlini@oracle.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [C++ Patch] Fix some simple location issues
Date: Tue, 07 Jun 2016 19:40:00 -0000 [thread overview]
Message-ID: <e9be4321-07c1-fd2c-5c45-cdb44bcafcf1@redhat.com> (raw)
In-Reply-To: <5756F060.3020609@oracle.com>
For diagnostics about an initializer, I think it would be better to give
the location of the initializer rather than the declaration. Maybe use
location_t loc = EXPR_LOC_OR_LOC (init, DECL_SOURCE_LOCATION (decl));
?
Jason
next prev parent reply other threads:[~2016-06-07 19:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 16:04 Paolo Carlini
2016-06-07 19:40 ` Jason Merrill [this message]
2016-06-07 22:50 ` Paolo Carlini
2016-06-08 18:39 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9be4321-07c1-fd2c-5c45-cdb44bcafcf1@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=paolo.carlini@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).