From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id AC2D53858C36 for ; Thu, 29 Feb 2024 13:28:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AC2D53858C36 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AC2D53858C36 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::62d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709213341; cv=none; b=vPNfq0kx7RHBncPXO5799DECP2sl/GGRAfab7uevcDmZv3Emmguv6r+zFTqFAAnEgDOdE4GbSIoBN146BSqB881SoBslnhVt+VQijpnI9kAz5tEWxaJU2Qc+q6DS8mb2moSqPd8aGq9fxB0w1jo7vNUrNZw3QHBH/5A0ihdc3Hs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709213341; c=relaxed/simple; bh=EjDlGOyieG3DQ3spm1bzySzpTzIY9w9Xl8NVgU465YU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=e87vK6PcJ3uHdlWeOpBKrTsfDFwcvJP8ghzF13YXJh7QaNb2D7x34WDqq4Lc08JL1rY6Q+JRkXLCmDnM+QgY7EA7FQWvdGvrI+N2XTTS0FUStBkeuhggiiihlhZ5AF49KBDVIaoSyO11faODGbItvKEm45IS88bMALkBcqEBMYM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-a3122b70439so166116766b.3 for ; Thu, 29 Feb 2024 05:28:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709213338; x=1709818138; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lfL6VXbTGytw9lBNwhw0dS7LOhEc3kbOQ7nqriVFS/k=; b=OeSfeQwBhKWA3kzCXbfJZcbD6502YpxGz0Vhf/vknP4MPftc78gChmrYw/noPBJHwE D1jT/7ruyDvCUWQreHpb21kCvQ+ubFQsG5Y4jIcChwmd+Emnby74TM6POmfpdEMqWtew LeICgBGiiqNSa1EvAMCtQQNlX73vfelAzetxasCHowo9er4tx9b9+JICGfL1jcYIS4C9 244bJvslQgEr+MO3zNjhQ1IkwSvLhc5vGVg8u90UFQhm9kVu34ZzBikKlp8cnyim2OXk luWTNm0ngxPffo4ys62jTG91Pftz7jIF4n6WCHDzsF51M8Y08iGYXTcVeLihd3olFez5 HV1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709213338; x=1709818138; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lfL6VXbTGytw9lBNwhw0dS7LOhEc3kbOQ7nqriVFS/k=; b=JpzZAVa3VrCf6jGNqJbJJmEnYtwfLkeI9adYasGrh/NXEGnixQ+XmVHTdLK+39xlJo VaPc2TGke7tH3vbIXGITet7uFjZ4gq5QtPbsSICkAko7tqcci1TClnPzE+Rj9FhhtXzl 0e9DzawVpWV9rMv35L4SfHm04xNnKzeT15iT3SBdb7SSNq2DLC2v4qxydfiR6xx6icVV Zq4MOGBNwq9g6gRVRWoU7wvY4/b+NvgQ8PWBu3Axkk+z21y7iWDjdSqZEWJ2uBsI48/9 pxjbBUqxzM305usc6DYc6lKAHOfKaAYrKQ5YJUxbY243tEg4erRonEH9LuVs//fLyz+c 1Sew== X-Forwarded-Encrypted: i=1; AJvYcCVjbguto7k1RiEt2X4idAF/GoMNFBBai4Q6NQnJ7TxlAF2WHQ6CjsI/c+Nu8WK6mXSXfCbBO35B09KN+0aulvXZhBQini0e6w== X-Gm-Message-State: AOJu0Yw1/fnSsSJu7a/+t5F1fHBjwi91Li/4KoTJI/O8TzjTkBMo/gbN bIpeNy7+qp5KtRaqoDzz8Pk+/OtN2A0kWtODqAuAN//Q1lz5wCPy X-Google-Smtp-Source: AGHT+IGzGTa1iHGLTLuUVgkl93clFVtsF5PaOECjavn0mRze0MhG4zrIuAYJdXZ5JkjEvdtlDILroA== X-Received: by 2002:a17:906:c30a:b0:a44:3ad:e4c3 with SMTP id s10-20020a170906c30a00b00a4403ade4c3mr1608376ejz.36.1709213338003; Thu, 29 Feb 2024 05:28:58 -0800 (PST) Received: from [192.168.1.23] (ip-149-172-150-237.um42.pools.vodafone-ip.de. [149.172.150.237]) by smtp.gmail.com with ESMTPSA id sa24-20020a1709076d1800b00a440019ac45sm686912ejc.69.2024.02.29.05.28.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Feb 2024 05:28:57 -0800 (PST) Message-ID: Date: Thu, 29 Feb 2024 14:28:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: rdapp.gcc@gmail.com, "juzhe.zhong@rivai.ai" , "kito.cheng@gmail.com" , "richard.guenther@gmail.com" , "Wang, Yanzhang" , "Liu, Hongtao" Subject: Re: [PATCH v2] DSE: Bugfix ICE after allow vector type in get_stored_val Content-Language: en-US To: "Li, Pan2" , Jeff Law , "gcc-patches@gcc.gnu.org" References: <20240226032558.587912-1-pan2.li@intel.com> <20240226142235.3215553-1-pan2.li@intel.com> <793c14cb-2a08-41a4-ac55-4c39295f42d3@gmail.com> From: Robin Dapp In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/29/24 02:38, Li, Pan2 wrote: >> So it's going to check if V2SF can be tied to DI and V4QI with SI. I >> suspect those are going to fail for RISC-V as those aren't tieable. > > Yes, you are right. Different REG_CLASS are not allowed to be tieable in RISC-V. > > static bool > riscv_modes_tieable_p (machine_mode mode1, machine_mode mode2) > { > /* We don't allow different REG_CLASS modes tieable since it > will cause ICE in register allocation (RA). > E.g. V2SI and DI are not tieable. */ > if (riscv_v_ext_mode_p (mode1) != riscv_v_ext_mode_p (mode2)) > return false; > return (mode1 == mode2 > || !(GET_MODE_CLASS (mode1) == MODE_FLOAT > && GET_MODE_CLASS (mode2) == MODE_FLOAT)); > } Yes, but what we set tieable is e.g. V4QI and V2SF. I suggested a target band-aid before: diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc index 799d7919a4a..982ca1a4250 100644 --- a/gcc/config/riscv/riscv.cc +++ b/gcc/config/riscv/riscv.cc @@ -8208,6 +8208,11 @@ riscv_modes_tieable_p (machine_mode mode1, machine_mode mode2) E.g. V2SI and DI are not tieable. */ if (riscv_v_ext_mode_p (mode1) != riscv_v_ext_mode_p (mode2)) return false; + if (GET_MODE_CLASS (GET_MODE_INNER (mode1)) == MODE_INT + && GET_MODE_CLASS (GET_MODE_INNER (mode2)) == MODE_FLOAT + && GET_MODE_SIZE (GET_MODE_INNER (mode1)) + != GET_MODE_SIZE (GET_MODE_INNER (mode2))) + return false; return (mode1 == mode2 || !(GET_MODE_CLASS (mode1) == MODE_FLOAT && GET_MODE_CLASS (mode2) == MODE_FLOAT)); but I don't like that as it just works around something that I didn't even understand fully... Regards Robin